Brings the native implementation of H5Fdelete() from Bitbucket (#524)

* Committing clang-format changes

* Brings the native VFD H5Fdelete() implementation from Bitbucket

Only brings the 'del' callbacks, not the 'open/close' scheme.

* Formatter changes

* Committing clang-format changes

* Fixes direct VFD callback name

* Removes UNUSED macro from family API call

* Adds barrier and rank 0 check to MPI-I/O VFD delete

* Revert "Adds barrier and rank 0 check to MPI-I/O VFD delete"

This reverts commit 909765f759d9d96e84f4b8b1cc14f7d2b3ac8143.

* Revert "Revert "Adds barrier and rank 0 check to MPI-I/O VFD delete""

This reverts commit 9b04bef1157853fc79fcb8fcc3e8ba1371091702.

* Adds a second barrier after the delete in MPI-I/O VFD

* Only delete files in the core VFD when the backing store flag is set

* Fixes string issues in multi VFD

Also, h5test.c cleanup code now uses H5Fdelete().

* Formatted source

* Rework fapl checks for MPI-I/O VFD delete callback

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

1 files changed, 59 insertions, 32 deletions

diff --git a/src/H5FDlog.c b/src/H5FDlog.c
index b836a3d..57902b6 100644
--- a/src/H5FDlog.c
+++ b/src/H5FDlog.c
@@ -177,40 +177,42 @@ static herr_t  H5FD__log_write(H5FD_t *_file, H5FD_mem_t type, hid_t fapl_id, ha
 static herr_t  H5FD__log_truncate(H5FD_t *_file, hid_t dxpl_id, hbool_t closing);
 static herr_t  H5FD__log_lock(H5FD_t *_file, hbool_t rw);
 static herr_t  H5FD__log_unlock(H5FD_t *_file);
+static herr_t  H5FD__log_delete(const char *filename, hid_t fapl_id);
 
 static const H5FD_class_t H5FD_log_g = {
-    "log",                   /* name			*/
-    MAXADDR,                 /* maxaddr		*/
-    H5F_CLOSE_WEAK,          /*  fc_degree		*/
-    H5FD__log_term,          /* terminate            */
-    NULL,                    /* sb_size		*/
-    NULL,                    /* sb_encode		*/
-    NULL,                    /* sb_decode		*/
-    sizeof(H5FD_log_fapl_t), /* fapl_size		*/
-    H5FD__log_fapl_get,      /* fapl_get		*/
-    H5FD__log_fapl_copy,     /* fapl_copy		*/
-    H5FD__log_fapl_free,     /* fapl_free		*/
-    0,                       /* dxpl_size		*/
-    NULL,                    /* dxpl_copy		*/
-    NULL,                    /* dxpl_free		*/
-    H5FD__log_open,          /* open			*/
-    H5FD__log_close,         /* close		*/
-    H5FD__log_cmp,           /* cmp			*/
-    H5FD__log_query,         /* query		*/
-    NULL,                    /* get_type_map		*/
-    H5FD__log_alloc,         /* alloc		*/
-    H5FD__log_free,          /* free			*/
-    H5FD__log_get_eoa,       /* get_eoa		*/
-    H5FD__log_set_eoa,       /* set_eoa		*/
-    H5FD__log_get_eof,       /* get_eof		*/
-    H5FD__log_get_handle,    /* get_handle           */
-    H5FD__log_read,          /* read			*/
-    H5FD__log_write,         /* write		*/
-    NULL,                    /* flush		*/
-    H5FD__log_truncate,      /* truncate		*/
-    H5FD__log_lock,          /* lock                 */
-    H5FD__log_unlock,        /* unlock               */
-    H5FD_FLMAP_DICHOTOMY     /* fl_map		*/
+    "log",                   /* name                */
+    MAXADDR,                 /* maxaddr             */
+    H5F_CLOSE_WEAK,          /*  fc_degree          */
+    H5FD__log_term,          /* terminate           */
+    NULL,                    /* sb_size             */
+    NULL,                    /* sb_encode           */
+    NULL,                    /* sb_decode           */
+    sizeof(H5FD_log_fapl_t), /* fapl_size           */
+    H5FD__log_fapl_get,      /* fapl_get            */
+    H5FD__log_fapl_copy,     /* fapl_copy           */
+    H5FD__log_fapl_free,     /* fapl_free           */
+    0,                       /* dxpl_size           */
+    NULL,                    /* dxpl_copy           */
+    NULL,                    /* dxpl_free           */
+    H5FD__log_open,          /* open                */
+    H5FD__log_close,         /* close               */
+    H5FD__log_cmp,           /* cmp                 */
+    H5FD__log_query,         /* query               */
+    NULL,                    /* get_type_map        */
+    H5FD__log_alloc,         /* alloc               */
+    H5FD__log_free,          /* free                */
+    H5FD__log_get_eoa,       /* get_eoa             */
+    H5FD__log_set_eoa,       /* set_eoa             */
+    H5FD__log_get_eof,       /* get_eof             */
+    H5FD__log_get_handle,    /* get_handle          */
+    H5FD__log_read,          /* read                */
+    H5FD__log_write,         /* write               */
+    NULL,                    /* flush               */
+    H5FD__log_truncate,      /* truncate            */
+    H5FD__log_lock,          /* lock                */
+    H5FD__log_unlock,        /* unlock              */
+    H5FD__log_delete,        /* del                 */
+    H5FD_FLMAP_DICHOTOMY     /* fl_map              */
 };
 
 /* Declare a free list to manage the H5FD_log_t struct */
@@ -1777,3 +1779,28 @@ H5FD__log_unlock(H5FD_t *_file)
 done:
     FUNC_LEAVE_NOAPI(ret_value)
 } /* end H5FD__log_unlock() */
+
+/*-------------------------------------------------------------------------
+ * Function:    H5FD__log_delete
+ *
+ * Purpose:     Delete a file
+ *
+ * Return:      SUCCEED/FAIL
+ *
+ *-------------------------------------------------------------------------
+ */
+static herr_t
+H5FD__log_delete(const char *filename, hid_t H5_ATTR_UNUSED fapl_id)
+{
+    herr_t ret_value = SUCCEED; /* Return value */
+
+    FUNC_ENTER_STATIC
+
+    HDassert(filename);
+
+    if (HDremove(filename) < 0)
+        HSYS_GOTO_ERROR(H5E_VFL, H5E_CANTDELETEFILE, FAIL, "unable to delete file")
+
+done:
+    FUNC_LEAVE_NOAPI(ret_value)
+} /* end H5FD__log_delete() */