diff options
author | Quincey Koziol <koziol@hdfgroup.org> | 2003-01-09 17:20:03 (GMT) |
---|---|---|
committer | Quincey Koziol <koziol@hdfgroup.org> | 2003-01-09 17:20:03 (GMT) |
commit | 9a433b99a56dc575f1c0b11f95b744de61859dbb (patch) | |
tree | d8c766537cb9adc364c902bd45477d97f67a4a9f /src/H5FL.c | |
parent | 7fd449cb7987772a2881a5ced2ae7ad5231f1fa3 (diff) | |
download | hdf5-9a433b99a56dc575f1c0b11f95b744de61859dbb.zip hdf5-9a433b99a56dc575f1c0b11f95b744de61859dbb.tar.gz hdf5-9a433b99a56dc575f1c0b11f95b744de61859dbb.tar.bz2 |
[svn-r6252] Purpose:
Lots of performance improvements & a couple new internal API interfaces.
Description:
Performance Improvements:
- Cached file offset & length sizes in shared file struct, to avoid
constantly looking them up in the FCPL.
- Generic property improvements:
- Added "revision" number to generic property classes to speed
up comparisons.
- Changed method of storing properties from using a hash-table
to the TBBT routines in the library.
- Share the propery names between classes and the lists derived
from them.
- Removed redundant 'def_value' buffer from each property.
- Switching code to use a "copy on write" strategy for
properties in each list, where the properties in each list
are shared with the properties in the class, until a
property's value is changed in a list.
- Fixed error in layout code which was allocating too many buffers.
- Redefined public macros of the form (H5open()/H5check, <variable>)
internally to only be (<variable>), avoiding innumerable useless
calls to H5open() and H5check_version().
- Reuse already zeroed buffers in H5F_contig_fill instead of
constantly re-zeroing them.
- Don't write fill values if writing entire dataset.
- Use gettimeofday() system call instead of time() system when
checking the modification time of a dataset.
- Added reference counted string API and use it for tracking the
names of objects opening in a file (for the ID->name code).
- Removed redundant H5P_get() calls in B-tree routines.
- Redefine H5T datatype macros internally to the library, to avoid
calling H5check redundantly.
- Keep dataspace information for dataset locally instead of reading
from disk each time. Added new module to track open objects
in a file, to allow this (which will be useful eventually for
some FPH5 metadata caching issues).
- Remove H5AC_find macro which was inlining metadata cache lookups,
and call function instead.
- Remove redundant memset() calls from H5G_namei() routine.
- Remove redundant checking of object type when locating objects
in metadata cache and rely on the address only.
- Create default dataset object to use when default dataset creation
property list is used to create datasets, bypassing querying
for all the property list values.
- Use default I/O vector size when performing raw data with the
default dataset transfer property list, instead of querying for
I/O vector size.
- Remove H5P_DEFAULT internally to the library, replacing it with
more specific default property list based on the type of
property list needed.
- Remove redundant memset() calls in object header message (H5O*)
routines.
- Remove redunant memset() calls in data I/O routines.
- Split free-list allocation routines into malloc() and calloc()-
like routines, instead of one combined routine.
- Remove lots of indirection in H5O*() routines.
- Simplify metadata cache entry comparison routine (used when
flushing entire cache out).
- Only enable metadata cache statistics when H5AC_DEBUG is turned
on, instead of always tracking them.
- Simplify address comparison macro (H5F_addr_eq).
- Remove redundant metadata cache entry protections during dataset
creation by protecting the object header once and making all
the modifications necessary for the dataset creation before
unprotecting it.
- Reduce # of "number of element in extent" computations performed
by computing and storing the value during dataspace creation.
- Simplify checking for group location's file information, when file
has not been involving in file-mounting operations.
- Use binary encoding for modification time, instead of ASCII.
- Hoist H5HL_peek calls (to get information in a local heap)
out of loops in many group routine.
- Use static variable for iterators of selections, instead of
dynamically allocation them each time.
- Lookup & insert new entries in one step, avoiding traversing
group's B-tree twice.
- Fixed memory leak in H5Gget_objname_idx() routine (tangential to
performance improvements, but fixed along the way).
- Use free-list for reference counted strings.
- Don't bother copying object names into cached group entries,
since they are re-created when an object is opened.
The benchmark I used to measure these results created several thousand
small (2K) datasets in a file and wrote out the data for them. This is
Elena's "regular.c" benchmark.
These changes resulted in approximately ~4.3x speedup of the
development branch when compared to the previous code in the
development branch and ~1.4x speedup compared to the release
branch.
Additionally, these changes reduce the total memory used (code and
data) by the development branch by ~800KB, bringing the development
branch back into the same ballpark as the release branch.
I'll send out a more detailed description of the benchmark results
as a followup note.
New internal API routines:
Added "reference counted strings" API for tracking strings that get
used by multiple owners without duplicating the strings.
Added "ternary search tree" API for text->object mappings.
Platforms tested:
Tested h5committest {arabica (fortran), eirene (fortran, C++)
modi4 (parallel, fortran)}
Other platforms/configurations tested?
FreeBSD 4.7 (sleipnir) serial & parallel
Solaris 2.6 (baldric) serial
Diffstat (limited to 'src/H5FL.c')
-rw-r--r-- | src/H5FL.c | 209 |
1 files changed, 175 insertions, 34 deletions
@@ -34,12 +34,12 @@ static int interface_initialize_g = 0; Default limits on how much memory can accumulate on each free list before it is garbage collected. */ -static size_t H5FL_reg_glb_mem_lim=1*16*65536;/* Default to 1MB limit on all regular free lists */ -static size_t H5FL_reg_lst_mem_lim=1*65536; /* Default to 64KB limit on each regular free list */ -static size_t H5FL_arr_glb_mem_lim=4*16*65536;/* Default to 4MB limit on all array free lists */ -static size_t H5FL_arr_lst_mem_lim=4*65536; /* Default to 256KB limit on each array free list */ -static size_t H5FL_blk_glb_mem_lim=16*16*65536; /* Default to 16MB limit on all block free lists */ -static size_t H5FL_blk_lst_mem_lim=16*65536; /* Default to 1024KB (1MB) limit on each block free list */ +static size_t H5FL_reg_glb_mem_lim=1*1024*1024; /* Default to 1MB limit on all regular free lists */ +static size_t H5FL_reg_lst_mem_lim=1*65536; /* Default to 64KB limit on each regular free list */ +static size_t H5FL_arr_glb_mem_lim=4*1024*1024; /* Default to 4MB limit on all array free lists */ +static size_t H5FL_arr_lst_mem_lim=4*65536; /* Default to 256KB limit on each array free list */ +static size_t H5FL_blk_glb_mem_lim=16*1024*1024; /* Default to 16MB limit on all block free lists */ +static size_t H5FL_blk_lst_mem_lim=1024*1024; /* Default to 1024KB (1MB) limit on each block free list */ /* A garbage collection node for regular free lists */ typedef struct H5FL_reg_gc_node_t { @@ -248,7 +248,7 @@ done: /*------------------------------------------------------------------------- - * Function: H5FL_reg_alloc + * Function: H5FL_reg_malloc * * Purpose: Allocate a block on a free list * @@ -263,11 +263,11 @@ done: *------------------------------------------------------------------------- */ void * -H5FL_reg_alloc(H5FL_reg_head_t *head, unsigned clear) +H5FL_reg_malloc(H5FL_reg_head_t *head) { void *ret_value; /* Pointer to object to return */ - FUNC_ENTER_NOAPI(H5FL_reg_alloc, NULL); + FUNC_ENTER_NOAPI(H5FL_reg_malloc, NULL); /* Double check parameters */ assert(head); @@ -301,13 +301,46 @@ H5FL_reg_alloc(H5FL_reg_head_t *head, unsigned clear) head->allocated++; } /* end else */ - /* Clear to zeros, if asked */ - if(clear) - HDmemset(ret_value,0,head->size); +done: + FUNC_LEAVE (ret_value); +} /* end H5FL_reg_malloc() */ + + +/*------------------------------------------------------------------------- + * Function: H5FL_reg_calloc + * + * Purpose: Allocate a block on a free list and clear it to zeros + * + * Return: Success: Pointer to a valid object + * Failure: NULL + * + * Programmer: Quincey Koziol + * Monday, December 23, 2002 + * + * Modifications: + * + *------------------------------------------------------------------------- + */ +void * +H5FL_reg_calloc(H5FL_reg_head_t *head) +{ + void *ret_value; /* Pointer to object to return */ + + FUNC_ENTER_NOAPI(H5FL_reg_calloc, NULL); + + /* Double check parameters */ + assert(head); + + /* Allocate the block */ + if (NULL==(ret_value = H5FL_reg_malloc(head))) + HGOTO_ERROR (H5E_RESOURCE, H5E_NOSPACE, NULL, "memory allocation failed"); + + /* Clear to zeros */ + HDmemset(ret_value,0,head->size); done: FUNC_LEAVE (ret_value); -} /* end H5FL_reg_alloc() */ +} /* end H5FL_reg_calloc() */ /*------------------------------------------------------------------------- @@ -562,7 +595,7 @@ H5FL_blk_create_list(H5FL_blk_node_t **head, size_t size) FUNC_ENTER_NOINIT(H5FL_blk_create_list); /* Allocate room for the new free list node */ - if(NULL==(temp=H5FL_ALLOC(H5FL_blk_node_t,0))) + if(NULL==(temp=H5FL_MALLOC(H5FL_blk_node_t))) HGOTO_ERROR(H5E_RESOURCE, H5E_NOSPACE, NULL, "memory allocation failed for chunk info"); /* Set the correct values for the new free list */ @@ -632,7 +665,45 @@ done: /*------------------------------------------------------------------------- - * Function: H5FL_blk_alloc + * Function: H5FL_blk_free_block_avail + * + * Purpose: Checks if a free block of the appropriate size is available + * for a given list. + * + * Return: Success: non-negative + * Failure: negative + * + * Programmer: Quincey Koziol + * Monday, December 16, 2002 + * + * Modifications: + * + *------------------------------------------------------------------------- + */ +htri_t +H5FL_blk_free_block_avail(H5FL_blk_head_t *head, size_t size) +{ + H5FL_blk_node_t *free_list; /* The free list of nodes of correct size */ + htri_t ret_value; /* Return value */ + + FUNC_ENTER_NOAPI(H5FL_blk_free_block_avail, FAIL); + + /* Double check parameters */ + assert(head); + + /* check if there is a free list for blocks of this size */ + /* and if there are any blocks available on the list */ + if((free_list=H5FL_blk_find_list(&(head->head),size))!=NULL && free_list->list!=NULL) + ret_value=TRUE; + else + ret_value=FALSE; +done: + FUNC_LEAVE(ret_value); +} /* end H5FL_blk_free_block_avail() */ + + +/*------------------------------------------------------------------------- + * Function: H5FL_blk_malloc * * Purpose: Allocates memory for a block. This routine is used * instead of malloc because the block can be kept on a free list so @@ -650,13 +721,13 @@ done: *------------------------------------------------------------------------- */ void * -H5FL_blk_alloc(H5FL_blk_head_t *head, size_t size, unsigned clear) +H5FL_blk_malloc(H5FL_blk_head_t *head, size_t size) { H5FL_blk_node_t *free_list; /* The free list of nodes of correct size */ H5FL_blk_list_t *temp; /* Temp. ptr to the new native list allocated */ void *ret_value; /* Pointer to the block to return to the user */ - FUNC_ENTER_NOAPI(H5FL_blk_alloc, NULL); + FUNC_ENTER_NOAPI(H5FL_blk_malloc, NULL); /* Double check parameters */ assert(head); @@ -702,13 +773,50 @@ H5FL_blk_alloc(H5FL_blk_head_t *head, size_t size, unsigned clear) ret_value=((char *)temp)+sizeof(H5FL_blk_list_t); } /* end else */ - /* Clear the block to zeros, if requested */ - if(clear) - HDmemset(ret_value,0,size); +done: + FUNC_LEAVE(ret_value); +} /* end H5FL_blk_malloc() */ + + +/*------------------------------------------------------------------------- + * Function: H5FL_blk_calloc + * + * Purpose: Allocates memory for a block and clear it to zeros. + * This routine is used + * instead of malloc because the block can be kept on a free list so + * they don't thrash malloc/free as much. + * + * Return: Success: valid pointer to the block + * + * Failure: NULL + * + * Programmer: Quincey Koziol + * Monday, December 23, 2002 + * + * Modifications: + * + *------------------------------------------------------------------------- + */ +void * +H5FL_blk_calloc(H5FL_blk_head_t *head, size_t size) +{ + void *ret_value; /* Pointer to the block to return to the user */ + + FUNC_ENTER_NOAPI(H5FL_blk_calloc, NULL); + + /* Double check parameters */ + assert(head); + + /* Allocate the block */ + if (NULL==(ret_value = H5FL_blk_malloc(head,size))) + HGOTO_ERROR (H5E_RESOURCE, H5E_NOSPACE, NULL, "memory allocation failed"); + + /* Clear the block to zeros */ + HDmemset(ret_value,0,size); done: FUNC_LEAVE(ret_value); -} /* end H5FL_blk_alloc() */ +} /* end H5FL_blk_calloc() */ /*------------------------------------------------------------------------- @@ -818,7 +926,7 @@ H5FL_blk_realloc(H5FL_blk_head_t *head, void *block, size_t new_size) /* check if we are actually changing the size of the buffer */ if(new_size!=temp->size) { - if((ret_value=H5FL_blk_alloc(head,new_size,0))==NULL) + if((ret_value=H5FL_blk_malloc(head,new_size))==NULL) HGOTO_ERROR(H5E_RESOURCE, H5E_NOSPACE, NULL, "memory allocation failed for block"); blk_size=MIN(new_size,temp->size); HDmemcpy(ret_value,block,blk_size); @@ -829,7 +937,7 @@ H5FL_blk_realloc(H5FL_blk_head_t *head, void *block, size_t new_size) } /* end if */ /* Not re-allocating, just allocate a fresh block */ else - ret_value=H5FL_blk_alloc(head,new_size,0); + ret_value=H5FL_blk_malloc(head,new_size); done: FUNC_LEAVE(ret_value); @@ -1141,7 +1249,7 @@ done: /*------------------------------------------------------------------------- - * Function: H5FL_arr_alloc + * Function: H5FL_arr_malloc * * Purpose: Allocate an array of objects * @@ -1156,13 +1264,13 @@ done: *------------------------------------------------------------------------- */ void * -H5FL_arr_alloc(H5FL_arr_head_t *head, size_t elem, unsigned clear) +H5FL_arr_malloc(H5FL_arr_head_t *head, size_t elem) { H5FL_arr_node_t *new_obj; /* Pointer to the new free list node allocated */ void *ret_value; /* Pointer to object to return */ size_t mem_size; /* Size of memory block being recycled */ - FUNC_ENTER_NOAPI(H5FL_arr_alloc, NULL); + FUNC_ENTER_NOAPI(H5FL_arr_malloc, NULL); /* Double check parameters */ assert(head); @@ -1215,18 +1323,51 @@ H5FL_arr_alloc(H5FL_arr_head_t *head, size_t elem, unsigned clear) /* Get a pointer to the new block */ ret_value=((char *)new_obj)+sizeof(H5FL_arr_node_t); } /* end else */ - - /* Clear to zeros, if asked */ - if(clear) - HDmemset(ret_value,0,mem_size); } /* end if */ /* No fixed number of elements, use PQ routine */ else - ret_value=H5FL_blk_alloc(&(head->u.queue),mem_size,clear); + ret_value=H5FL_blk_malloc(&(head->u.queue),mem_size); + +done: + FUNC_LEAVE (ret_value); +} /* end H5FL_arr_malloc() */ + + +/*------------------------------------------------------------------------- + * Function: H5FL_arr_calloc + * + * Purpose: Allocate an array of objects and clear it to zeros + * + * Return: Success: Pointer to a valid array object + * Failure: NULL + * + * Programmer: Quincey Koziol + * Monday, December 23, 2002 + * + * Modifications: + * + *------------------------------------------------------------------------- + */ +void * +H5FL_arr_calloc(H5FL_arr_head_t *head, size_t elem) +{ + void *ret_value; /* Pointer to object to return */ + + FUNC_ENTER_NOAPI(H5FL_arr_calloc, NULL); + + /* Double check parameters */ + assert(head); + + /* Allocate the array */ + if (NULL==(ret_value = H5FL_arr_malloc(head,elem))) + HGOTO_ERROR (H5E_RESOURCE, H5E_NOSPACE, NULL, "memory allocation failed"); + + /* Clear to zeros */ + HDmemset(ret_value,0,head->size*elem); done: FUNC_LEAVE (ret_value); -} /* end H5FL_arr_alloc() */ +} /* end H5FL_arr_calloc() */ /*------------------------------------------------------------------------- @@ -1258,7 +1399,7 @@ H5FL_arr_realloc(H5FL_arr_head_t *head, void * obj, size_t new_elem) /* Check if we are really allocating the object */ if(obj==NULL) { - ret_value=H5FL_arr_alloc(head,new_elem,0); + ret_value=H5FL_arr_malloc(head,new_elem); } /* end if */ else { /* Check if there is a maximum number of elements in array */ @@ -1272,7 +1413,7 @@ H5FL_arr_realloc(H5FL_arr_head_t *head, void * obj, size_t new_elem) /* Check if the size is really changing */ if(temp->nelem!=new_elem) { /* Get the new array of objects */ - ret_value=H5FL_arr_alloc(head,new_elem,0); + ret_value=H5FL_arr_malloc(head,new_elem); /* Copy the appropriate amount of elements */ blk_size=head->size*MIN(temp->nelem,new_elem); |