[svn-r2508] Purpose:

    Bug fixes
Description:
    All tests were core=dumping in IRIX64.  The bug is in Generic
    property list creation in which malloc asked for 2*64-1 bytes
    due to coding bug.  The object creation failed but the return
    code was not checked.  Program eventually crashed.
Solution:
H5F.c:
    Check the return code from new file object creation and flag
    error accordingly.
H5FL.c:
    H5FL_arr_free is a replacement for H5MM_xfree which accepts
    null value as a legal argument value.  H5FL_arr_free assert
    on it.  Since other parts of the code have been passing null
    value to H5MM_xfree, H5FL_arr_free must accept it too until
    all the calling routines are changed to not pass Null.
H5P.c:
    some routine passes in 0 as the hashsize value which is uintn.
    The expression (hashsize-1) underflows to the largest unsigned
    int for some machines.  Thus the calloc failed.  Cast hashsize
    to unsigned int first (this assumes hashsize stays within the
    signed int data range.
H5Smpio.c:
    Added the extra parameter because the H5FD_write has been redefined.

Platforms tested:
    IRIX64 -64 and -n32

1 files changed, 6 insertions, 4 deletions

diff --git a/src/H5FL.c b/src/H5FL.c
index 897e98a..701a6d9 100644
--- a/src/H5FL.c
+++ b/src/H5FL.c
@@ -1144,13 +1144,15 @@ H5FL_arr_free(H5FL_arr_head_t *head, void *obj)
 
     FUNC_ENTER (H5FL_arr_free, NULL);
 
-    /* Double check parameters */
-    assert(head);
-    assert(obj);
-
 #ifdef NO_ARR_FREE_LISTS
     H5MM_xfree(obj);
 #else /* NO_ARR_FREE_LISTS */
+    /* The H5MM_xfree code allows obj to null */
+    if (!obj) return (NULL);
+
+    /* Double check parameters */
+    assert(head);
+
     /* Make certain that the free list is initialized */
     assert(head->init);