[svn-r16847] Description:

	Bring r16846 from revise_chunks branch back to trunk:

	Fix broken (for how long?) H5_ASSIGN_OVERFLOW macro to actually detect
overflows during assignments, along with several errors it [now] detected.

	Cleaned up a fix minor warnings and/or pieces of code also.

Tested on:
	FreeBSD/32 6.3 (duty) in debug mode
	(h5committest not needed - multi-platform test performed on branch)

1 files changed, 3 insertions, 13 deletions

diff --git a/src/H5FL.c b/src/H5FL.c
index dca300c..c72491d 100644
--- a/src/H5FL.c
+++ b/src/H5FL.c
@@ -101,10 +101,10 @@ typedef struct H5FL_blk_gc_list_t {
 static H5FL_blk_gc_list_t H5FL_blk_gc_head={0,NULL};
 
 /* A garbage collection node for factory free lists */
-typedef struct H5FL_fac_gc_node_t {
+struct H5FL_fac_gc_node_t {
     H5FL_fac_head_t *list;              /* Pointer to the head of the list to garbage collect */
     struct H5FL_fac_gc_node_t *next;    /* Pointer to the next node in the list of things to garbage collect */
-} H5FL_fac_gc_node_t;
+};
 
 /* The garbage collection head for factory free lists */
 typedef struct H5FL_fac_gc_list_t {
@@ -113,18 +113,8 @@ typedef struct H5FL_fac_gc_list_t {
 } H5FL_fac_gc_list_t;
 
 /* Data structure to store each block in factory free list */
-typedef struct H5FL_fac_node_t {
+struct H5FL_fac_node_t {
     struct H5FL_fac_node_t *next;   /* Pointer to next block in free list */
-} H5FL_fac_node_t;
-
-/* Data structure for free list block factory */
-struct H5FL_fac_head_t {
-    unsigned init;      /* Whether the free list has been initialized */
-    unsigned allocated; /* Number of blocks allocated */
-    unsigned onlist;    /* Number of blocks on free list */
-    size_t size;        /* Size of the blocks in the list */
-    H5FL_fac_node_t *list;  /* List of free blocks */
-    H5FL_fac_gc_node_t *prev_gc; /* Previous garbage collection node in list */
 };
 
 /* The head of the list of factory things to garbage collect */