diff options
author | Bill Wendling <wendling@ncsa.uiuc.edu> | 2003-05-07 20:52:36 (GMT) |
---|---|---|
committer | Bill Wendling <wendling@ncsa.uiuc.edu> | 2003-05-07 20:52:36 (GMT) |
commit | db543f1a23194e81d0a984c346398e72bf4be87f (patch) | |
tree | 87ca6828a7687d0a5a88534f80d77e2ecc91c04b /src/H5Fcompact.c | |
parent | 36a0b8e3dd1c325c201c4cd5a094df8a3588fa9a (diff) | |
download | hdf5-db543f1a23194e81d0a984c346398e72bf4be87f.zip hdf5-db543f1a23194e81d0a984c346398e72bf4be87f.tar.gz hdf5-db543f1a23194e81d0a984c346398e72bf4be87f.tar.bz2 |
[svn-r6823] Purpose:
Code Improvements/Bug Fixes
Description:
Comparison of equality of a double/float variable to 0.0 is not
guaranteed to work and is bad practice.
In H5Fcontig.c, a warning was given by a statement like:
x = (++x) % y;
This could be confusing to a compiler I suppose.
In H5RS.c, a typedef of a structure was being tagged by the compiler
as "useless" because it had the form:
typedef struct foo {
int var1;
/* ... */
}; /* <--- note no name for this typedef */
The statement "typedef struct foo foo" is already in the header file.
Solution:
Test that the absolute value of the variable is < a very small
positive number.
Changed "x = (++x) % y" to "++x; x %= y;" instead.
Removed the "typedef" from the structure in the H5RS.c file.
Platforms tested:
Modi4 (Parallel & Fortran)
Verbena (C++ & Fortran)
Arabica (Fortran)
Misc. update:
Diffstat (limited to 'src/H5Fcompact.c')
0 files changed, 0 insertions, 0 deletions