diff options
| author | Robb Matzke <matzke@llnl.gov> | 1998-10-05 21:01:10 (GMT) |
|---|---|---|
| committer | Robb Matzke <matzke@llnl.gov> | 1998-10-05 21:01:10 (GMT) |
| commit | 21943f5d35f98b35c3c0182d56f81b4854269dd6 (patch) | |
| tree | a5024e9eb5ca6a40f07ae224fcf49d3f4782785c /src/H5Fmpio.c | |
| parent | 58ee080e72f4aa1e10bc7c3fcf5f6499aaad18e7 (diff) | |
| download | hdf5-21943f5d35f98b35c3c0182d56f81b4854269dd6.zip hdf5-21943f5d35f98b35c3c0182d56f81b4854269dd6.tar.gz hdf5-21943f5d35f98b35c3c0182d56f81b4854269dd6.tar.bz2 | |
[svn-r735] Changes since 19981002
----------------------
./src/H5D.c
Fill values are working for contiguous datasets now except
there are two things that need more support from the data
space layer, specifically the ability to form a selection from
the difference of two selections. They are (1) extending an
external contiguous dataset, (2) optimization by delaying the
fill until after the first H5Dwrite().
Renamed H5D_allocate() to H5D_init_storage() since allocation
is only part of the story. Added a data space argument so it
doesn't have to query the space from the object header -- the
space is always available in the caller anyway.
Removed `#ifdef HAVE_PARALLEL' from a few places where it
wasn't necessary. We don't need it around code that doesn't
compile anything from mpi.h or mpio.h.
./src/H5Fistore.c
Uncommented H5F_istore_alloc() for non-parallel and moved the
`#ifdef HAVE_PARALLEL' just around Kim's barrier.
./src/H5Fmpio.c
Wrapped a couple long lines.
Got rid of two signed vs. unsigned comparison warnings.
./MANIFEST
./test/Makefile.in
./test/fillval.c [NEW]
Added tests for fill values. The contiguous dataset extend
test is disabled until H5S_SELECT_DIFF is implemented.
./tools/Makefile.in
Fixed a bug where `make test' didn't build the executables
first. This should cause the snapshots to start up again.
./Makefile.in
Changed to build in `test' directory before `tools'
directory. We want the library tests to pass before we even
start considering the tools. You can still build and/or test
the tools independent of the library tests passing.
Diffstat (limited to 'src/H5Fmpio.c')
| -rw-r--r-- | src/H5Fmpio.c | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/src/H5Fmpio.c b/src/H5Fmpio.c index 8ca50d8..2ebe5c8 100644 --- a/src/H5Fmpio.c +++ b/src/H5Fmpio.c @@ -335,7 +335,8 @@ H5F_mpio_open(const char *name, const H5F_access_t *access_parms, uintn flags, } #endif - mpierr = MPI_File_open(access_parms->u.mpio.comm, (char*)name, mpi_amode, access_parms->u.mpio.info, &fh); + mpierr = MPI_File_open(access_parms->u.mpio.comm, (char*)name, mpi_amode, + access_parms->u.mpio.info, &fh); if (MPI_SUCCESS != mpierr) { MPI_Error_string( mpierr, mpierrmsg, &msglen ); HRETURN_ERROR(H5E_IO, H5E_CANTOPENFILE, NULL, mpierrmsg ); @@ -511,7 +512,7 @@ H5F_mpio_read(H5F_low_t *lf, H5F_access_t *access_parms, "couldn't convert addr to MPIOffset" ); } size_i = (int)size; - if (size_i != size) { /* check type conversion */ + if ((size_t)size_i != size) { /* check type conversion */ HRETURN_ERROR(H5E_IO, H5E_BADTYPE, FAIL, "couldn't convert size to int" ); } @@ -764,7 +765,7 @@ H5F_mpio_write(H5F_low_t *lf, H5F_access_t *access_parms, "couldn't convert addr to MPIOffset" ); } size_i = (int)size; - if (size_i != size) { /* check type conversion */ + if ((size_t)size_i != size) { /* check type conversion */ HRETURN_ERROR(H5E_IO, H5E_BADTYPE, FAIL, "couldn't convert size to int" ); } @@ -975,9 +976,11 @@ H5F_MPIOff_to_haddr( MPI_Offset mpi_off, haddr_t *addr ) * Problems and limitations: * * Return: Success: return value is SUCCEED - * and the MPIOffset contains the converted value + * and the MPIOffset contains the converted + * value. * - * Failure: return value is FAIL, the MPIOffset is undefined + * Failure: return value is FAIL, the MPIOffset is + * undefined. * * Programmer: * January 30, 1998 |