[svn-r4643] Purpose:

    Code cleanup
Description:
    Windows is generating hundreds of warnings from some of the practices in
    the library.  Mostly, they are because size_t is 32-bit and hsize_t is
    64-bit on Windows and we were carelessly casting the larger values down to
    the smaller ones without checking for overflow.

    Also, some other small code cleanups,etc.

Solution:
    Re-worked some algorithms to eliminate the casts and also added more
    overflow checking for assignments and function parameters which needed
    casts.

    Kent did most of the work, I just went over his changes and fit them into
    the the library code a bit better.

Platforms tested:
    FreeBSD 4.4 (hawkwind)

1 files changed, 6 insertions, 0 deletions

diff --git a/src/H5Fpkg.h b/src/H5Fpkg.h
index 22cae65..0bff2a8 100644
--- a/src/H5Fpkg.h
+++ b/src/H5Fpkg.h
@@ -61,6 +61,12 @@
 #else
 #   define H5F_OVERFLOW_SIZET2OFFT(X) 0
 #endif
+#if (H5_SIZEOF_HSIZE_T >= SIZEOF_OFF_T)
+#   define H5F_OVERFLOW_HSIZET2OFFT(X)					      \
+    ((hsize_t)(X)>=(hsize_t)((hsize_t)1<<(8*sizeof(off_t)-1)))
+#else
+#   define H5F_OVERFLOW_SIZET2OFFT(X) 0
+#endif
 
 /* The raw data chunk cache */
 typedef struct H5F_rdcc_t {