diff options
| author | Neil Fortner <nfortne2@hdfgroup.org> | 2015-07-01 22:08:11 (GMT) |
|---|---|---|
| committer | Neil Fortner <nfortne2@hdfgroup.org> | 2015-07-01 22:08:11 (GMT) |
| commit | 9804fed58f4f30843d406861a2daf67944c244de (patch) | |
| tree | 37ef75018769aa13ad604dc9be42dfd81d8a9812 /src/H5Gcache.c | |
| parent | 980db9e85b902bcd0e183e00c5ebe02ec365dc22 (diff) | |
| download | hdf5-9804fed58f4f30843d406861a2daf67944c244de.zip hdf5-9804fed58f4f30843d406861a2daf67944c244de.tar.gz hdf5-9804fed58f4f30843d406861a2daf67944c244de.tar.bz2 | |
[svn-r27320] Fix uninitialized memory write valgrind errors in trunk. Did this by modifying
metadata cache clients to clear unused memory in the buffer after serializing.
Tested: ummon; jam, koala, ostrich (h5committest)
Diffstat (limited to 'src/H5Gcache.c')
| -rw-r--r-- | src/H5Gcache.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/H5Gcache.c b/src/H5Gcache.c index 8dfecb1..f765b41 100644 --- a/src/H5Gcache.c +++ b/src/H5Gcache.c @@ -316,8 +316,10 @@ H5G__cache_node_serialize(const H5F_t *f, void *_image, size_t len, if(H5G__ent_encode_vec(f, &image, sym->entry, sym->nsyms) < 0) HGOTO_ERROR(H5E_SYM, H5E_CANTENCODE, FAIL, "can't serialize") +#ifdef H5_CLEAR_MEMORY /* Clear rest of symbol table node */ - HDmemset(image, 0, sym->node_size - (size_t)(image - (uint8_t *)_image)); + HDmemset(image, 0, len - (size_t)(image - (uint8_t *)_image)); +#endif /* H5_CLEAR_MEMORY */ done: FUNC_LEAVE_NOAPI(ret_value) |