summaryrefslogtreecommitdiffstats
path: root/src/H5HLcache.c
diff options
context:
space:
mode:
authorQuincey Koziol <koziol@hdfgroup.org>2010-03-06 21:24:31 (GMT)
committerQuincey Koziol <koziol@hdfgroup.org>2010-03-06 21:24:31 (GMT)
commit9211b9e5b6f158310ffbe0942a3d254ccafc9693 (patch)
treec0b6ac392ec67d3394d36898de7d66e81ebbd621 /src/H5HLcache.c
parent8b3a2b480b412ebb04997d57343fc0733906afe6 (diff)
downloadhdf5-9211b9e5b6f158310ffbe0942a3d254ccafc9693.zip
hdf5-9211b9e5b6f158310ffbe0942a3d254ccafc9693.tar.gz
hdf5-9211b9e5b6f158310ffbe0942a3d254ccafc9693.tar.bz2
[svn-r18389] Description:
Bring r18388 from trunk back to 1.8 branch: Bring changes from Coverity session from branch into trunk: r18378: Fixed coverity issues 207 and 322. Pointer hdr was checked for NULL after being asserted and dereferenced. Check was removed. r18379: Fix coverity issues # 88 and # 435. r18380: Fixed Coverity issue # 85. Added check of returned pointer for NULL before use. r18381: Resolve coverity issues # 214 and # 215 r18382: Issue 131: Add null checks to allocations and check for free in error handling r18383: Issue 421: Reorganized code to make intention clearer. Also, set local variable fl to NULL after transfer to tail. Heap->freelist will take care of all allocations r18384: Coverity #249 and #250 - STRING_ATT_CHECK wasn't allocated before being used and freed in function test_write_vl_string_attribute and test_read_vl_string_attribute. Tested on: Mac OS X/32 10.6.2 (amazon) w/debug & prod (h5committested in daily tests)
Diffstat (limited to 'src/H5HLcache.c')
-rw-r--r--src/H5HLcache.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/H5HLcache.c b/src/H5HLcache.c
index b1875b2..2063780 100644
--- a/src/H5HLcache.c
+++ b/src/H5HLcache.c
@@ -171,12 +171,12 @@ H5HL_fl_deserialize(H5HL_t *heap, hsize_t free_block)
if(fl->offset + fl->size > heap->dblk_size)
HGOTO_ERROR(H5E_HEAP, H5E_BADRANGE, FAIL, "bad heap free list")
- /* Insert node into list */
+ /* Append node onto list */
if(tail)
tail->next = fl;
- tail = fl;
- if(!heap->freelist)
+ else
heap->freelist = fl;
+ tail = fl;
fl = NULL;
} /* end while */