diff options
| author | Raymond Lu <songyulu@hdfgroup.org> | 2009-06-26 20:24:42 (GMT) |
|---|---|---|
| committer | Raymond Lu <songyulu@hdfgroup.org> | 2009-06-26 20:24:42 (GMT) |
| commit | c0f0e7c4198de81d1d19c3a2e1a973380409737f (patch) | |
| tree | ee9923a72e2a529c377553a004f8b7983ca39743 /src/H5Oattr.c | |
| parent | 4af1a11dcf7050adb19503f716fb4baee2bc7970 (diff) | |
| download | hdf5-c0f0e7c4198de81d1d19c3a2e1a973380409737f.zip hdf5-c0f0e7c4198de81d1d19c3a2e1a973380409737f.tar.gz hdf5-c0f0e7c4198de81d1d19c3a2e1a973380409737f.tar.bz2 | |
[svn-r17124] Bug fix #1513. Reading an empty attribute caused seg fault. The flag "initialized" in
the attribute structure wan't set correctly. It caused some confusion in H5A_read. This
flag was actually redundant because the library can alwasy check if the data buffer is
present. To fix it, I removed the "initialized" flag in the attribute structure and let
H5A_read check the data buffer.
I tested it on jam only but have tested the same change for the trunk on jam, smirom,
and linew.
Diffstat (limited to 'src/H5Oattr.c')
| -rw-r--r-- | src/H5Oattr.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/H5Oattr.c b/src/H5Oattr.c index 27b9d5e..1e85c69 100644 --- a/src/H5Oattr.c +++ b/src/H5Oattr.c @@ -226,9 +226,6 @@ H5O_attr_decode(H5F_t *f, hid_t dxpl_id, H5O_t *open_oh, unsigned UNUSED mesg_fl HDmemcpy(attr->shared->data, p, attr->shared->data_size); } /* end if */ - /* Indicate that the fill values aren't to be written out */ - attr->shared->initialized = 1; - /* Increment the reference count for this object header message in cache(compact storage) or for the object from dense storage. */ attr->shared->nrefs++; @@ -805,9 +802,6 @@ H5O_attr_debug(H5F_t *f, hid_t dxpl_id, const void *_mesg, FILE * stream, int in "Character Set of Name:", s); HDfprintf(stream, "%*s%-*s %t\n", indent, "", fwidth, - "Initialized:", - mesg->shared->initialized); - HDfprintf(stream, "%*s%-*s %t\n", indent, "", fwidth, "Object opened:", mesg->obj_opened); HDfprintf(stream, "%*s%-*s %a\n", indent, "", fwidth, |