diff options
| author | Vailin Choi <vchoi@jam.ad.hdfgroup.org> | 2017-08-23 21:23:09 (GMT) |
|---|---|---|
| committer | Vailin Choi <vchoi@jam.ad.hdfgroup.org> | 2017-08-23 21:23:09 (GMT) |
| commit | 1ef8577a4aaaa4120a819ff36747fdca99abdc26 (patch) | |
| tree | f360f1e27e145cb82608eb11079c9aff876d0984 /src/H5Oefl.c | |
| parent | b07eb6efd06bbe44562fe6c93e826f40a56c01d2 (diff) | |
| download | hdf5-1ef8577a4aaaa4120a819ff36747fdca99abdc26.zip hdf5-1ef8577a4aaaa4120a819ff36747fdca99abdc26.tar.gz hdf5-1ef8577a4aaaa4120a819ff36747fdca99abdc26.tar.bz2 | |
Modifications based on comments from pull request review
(1) Remove unnecessary asserts
(2) Add code to insert bad offset values to the test file in gen_bad_offset.c
Diffstat (limited to 'src/H5Oefl.c')
| -rw-r--r-- | src/H5Oefl.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/H5Oefl.c b/src/H5Oefl.c index 2273289..7d78caf 100644 --- a/src/H5Oefl.c +++ b/src/H5Oefl.c @@ -151,7 +151,8 @@ H5O_efl_decode(H5F_t *f, hid_t dxpl_id, H5O_t H5_ATTR_UNUSED *open_oh, if((s = (const char *)H5HL_offset_into(heap, mesg->slot[u].name_offset)) == NULL) HGOTO_ERROR(H5E_SYM, H5E_CANTGET, NULL, "unable to get external file name") - HDassert(s && *s); + if(*s == NULL) + HGOTO_ERROR(H5E_SYM, H5E_CANTGET, NULL, "invalid external file name") mesg->slot[u].name = H5MM_xstrdup (s); HDassert(mesg->slot[u].name); |