summaryrefslogtreecommitdiffstats
path: root/src/H5Ostab.c
diff options
context:
space:
mode:
authorRobb Matzke <matzke@llnl.gov>1997-08-09 16:45:59 (GMT)
committerRobb Matzke <matzke@llnl.gov>1997-08-09 16:45:59 (GMT)
commita260c7849c1ca59bd32cde9d12380e89afd70770 (patch)
treea4d791e5df2d17b3fd6988ca84e363560b1c87cf /src/H5Ostab.c
parent0d050fcd579bf1db6db2d8a1d3fec617114bfd1f (diff)
downloadhdf5-a260c7849c1ca59bd32cde9d12380e89afd70770.zip
hdf5-a260c7849c1ca59bd32cde9d12380e89afd70770.tar.gz
hdf5-a260c7849c1ca59bd32cde9d12380e89afd70770.tar.bz2
[svn-r17] ./src/H5AC.c
Renamed H5AC_find() to H5AC_find_f() which is invoked from the H5AC_find() macro. Changed HASH() to H5AC_HASH(). ./src/H5ACprivate.h Increased the number of cache slots from 1033 to 10330 to see how it affects performance. This should probably be changeable on a per-file basis. ./src/H5B.c Fixed some bugs now that symbol tables are actually using the stuff. Improved debugging a little. Fixed uninitialized memory appearing in the file. ./src/H5D.c Changed a FUNC_ENTER() argument from H5Dset_info to H5Dwrite. ./src/H5F.c Plugged a memory leak in H5F_dest(). ./src/H5G.c ./src/H5Gprivate.h Many of these functions take a symbol table entry which describes the symbol table rather than just the symbol table address. Moved some functions to make room for the ones that understand directory names: H5G_new() -> H5G_stab_new() H5G_find() -> H5G_stab_find() H5G_modify() -> H5G_stab_modify() H5G_insert() -> H5G_stab_insert() H5G_list() -> H5G_stab_list() ./src/H5Gnode.c Added more assertions. Zero new memory so junk doesn't appear in the data file. This is a problem when one tries to declassify a classified data file. H5G_node_debug() can take an extra argument which is the address of the heap for the symbol table. If supplied, the symbol names are printed along with the heap offsets. ./src/H5H.c ./src/H5Hprivate.h Fixed a bug with the free blocks by forcing things to align on even boundaries. It's still possible to lose heap memory if the hole is smaller than the free list header. The alternative is to align heap objects on 12 or 20 byte boundaries, but this tends to waste to much space. Zero new memory like with H5Gnode.c. Fixed a "mispeling" of NDEBUG. ./src/H5Ocont.c ./src/H5Onull.c Added the pablo mask defn. ./src/H5Ostab.c Added the pablo mask defn. Fixed a read from uninitialized memory. ./src/H5Oprivate.h Tuned some parameters to see how they affect performance. ./src/debug.c An optional third argument can be supplied which is the address of a heap to use to display names in a symbol table. ./src/hdf5pabl.h Changed `int' to `intn'.
Diffstat (limited to 'src/H5Ostab.c')
-rw-r--r--src/H5Ostab.c26
1 files changed, 17 insertions, 9 deletions
diff --git a/src/H5Ostab.c b/src/H5Ostab.c
index ec6dd61..d2c1394 100644
--- a/src/H5Ostab.c
+++ b/src/H5Ostab.c
@@ -23,6 +23,8 @@
#include "H5MMprivate.h"
#include "H5Oprivate.h"
+#define PABLO_MASK H5O_stab_mask
+
/* PRIVATE PROTOTYPES */
static void *H5O_stab_decode (hdf5_file_t *f, const uint8 *p);
static herr_t H5O_stab_encode (hdf5_file_t *f, size_t size, uint8 *p,
@@ -200,20 +202,26 @@ H5O_stab_cache (H5G_entry_t *ent, const void *_mesg)
assert (ent);
assert (stab);
- /* cache */
+ /*
+ * We do this in two steps so Purify doesn't complain about
+ * uninitialized memory reads even though they don't bother
+ * anything.
+ */
if (H5G_CACHED_STAB != ent->type) {
modified = TRUE;
ent->type = H5G_CACHED_STAB;
- }
-
- if (ent->cache.stab.btree != stab->btree) {
- modified = TRUE;
ent->cache.stab.btree = stab->btree;
- }
-
- if (ent->cache.stab.heap != stab->heap) {
- modified = TRUE;
ent->cache.stab.heap = stab->heap;
+ } else {
+ if (ent->cache.stab.btree != stab->btree) {
+ modified = TRUE;
+ ent->cache.stab.btree = stab->btree;
+ }
+
+ if (ent->cache.stab.heap != stab->heap) {
+ modified = TRUE;
+ ent->cache.stab.heap = stab->heap;
+ }
}
FUNC_LEAVE (modified);