Be brief: turn 7 lines of if-else to one line of ?:. Be sensible: don't

assert a pointer we just dereferenced is non-NULL.

1 files changed, 1 insertions, 10 deletions

diff --git a/src/H5PB.c b/src/H5PB.c
index a8fbf4e..c81212a 100644
--- a/src/H5PB.c
+++ b/src/H5PB.c
@@ -1755,16 +1755,7 @@ H5PB_vfd_swmr__update_index(H5F_t *f,
         ie_ptr->tick_of_last_change  = shared->tick_num;
         ie_ptr->clean                = !entry->is_dirty;
 
-        if ( ie_ptr->clean ) {
-
-            ie_ptr->tick_of_last_flush = shared->tick_num;
-
-        } else {
-
-            ie_ptr->tick_of_last_flush = 0;
-        }
-
-        HDassert(ie_ptr);
+        ie_ptr->tick_of_last_flush = ie_ptr->clean ? shared->tick_num : 0;
     }
 
     /* scan the metadata file index for entries that don't appear in the