[svn-r9329]

Purpose:
Feature

Description:
Datatypes and groups now use H5FO "file object" code that was previously
only used by datasets.  These objects will hold a file open if the file
is closed but they have not yet been closed.  If these objects are unlinked
then relinked, they will not be destroyed.  If they are opened twice (even
by two different names), both IDs will "see" changes made to the object
using the other ID.
When an object is opened using two different names (e.g., if a dataset was
opened under one name, then mounted and opened under its new name), calling
H5Iget_name() on a given hid_t will return the name used to open that hid_t,
not the current name of the object (this is a feature, and a change from the
previous behavior of datasets).

Solution:
Used H5FO code that was already in place for datasets.  Broke H5D_t's, H5T_t's,
and H5G_t's into a "shared" struct and a private struct.  The shared structs
(H5D_shared_t, etc.) hold the object's information and are used by all IDs
that point to a given object in the file.  The private structs are pointed
to by the hid_t and contain the object's group entry information (including its
name) and a pointer to the shared struct for that object.
This changed the naming of structs throughout the library (e.g., datatype->size
is now datatype->shared->size).  I added an updated H5Tinit.c to windows.zip.

Platforms tested:
Visual Studio 7, sleipnir, arabica, verbena

Misc. update:

1 files changed, 17 insertions, 10 deletions

diff --git a/src/H5R.c b/src/H5R.c
index 3bbb5e5..ba699e8 100644
--- a/src/H5R.c
+++ b/src/H5R.c
@@ -324,8 +324,9 @@ done:
 static hid_t
 H5R_dereference(H5F_t *file, hid_t dxpl_id, H5R_type_t ref_type, void *_ref)
 {
+    H5D_t *dset;                /* Pointer to dataset to open */
+    H5T_t *type;                /* Pointer to datatype to open */
     H5G_t *group;               /* Pointer to group to open */
-    H5T_t *datatype;            /* Pointer to datatype to open */
     H5G_entry_t ent;            /* Symbol table entry */
     uint8_t *p;                 /* Pointer to OID to store */
     int oid_type;               /* type of object being dereferenced */
@@ -389,14 +390,14 @@ H5R_dereference(H5F_t *file, hid_t dxpl_id, H5R_type_t ref_type, void *_ref)
     if(H5O_link(&ent,0,dxpl_id)<=0)
         HGOTO_ERROR(H5E_REFERENCE, H5E_LINKCOUNT, FAIL, "dereferencing deleted object");
 
-    /* Open the dataset object */
+    /* Open the object */
     oid_type=H5G_get_type(&ent,dxpl_id);
     switch(oid_type) {
         case H5G_GROUP:
-            if ((group=H5G_open_oid(&ent,dxpl_id)) == NULL)
+            if ((group=H5G_open(&ent,dxpl_id)) == NULL)
                 HGOTO_ERROR(H5E_SYM, H5E_NOTFOUND, FAIL, "not found");
 
-            /* Create an atom for the dataset */
+            /* Create an atom for the group */
             if ((ret_value = H5I_register(H5I_GROUP, group)) < 0) {
                 H5G_close(group);
                 HGOTO_ERROR(H5E_SYM, H5E_CANTREGISTER, FAIL, "can't register group");
@@ -404,20 +405,26 @@ H5R_dereference(H5F_t *file, hid_t dxpl_id, H5R_type_t ref_type, void *_ref)
             break;
 
         case H5G_TYPE:
-            if ((datatype=H5T_open_oid(&ent, dxpl_id)) == NULL)
+            if ((type=H5T_open(&ent, dxpl_id)) == NULL)
                 HGOTO_ERROR(H5E_DATATYPE, H5E_NOTFOUND, FAIL, "not found");
 
-            /* Create an atom for the dataset */
-            if ((ret_value = H5I_register(H5I_DATATYPE, datatype)) < 0) {
-                H5T_close(datatype);
-                HGOTO_ERROR(H5E_DATATYPE, H5E_CANTREGISTER, FAIL, "can't register group");
+            /* Create an atom for the datatype */
+            if ((ret_value = H5I_register(H5I_DATATYPE, type)) < 0) {
+                H5T_close(type);
+                HGOTO_ERROR(H5E_DATATYPE, H5E_CANTREGISTER, FAIL, "can't register datatype");
             }
             break;
 
         case H5G_DATASET:
             /* Open the dataset */
-            if ((ret_value=H5D_open(&ent,dxpl_id)) < 0)
+            if ((dset=H5D_open(&ent,dxpl_id)) <0)
                 HGOTO_ERROR(H5E_DATASET, H5E_NOTFOUND, FAIL, "not found");
+
+            /* Create an atom for the dataset */
+            if ((ret_value = H5I_register(H5I_DATASET, dset)) < 0) {
+                H5D_close(dset);
+                HGOTO_ERROR(H5E_DATASET, H5E_CANTREGISTER, FAIL, "can't register dataset");
+            }
             break;
 
         default: