[svn-r6823] Purpose:

    Code Improvements/Bug Fixes

Description:
    Comparison of equality of a double/float variable to 0.0 is not
    guaranteed to work and is bad practice.

    In H5Fcontig.c, a warning was given by a statement like:

        x = (++x) % y;

    This could be confusing to a compiler I suppose.

    In H5RS.c, a typedef of a structure was being tagged by the compiler
    as "useless" because it had the form:

        typedef struct foo {
            int var1;
            /* ... */
        }; /* <--- note no name for this typedef */

    The statement "typedef struct foo foo" is already in the header file.

Solution:
    Test that the absolute value of the variable is < a very small
    positive number.

    Changed "x = (++x) % y" to "++x; x %= y;" instead.

    Removed the "typedef" from the structure in the H5RS.c file.

Platforms tested:
    Modi4   (Parallel & Fortran)
    Verbena (C++ & Fortran)
    Arabica (Fortran)

Misc. update:

1 files changed, 1 insertions, 1 deletions

diff --git a/src/H5RS.c b/src/H5RS.c
index d710774..93ef3aa 100644
--- a/src/H5RS.c
+++ b/src/H5RS.c
@@ -31,7 +31,7 @@ static int		interface_initialize_g = 0;
 #define INTERFACE_INIT	NULL
 
 /* Private typedefs & structs */
-typedef struct H5RS_str_t {
+struct H5RS_str_t {
     char *s;            /* String to be reference counted */
     unsigned wrapped;   /* Indicates that the string to be ref-counted is not copied */
     unsigned n;         /* Reference count of number of pointers sharing string */