[svn-r13143] Refactoring.

Added can_share callback for OH messages.  This determines whether the
message is allowed to be shared in the heap (committed and immutable datatypes
can't be).
Fixed a bug in the dense attribute storage that tried to open the shared message
heap when it hadn't been created yet.
Made the test to extend shared dataspace messages a bit more robust.
Refactored the code the searches a shared message list index to be a little
more efficient.
A few other minor changes.

Tested on smirom, kagiso, Windows, and juniper.

1 files changed, 1 insertions, 2 deletions

diff --git a/src/H5SMbtree2.c b/src/H5SMbtree2.c
index 1b5cb98..b59304f 100755
--- a/src/H5SMbtree2.c
+++ b/src/H5SMbtree2.c
@@ -150,9 +150,9 @@ H5SM_message_compare(const void *rec1, const void *rec2)
         /* Compare either the heap_ids directly (if the key has one)
          * or the encoded buffers
          */
-        /* JAMES: not a great test.  Use a flag instead? */
         if(key->encoding_size == 0)
         {
+            HDassert(key->encoding == NULL);
             ret_value = (herr_t) (key->message.fheap_id - mesg->fheap_id);
         }
         else
@@ -160,7 +160,6 @@ H5SM_message_compare(const void *rec1, const void *rec2)
             /* Hash values match, but we don't have a heap ID for the key.
              * Compare the encoded message with the one in the heap.
              */
-            /* JAMES: can we hold off encoding until now? */
             H5SM_compare_udata udata;
             herr_t ret;