[svn-r29978] Description:

    Bring r29914 from revise_chunks branch to trunk:

Banished -Wformat= warnings from the library, tools, and tests.

Tested on:
    MacOSX/64 10.11.5 (amazon) w/serial, parallel & production
    (h5committest forthcoming)

1 files changed, 19 insertions, 15 deletions

diff --git a/src/H5ST.c b/src/H5ST.c
index 7b61aa1..09c4600 100644
--- a/src/H5ST.c
+++ b/src/H5ST.c
@@ -23,6 +23,10 @@ Bentley and Robert Sedgewick in the April, 1998, Dr. Dobb's Journal.
 #include "H5FLprivate.h"	/* Free lists                           */
 #include "H5STprivate.h"        /* Ternary search trees                 */
 
+#ifdef H5ST_DEBUG
+static herr_t H5ST__dump_internal(H5ST_ptr_t p);
+#endif /* H5ST_DEBUG */
+
 /* Declare a free list to manage the H5ST_node_t struct */
 H5FL_DEFINE_STATIC(H5ST_node_t);
 
@@ -719,7 +723,7 @@ done:
 
 /*--------------------------------------------------------------------------
  NAME
-    H5ST_dump_internal
+    H5ST__dump_internal
  PURPOSE
     Dump all the nodes of a TST
  USAGE
@@ -735,30 +739,30 @@ done:
  EXAMPLES
  REVISION LOG
 --------------------------------------------------------------------------*/
-herr_t
-H5ST_dump_internal(H5ST_ptr_t p)
+static herr_t
+H5ST__dump_internal(H5ST_ptr_t p)
 {
-    FUNC_ENTER_NOAPI_NOINIT_NOERR
+    FUNC_ENTER_STATIC_NOERR
 
     if(p) {
-        printf("p=%p\n", p);
-        printf("\tp->up=%p\n", p->up);
-        printf("\tp->parent=%p\n", p->parent);
-        printf("\tp->lokid=%p\n", p->lokid);
-        printf("\tp->hikid=%p\n", p->hikid);
-        printf("\tp->eqkid=%p\n", p->eqkid);
+        printf("p=%p\n", (void *)p);
+        printf("\tp->up=%p\n", (void *)p->up);
+        printf("\tp->parent=%p\n", (void *)p->parent);
+        printf("\tp->lokid=%p\n", (void *)p->lokid);
+        printf("\tp->hikid=%p\n", (void *)p->hikid);
+        printf("\tp->eqkid=%p\n", (void *)p->eqkid);
         printf("\tp->splitchar=%c\n", p->splitchar);
 
-        H5ST_dump_internal(p->lokid);
+        H5ST__dump_internal(p->lokid);
         if(p->splitchar)
-            H5ST_dump_internal(p->eqkid);
+            H5ST__dump_internal(p->eqkid);
         else
             printf("%s\n", (char *)p->eqkid);
-        H5ST_dump_internal(p->hikid);
+        H5ST__dump_internal(p->hikid);
     } /* end if */
 
     FUNC_LEAVE_NOAPI(SUCCEED)
-} /* end H5ST_dump_internal() */
+} /* end H5ST__dump_internal() */
 
 
 /*--------------------------------------------------------------------------
@@ -785,7 +789,7 @@ H5ST_dump(H5ST_tree_t *tree)
     FUNC_ENTER_NOAPI_NOINIT_NOERR
 
     /* Dump the tree */
-    H5ST_dump_internal(tree->root);
+    H5ST__dump_internal(tree->root);
 
     FUNC_LEAVE_NOAPI(SUCCEED)
 } /* end H5ST_dump() */