summaryrefslogtreecommitdiffstats
path: root/src/H5Smpio.c
diff options
context:
space:
mode:
authorAlbert Cheng <acheng@hdfgroup.org>2000-09-06 03:40:21 (GMT)
committerAlbert Cheng <acheng@hdfgroup.org>2000-09-06 03:40:21 (GMT)
commit404ee60bd41e53144b5f405507ae1a319a0ae8af (patch)
tree1b524303f03af2027748a67de6668bbaa9b60369 /src/H5Smpio.c
parentb8f8c8cb90826fc79fca22c0ae33bf1b1940eec3 (diff)
downloadhdf5-404ee60bd41e53144b5f405507ae1a319a0ae8af.zip
hdf5-404ee60bd41e53144b5f405507ae1a319a0ae8af.tar.gz
hdf5-404ee60bd41e53144b5f405507ae1a319a0ae8af.tar.bz2
[svn-r2508] Purpose:
Bug fixes Description: All tests were core=dumping in IRIX64. The bug is in Generic property list creation in which malloc asked for 2*64-1 bytes due to coding bug. The object creation failed but the return code was not checked. Program eventually crashed. Solution: H5F.c: Check the return code from new file object creation and flag error accordingly. H5FL.c: H5FL_arr_free is a replacement for H5MM_xfree which accepts null value as a legal argument value. H5FL_arr_free assert on it. Since other parts of the code have been passing null value to H5MM_xfree, H5FL_arr_free must accept it too until all the calling routines are changed to not pass Null. H5P.c: some routine passes in 0 as the hashsize value which is uintn. The expression (hashsize-1) underflows to the largest unsigned int for some machines. Thus the calloc failed. Cast hashsize to unsigned int first (this assumes hashsize stays within the signed int data range. H5Smpio.c: Added the extra parameter because the H5FD_write has been redefined. Platforms tested: IRIX64 -64 and -n32
Diffstat (limited to 'src/H5Smpio.c')
-rw-r--r--src/H5Smpio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/H5Smpio.c b/src/H5Smpio.c
index 185bcdc..87ecd30 100644
--- a/src/H5Smpio.c
+++ b/src/H5Smpio.c
@@ -594,7 +594,7 @@ H5S_mpio_spaces_xfer(H5F_t *f, const struct H5O_layout_t *layout,
"transfer size overflows size_t");
}
if (do_write) {
- err = H5FD_write(f->shared->lf, dxpl_id, addr, mpi_count, buf);
+ err = H5FD_write(f->shared->lf, H5FD_MEM_DRAW, dxpl_id, addr, mpi_count, buf);
if (err) {
HRETURN_ERROR(H5E_IO, H5E_WRITEERROR, FAIL,"MPI write failed");
}