summaryrefslogtreecommitdiffstats
path: root/src/H5Smpio.c
diff options
context:
space:
mode:
authorRichard Warren <Richard.Warren@hdfgroup.org>2019-10-07 12:56:05 (GMT)
committerRichard Warren <Richard.Warren@hdfgroup.org>2019-10-07 12:56:05 (GMT)
commita074eeda117072a82300c9b937f086e23def9243 (patch)
tree780e856e1486e72e3407f5081cf2d76ec4f3f00c /src/H5Smpio.c
parentfa2882c0b3d27246760017ad3ebc9813cc17a066 (diff)
downloadhdf5-a074eeda117072a82300c9b937f086e23def9243.zip
hdf5-a074eeda117072a82300c9b937f086e23def9243.tar.gz
hdf5-a074eeda117072a82300c9b937f086e23def9243.tar.bz2
Made code review edit suggested by Jerome, plus various code updates to files that I touched to eliminate compile warnings (on my Linux box).
Diffstat (limited to 'src/H5Smpio.c')
-rw-r--r--src/H5Smpio.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/H5Smpio.c b/src/H5Smpio.c
index 287bde1..906aea8 100644
--- a/src/H5Smpio.c
+++ b/src/H5Smpio.c
@@ -45,7 +45,7 @@
#define H5S_MPIO_INITIAL_ALLOC_COUNT 256
#define TWO_GIG_LIMIT 2147483648
#ifndef H5S_MAX_MPI_COUNT
-#define H5S_MAX_MPI_COUNT 1073741824
+#define H5S_MAX_MPI_COUNT (1 << 30)
#endif
@@ -1124,7 +1124,7 @@ H5S__obtain_datatype(H5S_hyper_span_info_t *spans, const hsize_t *down,
{
H5S_hyper_span_t *span; /* Hyperslab span to iterate with */
size_t alloc_count = 0; /* Number of span tree nodes allocated at this level */
- size_t outercount; /* Number of span tree nodes at this level */
+ size_t outercount = 0; /* Number of span tree nodes at this level */
MPI_Datatype *inner_type = NULL;
hbool_t inner_types_freed = FALSE; /* Whether the inner_type MPI datatypes have been freed */
int *blocklen = NULL;
@@ -1184,7 +1184,7 @@ H5S__obtain_datatype(H5S_hyper_span_info_t *spans, const hsize_t *down,
H5_CHECK_OVERFLOW(nelmts, hsize_t, int)
blocklen[outercount] = (int)nelmts;
- if(bigio_count < blocklen[outercount])
+ if(bigio_count < (hsize_t)blocklen[outercount])
large_block = TRUE; /* at least one block type is large, so set this flag to true */
span = span->next;
@@ -1201,7 +1201,7 @@ H5S__obtain_datatype(H5S_hyper_span_info_t *spans, const hsize_t *down,
MPI_Datatype temp_type = MPI_DATATYPE_NULL;
/* create the block type from elmt_type while checking the 32 bit int limit */
- if(blocklen[u] > bigio_count) {
+ if((hsize_t)(blocklen[u]) > bigio_count) {
if(H5S_mpio_create_large_type(blocklen[u], 0, *elmt_type, &temp_type) < 0)
HGOTO_ERROR(H5E_DATASPACE, H5E_BADTYPE, FAIL, "couldn't create a large element datatype in span_hyper selection")
} /* end if */