Much normalization with develop (#701)

* Brings CMake updates from develop

* Brings reduction in pedantic casts from develop

* Purges UFAIL from the library (#637)

* Committing clang-format changes

* Purges UFAIL from the library

* H5HL_insert change requested in PR

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Removes gratuitous (double)x.yF casts (#632)

* Committing clang-format changes

* Removes gratuitous (double)x.yF casts

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Committing clang-format changes

* Cleans up a const warning left over from previous constification (#633)

* Committing clang-format changes

* Adds consts to a few global variables

* Cleans up a const warning left over from previous constification

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Formatted source

* Bring over some VOL registration changes

* VOL cleanup

* H5VL_request_status_t substitutions

* H5F.c cleanup

* Minor API tweaks from develop

* Moves H5G package init/teardown to H5Gint.c

* H5G cleanup

* H5M cleanup

* H5SM cleanup

* H5T cleanup

* H5R cleanup

* H5Lpublic.h cleanup

* H5L cleanup

* H5O cleanup

* H5A, H5CS, and H5AC cleanup

* Moved H5A init/teardown code to H5Aint.c

* Moves H5D I/O functions to H5D.c

* H5D cleanup

* Misc minor cleanup

* H5P close cleanup

* H5Tpublic.h cleanup

* Fixes err_compat test

* H5PLpublic.h cleanup

* Updates H5Ppublic.h

* H5Fpublic.h updates

* H5A.c cleanup

* Brings over H5Aexists and related changes

* Brings CMake shell testing changes from develop

* Close callback changes

* H5R and H5Tcommit normalization

* err_compat test works now

* H5O tweaks

* Updates VOL registration code

* Brings over H5VL_create_object

* H5Tconv.c reformatting

* H5T.c tweaks

* Brings datatype and reference updates from develop

* Brings VOL plugin loading changes from develop

* Brings event sets from develop

* Brings async functions over

* Tools changes

* Brings over many tools changes from develop

* Brings VOL flags from develop

* Fixes h5dump double/float tests

* Updates h5repack tests

* Brings h5diff test changes from develop

* Last h5dump changes

* Brings test changes from develop

* Committing clang-format changes

* Tidied h5_testing()

* Brings chunk iteration code + misc from develop

* Updates vds test

* Enables external link parallel test

* Brings updated property lists from develop

* H5G changes from develop

* H5MF cleanup

* Brings vfd_swmr test back into CMake

* Updates threadsafe test

* Updates plist test

* Brings recent changes from develop

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

1 files changed, 23 insertions, 22 deletions

diff --git a/src/H5VLnative_link.c b/src/H5VLnative_link.c
index 4128ac0..72f6cde 100644
--- a/src/H5VLnative_link.c
+++ b/src/H5VLnative_link.c
@@ -73,8 +73,9 @@ H5VL__native_link_create(H5VL_link_create_type_t create_type, void *obj, const H
                                 "source and destination should be in the same file.")
 
                 /* Create the link */
-                if ((ret_value = H5L_create_hard(cur_loc_p, cur_params->loc_data.loc_by_name.name, link_loc_p,
-                                                 loc_params->loc_data.loc_by_name.name, lcpl_id)) < 0)
+                if ((ret_value =
+                         H5L__create_hard(cur_loc_p, cur_params->loc_data.loc_by_name.name, link_loc_p,
+                                          loc_params->loc_data.loc_by_name.name, lcpl_id)) < 0)
                     HGOTO_ERROR(H5E_LINK, H5E_CANTINIT, FAIL, "unable to create link")
             }      /* end if */
             else { /* H5Olink */
@@ -93,8 +94,8 @@ H5VL__native_link_create(H5VL_link_create_type_t create_type, void *obj, const H
                 HGOTO_ERROR(H5E_ARGS, H5E_BADTYPE, FAIL, "not a file or file object")
 
             /* Create the link */
-            if ((ret_value = H5L_create_soft(target_name, &link_loc, loc_params->loc_data.loc_by_name.name,
-                                             lcpl_id)) < 0)
+            if ((ret_value = H5L__create_soft(target_name, &link_loc, loc_params->loc_data.loc_by_name.name,
+                                              lcpl_id)) < 0)
                 HGOTO_ERROR(H5E_LINK, H5E_CANTINIT, FAIL, "unable to create link")
             break;
         }
@@ -157,8 +158,8 @@ H5VL__native_link_copy(void *src_obj, const H5VL_loc_params_t *loc_params1, void
         dst_loc_p = src_loc_p;
 
     /* Copy the link */
-    if (H5L_move(src_loc_p, loc_params1->loc_data.loc_by_name.name, dst_loc_p,
-                 loc_params2->loc_data.loc_by_name.name, TRUE, lcpl_id) < 0)
+    if (H5L__move(src_loc_p, loc_params1->loc_data.loc_by_name.name, dst_loc_p,
+                  loc_params2->loc_data.loc_by_name.name, TRUE, lcpl_id) < 0)
         HGOTO_ERROR(H5E_LINK, H5E_CANTCOPY, FAIL, "unable to copy link")
 
 done:
@@ -199,8 +200,8 @@ H5VL__native_link_move(void *src_obj, const H5VL_loc_params_t *loc_params1, void
         dst_loc_p = src_loc_p;
 
     /* Move the link */
-    if (H5L_move(src_loc_p, loc_params1->loc_data.loc_by_name.name, dst_loc_p,
-                 loc_params2->loc_data.loc_by_name.name, FALSE, lcpl_id) < 0)
+    if (H5L__move(src_loc_p, loc_params1->loc_data.loc_by_name.name, dst_loc_p,
+                  loc_params2->loc_data.loc_by_name.name, FALSE, lcpl_id) < 0)
         HGOTO_ERROR(H5E_LINK, H5E_CANTMOVE, FAIL, "unable to move link")
 
 done:
@@ -239,7 +240,7 @@ H5VL__native_link_get(void *obj, const H5VL_loc_params_t *loc_params, H5VL_link_
                     HGOTO_ERROR(H5E_LINK, H5E_NOTFOUND, FAIL, "unable to get link info")
             }                                                  /* end if */
             else if (loc_params->type == H5VL_OBJECT_BY_IDX) { /* H5Lget_info_by_idx */
-                if (H5L_get_info_by_idx(
+                if (H5L__get_info_by_idx(
                         &loc, loc_params->loc_data.loc_by_idx.name, loc_params->loc_data.loc_by_idx.idx_type,
                         loc_params->loc_data.loc_by_idx.order, loc_params->loc_data.loc_by_idx.n, linfo2) < 0)
                     HGOTO_ERROR(H5E_LINK, H5E_NOTFOUND, FAIL, "unable to get link info")
@@ -257,10 +258,10 @@ H5VL__native_link_get(void *obj, const H5VL_loc_params_t *loc_params, H5VL_link_
             ssize_t *ret  = HDva_arg(arguments, ssize_t *);
 
             /* Get the link name */
-            if ((*ret = H5L_get_name_by_idx(&loc, loc_params->loc_data.loc_by_idx.name,
-                                            loc_params->loc_data.loc_by_idx.idx_type,
-                                            loc_params->loc_data.loc_by_idx.order,
-                                            loc_params->loc_data.loc_by_idx.n, name, size)) < 0)
+            if ((*ret = H5L__get_name_by_idx(&loc, loc_params->loc_data.loc_by_idx.name,
+                                             loc_params->loc_data.loc_by_idx.idx_type,
+                                             loc_params->loc_data.loc_by_idx.order,
+                                             loc_params->loc_data.loc_by_idx.n, name, size)) < 0)
                 HGOTO_ERROR(H5E_LINK, H5E_NOTFOUND, FAIL, "unable to get link info")
 
             break;
@@ -273,15 +274,15 @@ H5VL__native_link_get(void *obj, const H5VL_loc_params_t *loc_params, H5VL_link_
 
             /* Get the link information */
             if (loc_params->type == H5VL_OBJECT_BY_NAME) { /* H5Lget_val */
-                if (H5L_get_val(&loc, loc_params->loc_data.loc_by_name.name, buf, size) < 0)
+                if (H5L__get_val(&loc, loc_params->loc_data.loc_by_name.name, buf, size) < 0)
                     HGOTO_ERROR(H5E_LINK, H5E_NOTFOUND, FAIL, "unable to get link value")
             }
             else if (loc_params->type == H5VL_OBJECT_BY_IDX) { /* H5Lget_val_by_idx */
 
-                if (H5L_get_val_by_idx(&loc, loc_params->loc_data.loc_by_idx.name,
-                                       loc_params->loc_data.loc_by_idx.idx_type,
-                                       loc_params->loc_data.loc_by_idx.order,
-                                       loc_params->loc_data.loc_by_idx.n, buf, size) < 0)
+                if (H5L__get_val_by_idx(&loc, loc_params->loc_data.loc_by_idx.name,
+                                        loc_params->loc_data.loc_by_idx.idx_type,
+                                        loc_params->loc_data.loc_by_idx.order,
+                                        loc_params->loc_data.loc_by_idx.n, buf, size) < 0)
                     HGOTO_ERROR(H5E_LINK, H5E_NOTFOUND, FAIL, "unable to get link val")
             }
             else
@@ -317,14 +318,14 @@ H5VL__native_link_specific(void *obj, const H5VL_loc_params_t *loc_params, H5VL_
 
     switch (specific_type) {
         case H5VL_LINK_EXISTS: {
-            htri_t *  ret = HDva_arg(arguments, htri_t *);
+            hbool_t * exists = HDva_arg(arguments, hbool_t *);
             H5G_loc_t loc;
 
             if (H5G_loc_real(obj, loc_params->obj_type, &loc) < 0)
                 HGOTO_ERROR(H5E_ARGS, H5E_BADTYPE, FAIL, "not a file or file object")
 
             /* Check for the existence of the link */
-            if ((*ret = H5L_exists(&loc, loc_params->loc_data.loc_by_name.name)) < 0)
+            if (H5L__exists(&loc, loc_params->loc_data.loc_by_name.name, exists) < 0)
                 HGOTO_ERROR(H5E_LINK, H5E_NOTFOUND, FAIL, "unable to specific link info")
             break;
         }
@@ -383,11 +384,11 @@ H5VL__native_link_specific(void *obj, const H5VL_loc_params_t *loc_params, H5VL_
 
             /* Unlink */
             if (loc_params->type == H5VL_OBJECT_BY_NAME) { /* H5Ldelete */
-                if (H5L_delete(&loc, loc_params->loc_data.loc_by_name.name) < 0)
+                if (H5L__delete(&loc, loc_params->loc_data.loc_by_name.name) < 0)
                     HGOTO_ERROR(H5E_LINK, H5E_CANTDELETE, FAIL, "unable to delete link")
             }                                                  /* end if */
             else if (loc_params->type == H5VL_OBJECT_BY_IDX) { /* H5Ldelete_by_idx */
-                if (H5L_delete_by_idx(
+                if (H5L__delete_by_idx(
                         &loc, loc_params->loc_data.loc_by_idx.name, loc_params->loc_data.loc_by_idx.idx_type,
                         loc_params->loc_data.loc_by_idx.order, loc_params->loc_data.loc_by_idx.n) < 0)
                     HGOTO_ERROR(H5E_LINK, H5E_CANTDELETE, FAIL, "unable to delete link")