Merge branch 'develop' into feature/coding_standardsfeature/coding_standards

1 files changed, 66 insertions, 129 deletions

diff --git a/src/H5win32defs.h b/src/H5win32defs.h
index 29533dd..44cf50c 100644
--- a/src/H5win32defs.h
+++ b/src/H5win32defs.h
@@ -6,165 +6,102 @@
  * This file is part of HDF5.  The full HDF5 copyright notice, including     *
  * terms governing use, modification, and redistribution, is contained in    *
  * the COPYING file, which can be found at the root of the source code       *
- * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases.  *
+ * distribution tree, or in https://www.hdfgroup.org/licenses.               *
  * If you do not have access to either file, you may request a copy from     *
  * help@hdfgroup.org.                                                        *
  * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
 
-/* Programmer:  Scott Wegner
- *              June 3, 2008
- *
- * Purpose: This file is used to map HDF macros to Windows functions.  This
+/* Purpose: This file is used to map HDF macros to Windows functions.  This
  *          should get included H5private mappings, so as to override them.
  *          Any macro not mapped here, however, will receive a similar mapping
  *          inside H5private.h
  *
  */
 
-/*
- * _MSC_VER = 1900 VS2015
- * _MSC_VER = 1800 VS2013
- * _MSC_VER = 1700 VS2012
+/* _MSC_VER = 192x  VS2019
+ * _MSC_VER = 191x  VS2017
+ * _MSC_VER = 1900  VS2015
+ * _MSC_VER = 1800  VS2013
+ * _MSC_VER = 1700  VS2012
  */
 #ifdef H5_HAVE_WIN32_API
 
-typedef struct _stati64     h5_stat_t;
-typedef __int64             h5_stat_size_t;
-
-#define HDaccess(F,M)       _access(F,M)
-#define HDchdir(S)          _chdir(S)
-#define HDclose(F)          _close(F)
-#define HDcreat(S,M)        Wopen_utf8(S,O_CREAT|O_TRUNC|O_RDWR,M)
-#define HDdup(F)            _dup(F)
-#define HDfdopen(N,S)       _fdopen(N,S)
-#define HDfileno(F)         _fileno(F)
-#define HDfstat(F,B)        _fstati64(F,B)
-#define HDisatty(F)         _isatty(F)
-#define HDgetcwd(S,Z)       _getcwd(S,Z)
-#define HDgetdcwd(D,S,Z)    _getdcwd(D,S,Z)
-#define HDgetdrive()        _getdrive()
-#define HDlseek(F,O,W)      _lseeki64(F,O,W)
-#define HDlstat(S,B)        _lstati64(S,B)
-#define HDmkdir(S,M)        _mkdir(S)
-#define HDnanosleep(N, O)   Wnanosleep(N, O)
-#define HDoff_t             __int64
-
-/* Note that the variadic HDopen macro is using a VC++ extension
- * where the comma is dropped if nothing is passed to the ellipsis.
- */
-#ifndef H5_HAVE_MINGW
-#define HDopen(S,F,...)     Wopen_utf8(S,F,__VA_ARGS__)
-#else
-#define HDopen(S,F,...)     Wopen_utf8(S,F,##__VA_ARGS__)
-#endif
-#define HDread(F,M,Z)       _read(F,M,Z)
-#define HDremove(S)         Wremove_utf8(S)
-#define HDrmdir(S)          _rmdir(S)
-#define HDsetvbuf(F,S,M,Z)  setvbuf(F,S,M,(Z>1?Z:2))
-#define HDsleep(S)          Sleep(S*1000)
-#define HDstat(S,B)         _stati64(S,B)
-#define HDstrcasecmp(A,B)   _stricmp(A,B)
-#define HDstrdup(S)         _strdup(S)
-#define HDstrtok_r(X,Y,Z)   strtok_s(X,Y,Z)
-#define HDtzset()           _tzset()
-#define HDunlink(S)         _unlink(S)
-#define HDwrite(F,M,Z)      _write(F,M,Z)
+typedef struct _stati64 h5_stat_t;
+typedef __int64         h5_stat_size_t;
 
 #ifdef H5_HAVE_VISUAL_STUDIO
 
-#if (_MSC_VER < 1800)
-  #ifndef H5_HAVE_STRTOLL
-    #define HDstrtoll(S,R,N)    _strtoi64(S,R,N)
-  #endif /* H5_HAVE_STRTOLL */
-  #ifndef H5_HAVE_STRTOULL
-    #define HDstrtoull(S,R,N)   _strtoui64(S,R,N)
-  #endif /* H5_HAVE_STRTOULL */
-  /* va_copy() does not exist on pre-2013 Visual Studio. Since va_lists are
-   * just pointers into the stack in those CRTs, the usual work-around
-   * is to just define the operation as a pointer copy.
-   */
-  #define HDva_copy(D,S)      ((D) = (S))
-#endif /* MSC_VER < 1800 */
-
-/*
- * The (void*) cast just avoids a compiler warning in H5_HAVE_VISUAL_STUDIO
- */
-#define HDmemset(X,C,Z)     memset((void*)(X),C,Z)
-
 struct timezone {
     int tz_minuteswest;
     int tz_dsttime;
 };
 
-/* time.h before VS2015 does not include timespec */
-#if (_MSC_VER < 1900)
-struct timespec
-{
-    time_t tv_sec;  /* Seconds - >= 0 */
-    long   tv_nsec; /* Nanoseconds - [0, 999999999] */
-};
-#endif /* MSC_VER < 1900 */
+#endif /* H5_HAVE_VISUAL_STUDIO */
 
-/* The round functions do not exist in VS2012 and earlier */
-#if (_MSC_VER <= 1700)
-#define HDllround(V)        Wllround(V)
-#define HDllroundf(V)       Wllroundf(V)
-#define HDlround(V)         Wlround(V)
-#define HDlroundf(V)        Wlroundf(V)
-#define HDround(V)          Wround(V)
-#define HDroundf(V)         Wroundf(V)
-#endif /* MSC_VER < 1700 */
+#define HDaccess(F, M)       _access(F, M)
+#define HDchdir(S)           _chdir(S)
+#define HDclose(F)           _close(F)
+#define HDcreat(S, M)        Wopen_utf8(S, O_CREAT | O_TRUNC | O_RDWR, M)
+#define HDdup(F)             _dup(F)
+#define HDfdopen(N, S)       _fdopen(N, S)
+#define HDfileno(F)          _fileno(F)
+#define HDflock(F, L)        Wflock(F, L)
+#define HDfstat(F, B)        _fstati64(F, B)
+#define HDgetcwd(S, Z)       _getcwd(S, Z)
+#define HDgetdcwd(D, S, Z)   _getdcwd(D, S, Z)
+#define HDgetdrive()         _getdrive()
+#define HDgetlogin()         Wgetlogin()
+#define HDgettimeofday(V, Z) Wgettimeofday(V, Z)
+#define HDisatty(F)          _isatty(F)
+#define HDlseek(F, O, W)     _lseeki64(F, O, W)
+#define HDlstat(S, B)        _lstati64(S, B)
+#define HDmemset(X, C, Z)    memset((void *)(X), C, Z) /* Cast avoids MSVC warning */
+#define HDmkdir(S, M)        _mkdir(S)
+#define HDoff_t              __int64
 
-#endif /* H5_HAVE_VISUAL_STUDIO */
+/* Note that the variadic HDopen macro is using a VC++ extension
+ * where the comma is dropped if nothing is passed to the ellipsis.
+ */
+#ifndef H5_HAVE_MINGW
+#define HDopen(S, F, ...) Wopen_utf8(S, F, __VA_ARGS__)
+#else
+#define HDopen(S, F, ...) Wopen_utf8(S, F, ##__VA_ARGS__)
+#endif
+
+#define HDread(F, M, Z)       _read(F, M, Z)
+#define HDremove(S)           Wremove_utf8(S)
+#define HDrmdir(S)            _rmdir(S)
+#define HDsetenv(N, V, O)     Wsetenv(N, V, O)
+#define HDsetvbuf(F, S, M, Z) setvbuf(F, S, M, (Z > 1 ? Z : 2))
+#define HDsleep(S)            Sleep(S * 1000)
+#define HDstat(S, B)          _stati64(S, B)
+#define HDstrcasecmp(A, B)    _stricmp(A, B)
+#define HDstrdup(S)           _strdup(S)
+#define HDstrtok_r(X, Y, Z)   strtok_s(X, Y, Z)
+#define HDtzset()             _tzset()
+#define HDunlink(S)           _unlink(S)
+#define HDunsetenv(N)         Wsetenv(N, "", 1)
+#define HDwrite(F, M, Z)      _write(F, M, Z)
 
+#ifndef H5_HAVE_MINGW
+#define HDftruncate(F, L) _chsize_s(F, L)
+#define HDfseek(F, O, W)  _fseeki64(F, O, W)
+#endif /* H5_HAVE_MINGW */
 
 #ifdef __cplusplus
 extern "C" {
 #endif /* __cplusplus */
-    H5_DLL int Wgettimeofday(struct timeval *tv, struct timezone *tz);
-    H5_DLL int Wsetenv(const char *name, const char *value, int overwrite);
-    H5_DLL int Wflock(int fd, int operation);
-    H5_DLL char* Wgetlogin(void);
-    H5_DLL int c99_snprintf(char* str, size_t size, const char* format, ...);
-    H5_DLL int c99_vsnprintf(char* str, size_t size, const char* format, va_list ap);
-    H5_DLL int Wnanosleep(const struct timespec *req, struct timespec *rem);
-    H5_DLL herr_t H5_expand_windows_env_vars(char **env_var);
-    H5_DLL const wchar_t *H5_get_utf16_str(const char *s);
-    H5_DLL int Wopen_utf8(const char *path, int oflag, ...);
-    H5_DLL int Wremove_utf8(const char *path);
-
-    /* Round functions only needed for VS2012 and earlier.
-     * They are always built to ensure they don't go stale and
-     * can be deleted (along with their #defines, above) when we
-     * drop VS2012 support.
-     */
-    H5_DLL long long Wllround(double arg);
-    H5_DLL long long Wllroundf(float arg);
-    H5_DLL long Wlround(double arg);
-    H5_DLL long Wlroundf(float arg);
-    H5_DLL double Wround(double arg);
-    H5_DLL float Wroundf(float arg);
+H5_DLL int    Wgettimeofday(struct timeval *tv, struct timezone *tz);
+H5_DLL int    Wsetenv(const char *name, const char *value, int overwrite);
+H5_DLL int    Wflock(int fd, int operation);
+H5_DLL char * Wgetlogin(void);
+H5_DLL herr_t H5_expand_windows_env_vars(char **env_var);
+H5_DLL wchar_t *H5_get_utf16_str(const char *s);
+H5_DLL int      Wopen_utf8(const char *path, int oflag, ...);
+H5_DLL int      Wremove_utf8(const char *path);
+H5_DLL int      H5_get_win32_times(H5_timevals_t *tvs);
 #ifdef __cplusplus
 }
 #endif /* __cplusplus */
 
-#define HDgettimeofday(V,Z) Wgettimeofday(V,Z)
-#define HDsetenv(N,V,O)     Wsetenv(N,V,O)
-#define HDflock(F,L)        Wflock(F,L)
-#define HDgetlogin()        Wgetlogin()
-#define HDsnprintf          c99_snprintf /*varargs*/
-#define HDvsnprintf         c99_vsnprintf /*varargs*/
-
-/* Non-POSIX functions */
-
-/* Don't use actual pthread_self on Windows because the return
- * type cannot be cast as a ulong like other systems. */
-#define HDpthread_self_ulong() ((unsigned long)GetCurrentThreadId())
-
-#ifndef H5_HAVE_MINGW
-#define HDftruncate(F,L)    _chsize_s(F,L)
-#define HDfseek(F,O,W)      _fseeki64(F,O,W)
-#endif /* H5_HAVE_MINGW */
-
 #endif /* H5_HAVE_WIN32_API */
-