Fix H5DS warnings related to new H5DSwith_new_ref and H5VLobject_is_native APIs (#1184)

2 files changed, 15 insertions, 11 deletions

diff --git a/src/H5VL.c b/src/H5VL.c
index c92d01d..8c3277c 100644
--- a/src/H5VL.c
+++ b/src/H5VL.c
@@ -661,25 +661,27 @@ done:
  * Purpose:     Determines whether an object ID represents a native VOL
  *              connector object.
  *
- * Return:      Success:    TRUE/FALSE
- *              Failure:    FAIL
+ * Return:      Non-negative on success/Negative on failure
  *
  *---------------------------------------------------------------------------
  */
-hbool_t
-H5VLobject_is_native(hid_t obj_id)
+herr_t
+H5VLobject_is_native(hid_t obj_id, hbool_t *is_native)
 {
     H5VL_object_t *vol_obj   = NULL;
-    hbool_t        ret_value = FALSE;
+    herr_t         ret_value = SUCCEED;
+
+    FUNC_ENTER_API(FAIL)
+    H5TRACE2("e", "i*b", obj_id, is_native);
 
-    FUNC_ENTER_API(FALSE)
-    H5TRACE1("b", "i", obj_id);
+    if (!is_native)
+        HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, FAIL, "`is_native` argument is NULL")
 
     /* Get the location object for the ID */
     if (NULL == (vol_obj = H5VL_vol_object(obj_id)))
         HGOTO_ERROR(H5E_ARGS, H5E_BADTYPE, FAIL, "invalid object identifier")
 
-    if (H5VL_object_is_native(vol_obj, &ret_value) < 0)
+    if (H5VL_object_is_native(vol_obj, is_native) < 0)
         HGOTO_ERROR(H5E_VOL, H5E_CANTGET, FAIL, "can't determine if object is a native connector object")
 
 done:
diff --git a/src/H5VLpublic.h b/src/H5VLpublic.h
index ac68cc4..543c3c8 100644
--- a/src/H5VLpublic.h
+++ b/src/H5VLpublic.h
@@ -362,11 +362,13 @@ H5_DLL herr_t H5VLquery_optional(hid_t obj_id, H5VL_subclass_t subcls, int opt_t
  *        VOL connector object.
  *
  * \param[in] obj_id Object identifier
- * \return \hbool_t
+ * \param[in] is_native Boolean determining whether object is a native
+ *            VOL connector object
+ * \return \herr_t
  *
- * \since 1.12.1
+ * \since 1.13.0
  */
-H5_DLL hbool_t H5VLobject_is_native(hid_t obj_id);
+H5_DLL herr_t H5VLobject_is_native(hid_t obj_id, hbool_t *is_native);
 
 #ifdef __cplusplus
 }