diff options
| author | vchoi <vchoi@jelly.ad.hdfgroup.org> | 2021-12-07 00:52:04 (GMT) |
|---|---|---|
| committer | vchoi <vchoi@jelly.ad.hdfgroup.org> | 2021-12-07 00:52:04 (GMT) |
| commit | 7253d772b8205a03232411bd58bcd5c331e6f19a (patch) | |
| tree | 480eecc23a126036e063ff128977e392d3b47ad1 /src | |
| parent | 68ddc3029a1e55cb1f995c0b69233c7c06ff94da (diff) | |
| download | hdf5-7253d772b8205a03232411bd58bcd5c331e6f19a.zip hdf5-7253d772b8205a03232411bd58bcd5c331e6f19a.tar.gz hdf5-7253d772b8205a03232411bd58bcd5c331e6f19a.tar.bz2 | |
Changes to address feedback from PR review.
Diffstat (limited to 'src')
| -rw-r--r-- | src/H5Fint.c | 10 | ||||
| -rw-r--r-- | src/H5Fprivate.h | 6 |
2 files changed, 9 insertions, 7 deletions
diff --git a/src/H5Fint.c b/src/H5Fint.c index 3dae17e..f0d03e4 100644 --- a/src/H5Fint.c +++ b/src/H5Fint.c @@ -1850,11 +1850,13 @@ H5F_open(const char *name, unsigned flags, hid_t fcpl_id, hid_t fapl_id) hbool_t evict_on_close; /* Evict on close value from plist */ hbool_t use_file_locking = TRUE; /* Using file locks? */ hbool_t ci_load = FALSE; /* Whether MDC ci load requested */ - hbool_t ci_write = FALSE; /* Whether MDC CI write requested */ + hbool_t ci_write = FALSE; /* Whether MDC ci write requested */ hbool_t file_create = FALSE; /* Creating a new file or not */ H5F_vfd_swmr_config_t * vfd_swmr_config_ptr = NULL; /* Points to VFD SMWR config info */ - H5F_generate_md_ck_cb_t cb_info = {NULL}; - H5F_t * ret_value = NULL; /* Actual return value */ + H5F_generate_md_ck_cb_t cb_info = {NULL}; /* For VFD SWMR NFS testing: + initialize the callback to generate + checksums for metadata files */ + H5F_t * ret_value = NULL; /* Actual return value */ FUNC_ENTER_NOAPI(NULL) @@ -3772,7 +3774,7 @@ herr_t H5F__start_swmr_write(H5F_t *f) { hbool_t ci_load = FALSE; /* whether MDC ci load requested */ - hbool_t ci_write = FALSE; /* whether MDC CI write requested */ + hbool_t ci_write = FALSE; /* whether MDC ci write requested */ size_t grp_dset_count = 0; /* # of open objects: groups & datasets */ size_t nt_attr_count = 0; /* # of opened named datatypes + opened attributes */ hid_t * obj_ids = NULL; /* List of ids */ diff --git a/src/H5Fprivate.h b/src/H5Fprivate.h index 796242b..9a4f363 100644 --- a/src/H5Fprivate.h +++ b/src/H5Fprivate.h @@ -811,7 +811,7 @@ uint64_decode(uint8_t **pp) + 4 /* Page size */ \ + 8 /* Sequence number */ \ + 8 /* Tick number */ \ - + 8 /* Chnage list offset */ \ + + 8 /* Change list offset */ \ + 8 /* Change list length */ \ + H5F_SIZEOF_CHKSUM /* Updater file header checksum */ \ ) @@ -935,7 +935,7 @@ typedef enum H5F_prefix_open_t { * * An array of instances of H5F_vfd_swmr_updater_cl_entry_t of length equal to * the number of metadata pages and multi-page metadata entries modified in - * the past tick is used ot aseemble the assoicated data in preparation for + * the past tick is used to assemble the associated data in preparation for * writing an updater file. * * Each entry in this array pertains to a given modified metdata page or @@ -1062,7 +1062,7 @@ typedef struct H5F_vfd_swmr_updater_cl_entry_t { * array of H5F_vfd_swmr_updater_cl_ entry_t whose base address * is stored in the change_list field below. This value is also the * number of metadata pages and multi-page metadata entries that have - * been modified in the past tick + * been modified in the past tick. * * If this field is zero, there is no change list, and the change_list * field below is NULL. |