diff options
| author | Jacob Smith <jake.smith@hdfgroup.org> | 2020-02-07 19:49:29 (GMT) |
|---|---|---|
| committer | Jacob Smith <jake.smith@hdfgroup.org> | 2020-02-07 19:49:29 (GMT) |
| commit | c629dfa4f6b03dc527ccf4ae0e6c552bc025bbf2 (patch) | |
| tree | 8d1a670aa89173e922a7c96efc66d8b77e685554 /src | |
| parent | 3a098e06296fe5daf8b59cbf4287af27b4f225ce (diff) | |
| download | hdf5-c629dfa4f6b03dc527ccf4ae0e6c552bc025bbf2.zip hdf5-c629dfa4f6b03dc527ccf4ae0e6c552bc025bbf2.tar.gz hdf5-c629dfa4f6b03dc527ccf4ae0e6c552bc025bbf2.tar.bz2 | |
Fix improper S3 signing key null check (HDFFV-11015).
Diffstat (limited to 'src')
| -rw-r--r-- | src/H5FDs3comms.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/H5FDs3comms.c b/src/H5FDs3comms.c index c729821..4be52c4 100644 --- a/src/H5FDs3comms.c +++ b/src/H5FDs3comms.c @@ -1035,7 +1035,7 @@ H5FD_s3comms_s3r_open(const char *url, const char *region, const char *id, const if ((region != NULL && *region != '\0') || (id != NULL && *id != '\0') || - (signing_key != NULL && *signing_key != '\0')) { + (signing_key != NULL)) { /* if one exists, all three must exist */ if (region == NULL || region[0] == '\0') HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, NULL, "region cannot be null.\n"); @@ -1043,7 +1043,7 @@ H5FD_s3comms_s3r_open(const char *url, const char *region, const char *id, const if (id == NULL || id[0] == '\0') HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, NULL, "secret id cannot be null.\n"); - if (signing_key == NULL || signing_key[0] == '\0') + if (signing_key == NULL) HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, NULL, "signing key cannot be null.\n"); /* copy strings */ |