summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorJacob Smith <jake.smith@hdfgroup.org>2020-02-07 19:47:15 (GMT)
committerJacob Smith <jake.smith@hdfgroup.org>2020-02-07 19:47:15 (GMT)
commit6a93d1f834184853913d43e50fda5b350fa1dc38 (patch)
tree8c6637f8e4e75173dd382ba170e9e7a09ab5a69d /src
parent021740bac0893a87c762959b284283bc236d0ab3 (diff)
downloadhdf5-6a93d1f834184853913d43e50fda5b350fa1dc38.zip
hdf5-6a93d1f834184853913d43e50fda5b350fa1dc38.tar.gz
hdf5-6a93d1f834184853913d43e50fda5b350fa1dc38.tar.bz2
Fix improper S3 signing key null check (HDFFV-11015).
Diffstat (limited to 'src')
-rw-r--r--src/H5FDs3comms.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/H5FDs3comms.c b/src/H5FDs3comms.c
index f08e9d5..d9d4c88 100644
--- a/src/H5FDs3comms.c
+++ b/src/H5FDs3comms.c
@@ -1202,7 +1202,7 @@ H5FD_s3comms_s3r_open(const char *url,
if ((region != NULL && *region != '\0') ||
(id != NULL && *id != '\0') ||
- (signing_key != NULL && *signing_key != '\0'))
+ (signing_key != NULL))
{
/* if one exists, all three must exist
*/
@@ -1214,7 +1214,7 @@ H5FD_s3comms_s3r_open(const char *url,
HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, NULL,
"secret id cannot be null.\n");
}
- if (signing_key == NULL || signing_key[0] == '\0') {
+ if (signing_key == NULL) {
HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, NULL,
"signing key cannot be null.\n");
}