diff options
| author | Allen Byrne <50328838+byrnHDF@users.noreply.github.com> | 2023-06-13 16:33:35 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-13 16:33:35 (GMT) |
| commit | 4462f730585558532b38f14404333fdeb0033335 (patch) | |
| tree | 3a7e6613a57aab1acaeec5724da61f7aba15629b /src | |
| parent | d4605919f970e2f84d00d802f1b01db1b98fafc6 (diff) | |
| download | hdf5-4462f730585558532b38f14404333fdeb0033335.zip hdf5-4462f730585558532b38f14404333fdeb0033335.tar.gz hdf5-4462f730585558532b38f14404333fdeb0033335.tar.bz2 | |
clang-tidy clang-analyzer-core issues addressed (#3113)
src/H5system.c:1293:13: warning: Dereference of null pointer
[clang-analyzer-core.NullDereference]
src/H5trace.c:4048:17: warning: Passed-by-value struct argument contains
uninitialized data (e.g., via the field chain: 'initial.user')
[clang-analyzer-core.CallAndMessage]
Diffstat (limited to 'src')
| -rw-r--r-- | src/H5system.c | 2 | ||||
| -rw-r--r-- | src/H5trace.c | 6 |
2 files changed, 3 insertions, 5 deletions
diff --git a/src/H5system.c b/src/H5system.c index a13a5e8..e80b710 100644 --- a/src/H5system.c +++ b/src/H5system.c @@ -1290,7 +1290,7 @@ H5_get_option(int argc, const char *const *argv, const char *opts, const struct } } - if (l_opts[i].name == NULL) { + if (l_opts && l_opts[i].name == NULL) { /* exhausted all of the l_opts we have and still didn't match */ if (H5_opterr) HDfprintf(stderr, "%s: unknown option \"%s\"\n", argv[0], arg); diff --git a/src/H5trace.c b/src/H5trace.c index 2cf40d8..521bd30 100644 --- a/src/H5trace.c +++ b/src/H5trace.c @@ -281,8 +281,6 @@ H5_trace_args(H5RS_str_t *rs, const char *type, va_list ap) argname = HDva_arg(ap, char *); if (argname) H5RS_asprintf_cat(rs, "%s%s=", argno ? ", " : "", argname); - else - argname = ""; /* A pointer/array */ if (ptr) { @@ -3984,8 +3982,8 @@ H5_trace(const double *returning, const char *func, const char *type, ...) hssize_t i; FILE *out = H5_debug_g.trace; static hbool_t is_first_invocation = TRUE; - H5_timer_t function_timer; - H5_timevals_t function_times = {0.0, 0.0, 0.0}; + H5_timer_t function_timer = {{0.0, 0.0, 0.0}, {0.0, 0.0, 0.0}, {0.0, 0.0, 0.0}, FALSE}; + H5_timevals_t function_times = {0.0, 0.0, 0.0}; static H5_timer_t running_timer; H5_timevals_t running_times; static int current_depth = 0; |