summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorvchoi-hdfgroup <55293060+vchoi-hdfgroup@users.noreply.github.com>2023-04-14 20:41:41 (GMT)
committerGitHub <noreply@github.com>2023-04-14 20:41:41 (GMT)
commit2b528cc651ee609bb4bc9a0c04615d7dfc47ce65 (patch)
treec875660ee04fc61b13e7d93ccd5f320ef59bfb61 /src
parentfcb247afd39499983c5d8e4a32c1bafe8a2e2af5 (diff)
downloadhdf5-2b528cc651ee609bb4bc9a0c04615d7dfc47ce65.zip
hdf5-2b528cc651ee609bb4bc9a0c04615d7dfc47ce65.tar.gz
hdf5-2b528cc651ee609bb4bc9a0c04615d7dfc47ce65.tar.bz2
Fix for github issue #2599: (#2665) (#2735)
As indicated in the description, memory leak is detected when running "./h5dump pov". The problem is: when calling H5O__add_cont_msg() from H5O__chunk_deserialize(), memory is allocated for cont_msg_info->msgs. Eventually, when the library tries to load the continuation message via H5AC_protect() in H5O_protect(), error is encountered due to illegal info in the continuation message. Due to the error, H5O_protect() exits but the memory allocated for cont_msg_info->msgs is not freed. When we figure out how to handle fuzzed files that we didn't generate, a test needs to be added to run h5dump with the provided "pov" file.
Diffstat (limited to 'src')
-rw-r--r--src/H5Oint.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/H5Oint.c b/src/H5Oint.c
index 48f25c9..16a5028 100644
--- a/src/H5Oint.c
+++ b/src/H5Oint.c
@@ -1169,9 +1169,14 @@ H5O_protect(const H5O_loc_t *loc, unsigned prot_flags, hbool_t pin_all_chunks)
ret_value = oh;
done:
- if (ret_value == NULL && oh)
+ if (ret_value == NULL && oh) {
+ /* Release any continuation messages built up */
+ if (cont_msg_info.msgs)
+ cont_msg_info.msgs = (H5O_cont_t *)H5FL_SEQ_FREE(H5O_cont_t, cont_msg_info.msgs);
+
if (H5O_unprotect(loc, oh, H5AC__NO_FLAGS_SET) < 0)
HDONE_ERROR(H5E_OHDR, H5E_CANTUNPROTECT, NULL, "unable to release object header")
+ }
FUNC_LEAVE_NOAPI_TAG(ret_value)
} /* end H5O_protect() */