[svn-r2531] Description:

    The "FILENAME" declared extern in h5test.h is not always used.
    It was used in h5_cleanup to remove temporary files created
    during tests.  Not all tests codes have used this routine.
    Indeed, quite a few of test programs do "#define FILENAME ".
    Also, h5_cleanup needs to work in tandem with h5_fixname.
    h5_fixname accepts an explicite base_name argument instead
    of using the global variable FILENAME.  That is cleaner.
Solution:
    Added char *base_name[] as a new argument to h5_cleanup, in
    the same style as h5_fixname.  Removed "extern char *FILENAME..."
    from use.  Also, undo some unnecessary declaration of "char *FILENAME"
    from some tests which don't use it at all (yet).
Platforms tested:
    modi4-64(irix64), arabica(solari2.7), eirene(linux)
    (arabica could not launch tests automatically.  I had to hack
     in LD_LIBRARY_PATH to make them run.)

1 files changed, 5 insertions, 5 deletions

diff --git a/test/big.c b/test/big.c
index 66d5870..b0938ff 100644
--- a/test/big.c
+++ b/test/big.c
@@ -386,23 +386,23 @@ main (void)
     if (sizeof(long_long)<8 || 0==GB8LL) {
 	puts("Test skipped because sizeof(long_long) is too small. This");
 	puts("hardware apparently doesn't support 64-bit integer types.");
-    h5_cleanup(fapl);
+    h5_cleanup(FILENAME, fapl);
 	exit(0);
     }
     if (!is_sparse()) {
 	puts("Test skipped because file system does not support holes.");
-    h5_cleanup(fapl);
+    h5_cleanup(FILENAME, fapl);
 	exit(0);
     }
     if (!enough_room(fapl)) {
 	puts("Test skipped because of quota (file size or num open files).");
-    h5_cleanup(fapl);
+    h5_cleanup(FILENAME, fapl);
 	exit(0);
     }
     if (sizeof(hsize_t)<=4) {
 	puts("Test skipped because the hdf5 library was configured with the");
 	puts("--disable-hsizet flag in order to work around a compiler bug.");
-    h5_cleanup(fapl);
+    h5_cleanup(FILENAME, fapl);
 	exit(0);
     }
     
@@ -410,7 +410,7 @@ main (void)
     if (writer(fapl, WRT_N)) goto error;
     if (reader(fapl)) goto error;
     puts("All big tests passed.");
-    if (h5_cleanup(fapl)) remove(DNAME);
+    if (h5_cleanup(FILENAME, fapl)) remove(DNAME);
     return 0;
 
  error: