Many fixes to various compiler warnings (#3124)

* Fixed various -Wmissing-variable-declarations by adding static keyword
* In a few cases, renamed the variable suffix from _g to _s.
* Fixed some -Wmissing-variable-declarations by using different declaration macros
* Fixed various -Wconditional-uninitialized warnings by just initializing variable to zero
* Fixed various -Wcomma warnings
* Fixed clang -Wstrict-prototypes warnings
* Fixed various -Wunused-variable warnings
* Updated some casts to fix the only 3 -Wcast-qual warnings
* Fixed the only -Wsometimes-uninitialized warning

1 files changed, 29 insertions, 29 deletions

diff --git a/test/cache.c b/test/cache.c
index fce0ef1..80052a4 100644
--- a/test/cache.c
+++ b/test/cache.c
@@ -53,7 +53,7 @@ hbool_t core_file_driver_failed = FALSE;
 
 /* global variable declarations: */
 
-const char *FILENAME[] = {"cache_test", NULL};
+static const char *FILENAME[] = {"cache_test", NULL};
 
 /* private typedef declarations: */
 
@@ -11290,7 +11290,7 @@ check_expunge_entry(unsigned paged)
     size_t        entry_size;
     H5F_t        *file_ptr = NULL;
     test_entry_t *base_addr;
-    test_entry_t *entry_ptr;
+    test_entry_t *entry_ptr = NULL;
 
     if (paged)
         TESTING("H5C_expunge_entry() functionality (paged aggregation)");
@@ -11563,7 +11563,7 @@ check_multiple_read_protect(unsigned paged)
 #if H5C_COLLECT_CACHE_STATS
     H5C_t *cache_ptr = NULL;
 #endif /* H5C_COLLECT_CACHE_STATS */
-    test_entry_t *entry_ptr;
+    test_entry_t *entry_ptr = NULL;
 
     if (paged)
         TESTING("multiple read only protects on a single entry (paged aggr)");
@@ -14156,8 +14156,8 @@ static unsigned
 check_double_pin_err(unsigned paged)
 {
     herr_t        result;
-    H5F_t        *file_ptr = NULL;
-    test_entry_t *entry_ptr;
+    H5F_t        *file_ptr  = NULL;
+    test_entry_t *entry_ptr = NULL;
 
     if (paged)
         TESTING("pin a pinned entry error (paged aggregation)");
@@ -14241,8 +14241,8 @@ static unsigned
 check_double_unpin_err(unsigned paged)
 {
     herr_t        result;
-    H5F_t        *file_ptr = NULL;
-    test_entry_t *entry_ptr;
+    H5F_t        *file_ptr  = NULL;
+    test_entry_t *entry_ptr = NULL;
 
     if (paged)
         TESTING("unpin an unpinned entry error (paged aggregation)");
@@ -14335,8 +14335,8 @@ static unsigned
 check_pin_entry_errs(unsigned paged)
 {
     herr_t        result;
-    H5F_t        *file_ptr = NULL;
-    test_entry_t *entry_ptr;
+    H5F_t        *file_ptr  = NULL;
+    test_entry_t *entry_ptr = NULL;
 
     if (paged)
         TESTING("pin entry related errors (paged aggregation)");
@@ -14442,8 +14442,8 @@ check_pin_entry_errs(unsigned paged)
 static unsigned
 check_double_protect_err(unsigned paged)
 {
-    H5F_t             *file_ptr = NULL;
-    test_entry_t      *entry_ptr;
+    H5F_t             *file_ptr  = NULL;
+    test_entry_t      *entry_ptr = NULL;
     H5C_cache_entry_t *cache_entry_ptr;
 
     if (paged)
@@ -14525,8 +14525,8 @@ static unsigned
 check_double_unprotect_err(unsigned paged)
 {
     herr_t        result;
-    H5F_t        *file_ptr = NULL;
-    test_entry_t *entry_ptr;
+    H5F_t        *file_ptr  = NULL;
+    test_entry_t *entry_ptr = NULL;
 
     if (paged)
         TESTING("unprotect an unprotected entry error (paged aggregation)");
@@ -14606,8 +14606,8 @@ static unsigned
 check_mark_entry_dirty_errs(unsigned paged)
 {
     herr_t        result;
-    H5F_t        *file_ptr = NULL;
-    test_entry_t *entry_ptr;
+    H5F_t        *file_ptr  = NULL;
+    test_entry_t *entry_ptr = NULL;
 
     if (paged)
         TESTING("mark entry dirty related errors (paged aggregation)");
@@ -14685,8 +14685,8 @@ static unsigned
 check_expunge_entry_errs(unsigned paged)
 {
     herr_t        result;
-    H5F_t        *file_ptr = NULL;
-    test_entry_t *entry_ptr;
+    H5F_t        *file_ptr  = NULL;
+    test_entry_t *entry_ptr = NULL;
 
     if (paged)
         TESTING("expunge entry related errors (paged aggregation)");
@@ -14797,12 +14797,12 @@ static unsigned
 check_move_entry_errs(unsigned paged)
 {
     herr_t        result;
-    H5F_t        *file_ptr  = NULL;
-    H5C_t        *cache_ptr = NULL;
-    test_entry_t *entry_ptr = NULL;
-    test_entry_t *entry_0_0_ptr;
-    test_entry_t *entry_0_1_ptr;
-    test_entry_t *entry_1_0_ptr;
+    H5F_t        *file_ptr      = NULL;
+    H5C_t        *cache_ptr     = NULL;
+    test_entry_t *entry_ptr     = NULL;
+    test_entry_t *entry_0_0_ptr = NULL;
+    test_entry_t *entry_0_1_ptr = NULL;
+    test_entry_t *entry_1_0_ptr = NULL;
 
     if (paged)
         TESTING("move entry related errors (paged aggregation)");
@@ -14914,8 +14914,8 @@ static unsigned
 check_resize_entry_errs(unsigned paged)
 {
     herr_t        result;
-    H5F_t        *file_ptr = NULL;
-    test_entry_t *entry_ptr;
+    H5F_t        *file_ptr  = NULL;
+    test_entry_t *entry_ptr = NULL;
 
     if (paged)
         TESTING("resize entry related errors (paged aggregation)");
@@ -15015,8 +15015,8 @@ static unsigned
 check_unprotect_ro_dirty_err(unsigned paged)
 {
     herr_t        result;
-    H5F_t        *file_ptr = NULL;
-    test_entry_t *entry_ptr;
+    H5F_t        *file_ptr  = NULL;
+    test_entry_t *entry_ptr = NULL;
 
     if (paged)
         TESTING("unprotect a read only entry dirty error (paged aggregation)");
@@ -15135,8 +15135,8 @@ check_unprotect_ro_dirty_err(unsigned paged)
 static unsigned
 check_protect_ro_rw_err(unsigned paged)
 {
-    H5F_t        *file_ptr = NULL;
-    test_entry_t *entry_ptr;
+    H5F_t        *file_ptr  = NULL;
+    test_entry_t *entry_ptr = NULL;
     void         *thing_ptr = NULL;
 
     if (paged)