[1.10 Merge] Hdf5 1 10 warnings merge (#1754)

* Warnings fixes (#1680)

* Clean stack size warnings in sio_engine (#1687)

* Fixes stack size warnings in tcoords.c (#1688)

* Address some warnings from casting away of const (#1684)

* Fixes stack size warnings in dtransform (#1696)

* Fixes stack size warnings in set_extent test (#1698)

* Be a bit safer with signed arithmetic, thus quieting some signed-overflow warnings from GCC (#1706)

* Avoid a signed overflow: check the range of `entry_ptr->age` before
increasing it instead of increasing it and then checking the range.
This quiets a GCC warning.

* Avoid the potential for signed overflow by rewriting expressions
`MAX(0, fwidth - n)` as `MAX(n, fwidth) - n` for various `n`.
This change quiets some GCC warnings.

* Change some local variables that cannot take sensible negative values
from signed to unsigned.  This quiets GCC warnings about potential
signed overflow.

* In a handful of instances, check the range of a signed integer before
increasing/decreasing it, just in case the increase/decrease overflows.
This quiets a handful of GCC signed-overflow warnings.

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Fix object size warnings in cache.c test (#1701)

* Fix some const cast and stack/static object size warnings (#1700)

* Fix various warnings

* Move HDfree_const to H5private.h for wider use

* Print output from all ranks in parallel tests on allocation failure

* Move const pointer freeing macro to h5test.h for now

* Fixes a bug where t_cache fails due to a string size being too small (#1720)

* Fixes a bug where t_cache fails due to a string size being too small

Recent warning reductions led to an incorrect string size being passed
to h5_fileaccess, causing the test to silently fail. In addition to
fixing the bug, the test will now fail noisily on setup failures.

* Updates the t_cache test to fail noisily on setup errors

* Fix a few Clang sanitizer warnings (#1727)

* Stop lying about H5S_t const-ness (#1209)

Hyperslabs can be reworked inside several H5S callbacks, making H5S_t
non-const in some places where it is marked const. This change switches
these incorrectly const H5S_t pointer parameters and variables to
non-const where appropriate.

* Fix a few warnings after recent H5S const-related changes (#1225)

* Adjustments for HDF5 1.10

* Hdf5 1 12 Miscellaneous warnings fixes (#1718)

* Fixes const issues in the version 2 B-trees (#1172)

The operations that were changed are fundamentally not const since the
shadow operation can modify the node structure when SWMR is in use.

* Quiets const warning in H5RS code (#1181)

* Avoid calling H5Ropen_object with a misaligned H5R_ref_t: copy the (#1171)

* Avoid calling H5Ropen_object with a misaligned H5R_ref_t: copy the
raw H5R_ref_t bytes to a heap buffer that's known to have the right
alignment.

* Committing clang-format changes

* Use an automatic H5R_ref_t instead of malloc'ing one.  Go ahead and
initialize the H5R_ref_t to all-0s so that arbitrary stack content
doesn't foul things up.  Bail out with an error if `size` exceeds
`sizeof(H5R_ref_t)`.

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Miscellaneous warnings fixes

Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
Co-authored-by: David Young <dyoung@hdfgroup.org>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Fix several warnings (#747)

Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
Co-authored-by: David Young <dyoung@hdfgroup.org>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

1 files changed, 25 insertions, 23 deletions

diff --git a/test/chunk_info.c b/test/chunk_info.c
index 9cf898e..76132c6 100644
--- a/test/chunk_info.c
+++ b/test/chunk_info.c
@@ -153,29 +153,31 @@ reinit_vars(unsigned *read_flt_msk, haddr_t *addr, hsize_t *size)
 static herr_t
 test_get_chunk_info_highest18(hid_t fapl)
 {
-    char         filename[FILENAME_BUF_SIZE];
-    hid_t        chunkfile     = -1;       /* File ID */
-    hid_t        dspace        = -1;       /* Dataspace ID */
-    hid_t        dset          = -1;       /* Dataset ID */
-    hid_t        cparms        = -1;       /* Creation plist */
-    hsize_t      dims[2]       = {NX, NY}; /* Dataset dimensions */
-    hsize_t      maxdims[2]    = {H5S_UNLIMITED, H5S_UNLIMITED};
-    hsize_t      chunk_dims[2] = {CHUNK_NX, CHUNK_NY};             /* Chunk dimensions */
-    int          direct_buf[NUM_CHUNKS][CHUNK_NX][CHUNK_NY];       /* Data in chunks */
-    int          out_buf[NX][NY];                                  /* Buffer to read data in */
-    size_t       buf_size     = CHUNK_NX * CHUNK_NY * sizeof(int); /* Buffer size of a chk */
-    unsigned     filter_mask  = 0;                                 /* Filter mask */
-    unsigned     read_flt_msk = 0;                                 /* Filter mask after direct read */
-    int          fillvalue    = -1;                                /* Fill value */
-    int          aggression   = 9;                                 /* Compression aggression setting */
-    H5F_libver_t low, high;                                        /* File format bounds */
-    hsize_t      offset[2];                                        /* Offset coordinates of a chunk */
-    hsize_t      out_offset[2] = {0, 0};                           /* Buffer to get offset coordinates */
-    hsize_t      size          = 0;                                /* Size of an allocated/written chunk */
-    hsize_t      nchunks       = 0;                                /* Number of chunks */
-    haddr_t      addr          = 0;                                /* Address of an allocated/written chunk */
-    hsize_t      index         = 0;                                /* Index of a chunk */
-    int          n; /* Used on buffer, to avoid conversion warning */
+    char     filename[FILENAME_BUF_SIZE];
+    hid_t    chunkfile     = -1;       /* File ID */
+    hid_t    dspace        = -1;       /* Dataspace ID */
+    hid_t    dset          = -1;       /* Dataset ID */
+    hid_t    cparms        = -1;       /* Creation plist */
+    hsize_t  dims[2]       = {NX, NY}; /* Dataset dimensions */
+    hsize_t  maxdims[2]    = {H5S_UNLIMITED, H5S_UNLIMITED};
+    hsize_t  chunk_dims[2] = {CHUNK_NX, CHUNK_NY};             /* Chunk dimensions */
+    int      direct_buf[NUM_CHUNKS][CHUNK_NX][CHUNK_NY];       /* Data in chunks */
+    int      out_buf[NX][NY];                                  /* Buffer to read data in */
+    size_t   buf_size     = CHUNK_NX * CHUNK_NY * sizeof(int); /* Buffer size of a chk */
+    unsigned filter_mask  = 0;                                 /* Filter mask */
+    unsigned read_flt_msk = 0;                                 /* Filter mask after direct read */
+    int      fillvalue    = -1;                                /* Fill value */
+#ifdef H5_HAVE_FILTER_DEFLATE
+    int aggression = 9; /* Compression aggression setting */
+#endif
+    H5F_libver_t low, high;              /* File format bounds */
+    hsize_t      offset[2];              /* Offset coordinates of a chunk */
+    hsize_t      out_offset[2] = {0, 0}; /* Buffer to get offset coordinates */
+    hsize_t      size          = 0;      /* Size of an allocated/written chunk */
+    hsize_t      nchunks       = 0;      /* Number of chunks */
+    haddr_t      addr          = 0;      /* Address of an allocated/written chunk */
+    hsize_t      index         = 0;      /* Index of a chunk */
+    int          n;                      /* Used on buffer, to avoid conversion warning */
     hsize_t      i, j;
     herr_t       ret;