Much normalization with develop (#701)

* Brings CMake updates from develop

* Brings reduction in pedantic casts from develop

* Purges UFAIL from the library (#637)

* Committing clang-format changes

* Purges UFAIL from the library

* H5HL_insert change requested in PR

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Removes gratuitous (double)x.yF casts (#632)

* Committing clang-format changes

* Removes gratuitous (double)x.yF casts

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Committing clang-format changes

* Cleans up a const warning left over from previous constification (#633)

* Committing clang-format changes

* Adds consts to a few global variables

* Cleans up a const warning left over from previous constification

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Formatted source

* Bring over some VOL registration changes

* VOL cleanup

* H5VL_request_status_t substitutions

* H5F.c cleanup

* Minor API tweaks from develop

* Moves H5G package init/teardown to H5Gint.c

* H5G cleanup

* H5M cleanup

* H5SM cleanup

* H5T cleanup

* H5R cleanup

* H5Lpublic.h cleanup

* H5L cleanup

* H5O cleanup

* H5A, H5CS, and H5AC cleanup

* Moved H5A init/teardown code to H5Aint.c

* Moves H5D I/O functions to H5D.c

* H5D cleanup

* Misc minor cleanup

* H5P close cleanup

* H5Tpublic.h cleanup

* Fixes err_compat test

* H5PLpublic.h cleanup

* Updates H5Ppublic.h

* H5Fpublic.h updates

* H5A.c cleanup

* Brings over H5Aexists and related changes

* Brings CMake shell testing changes from develop

* Close callback changes

* H5R and H5Tcommit normalization

* err_compat test works now

* H5O tweaks

* Updates VOL registration code

* Brings over H5VL_create_object

* H5Tconv.c reformatting

* H5T.c tweaks

* Brings datatype and reference updates from develop

* Brings VOL plugin loading changes from develop

* Brings event sets from develop

* Brings async functions over

* Tools changes

* Brings over many tools changes from develop

* Brings VOL flags from develop

* Fixes h5dump double/float tests

* Updates h5repack tests

* Brings h5diff test changes from develop

* Last h5dump changes

* Brings test changes from develop

* Committing clang-format changes

* Tidied h5_testing()

* Brings chunk iteration code + misc from develop

* Updates vds test

* Enables external link parallel test

* Brings updated property lists from develop

* H5G changes from develop

* H5MF cleanup

* Brings vfd_swmr test back into CMake

* Updates threadsafe test

* Updates plist test

* Brings recent changes from develop

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

1 files changed, 182 insertions, 0 deletions

diff --git a/test/cmpd_dtransform.c b/test/cmpd_dtransform.c
new file mode 100644
index 0000000..76ff287
--- /dev/null
+++ b/test/cmpd_dtransform.c
@@ -0,0 +1,182 @@
+/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
+ * Copyright by The HDF Group.                                               *
+ * All rights reserved.                                                      *
+ *                                                                           *
+ * This file is part of HDF5.  The full HDF5 copyright notice, including     *
+ * terms governing use, modification, and redistribution, is contained in    *
+ * the COPYING file, which can be found at the root of the source code       *
+ * distribution tree, or in https://www.hdfgroup.org/licenses.               *
+ * If you do not have access to either file, you may request a copy from     *
+ * help@hdfgroup.org.                                                        *
+ * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
+
+/*
+ * Programmer:  Jan-Willem Blokland
+ *              December 1, 2020
+ *
+ * Purpose:     Test writing compounded attribute followed by
+ *              writing data with a data transform function.
+ */
+
+#include "h5test.h"
+
+#define FILENAME "cmpd_dtransform.h5"
+#define LENGTH   11
+
+typedef struct {
+    char name[64];
+    char unit[64];
+} att_t;
+
+int
+main(void)
+{
+    hsize_t     dima[]      = {1};
+    hsize_t     dims[]      = {LENGTH};
+    hid_t       str_dtyp_id = H5I_INVALID_HID, att_dtyp_id = H5I_INVALID_HID;
+    hid_t       file_id     = H5I_INVALID_HID;
+    hid_t       fspace_id   = H5I_INVALID_HID;
+    hid_t       dset_id     = H5I_INVALID_HID;
+    hid_t       att_dspc_id = H5I_INVALID_HID;
+    hid_t       att_attr_id = H5I_INVALID_HID;
+    hid_t       dxpl_id     = H5I_INVALID_HID;
+    const char *expr        = "2*x";
+    int *       data        = NULL;
+    int *       data_res    = NULL;
+    att_t *     atts        = NULL;
+    att_t *     atts_res    = NULL;
+
+    /* Compound datatype */
+    if (NULL == (atts = HDmalloc(sizeof(att_t))))
+        TEST_ERROR;
+    HDstrcpy(atts[0].name, "Name");
+    HDstrcpy(atts[0].unit, "Unit");
+
+    /* String type */
+    if ((str_dtyp_id = H5Tcopy(H5T_C_S1)) < 0)
+        FAIL_STACK_ERROR
+    if (H5Tset_size(str_dtyp_id, 64) < 0)
+        FAIL_STACK_ERROR
+
+    /* Attribute type */
+    if ((att_dtyp_id = H5Tcreate(H5T_COMPOUND, sizeof(att_t))) < 0)
+        FAIL_STACK_ERROR
+    if (H5Tinsert(att_dtyp_id, "NAME", HOFFSET(att_t, name), str_dtyp_id) < 0)
+        FAIL_STACK_ERROR
+    if (H5Tinsert(att_dtyp_id, "UNIT", HOFFSET(att_t, unit), str_dtyp_id) < 0)
+        FAIL_STACK_ERROR
+
+    /* Create file. */
+    if ((file_id = H5Fcreate(FILENAME, H5F_ACC_TRUNC, H5P_DEFAULT, H5P_DEFAULT)) < 0)
+        FAIL_STACK_ERROR
+
+    /* Create file dataspace. */
+    if ((fspace_id = H5Screate_simple(1, dims, NULL)) < 0)
+        FAIL_STACK_ERROR
+
+    /* Create dataset. */
+    if ((dset_id = H5Dcreate2(file_id, "test_dset", H5T_NATIVE_INT, fspace_id, H5P_DEFAULT, H5P_DEFAULT,
+                              H5P_DEFAULT)) < 0)
+        FAIL_STACK_ERROR
+
+    /* Write the attribute (compound) to the dataset */
+    if ((att_dspc_id = H5Screate_simple(1, dima, NULL)) < 0)
+        FAIL_STACK_ERROR
+    if ((att_attr_id =
+             H5Acreate2(dset_id, "ATTRIBUTES", att_dtyp_id, att_dspc_id, H5P_DEFAULT, H5P_DEFAULT)) < 0)
+        FAIL_STACK_ERROR
+    if (H5Awrite(att_attr_id, att_dtyp_id, atts) < 0)
+        FAIL_STACK_ERROR
+
+    /* Create dataset transfer property list */
+    if ((dxpl_id = H5Pcreate(H5P_DATASET_XFER)) < 0)
+        FAIL_STACK_ERROR
+    if (H5Pset_data_transform(dxpl_id, expr) < 0) {
+        HDprintf("**** ERROR: H5Pset_data_transform (expression: %s) ****\n", expr);
+        FAIL_STACK_ERROR
+    }
+
+    if (NULL == (data = HDmalloc(LENGTH * sizeof(int))))
+        TEST_ERROR;
+    if (NULL == (data_res = HDmalloc(LENGTH * sizeof(int))))
+        TEST_ERROR;
+    for (unsigned i = 0; i < LENGTH; i++) {
+        data[i]     = 10;
+        data_res[i] = 2 * data[i];
+    }
+
+    /* Write the data */
+    if (H5Dwrite(dset_id, H5T_NATIVE_INT, H5S_ALL, H5S_ALL, dxpl_id, data) < 0)
+        FAIL_STACK_ERROR
+
+    /* Read attribute */
+    if (NULL == (atts_res = HDmalloc(sizeof(att_t))))
+        TEST_ERROR;
+    if (H5Aread(att_attr_id, att_dtyp_id, atts_res) < 0)
+        FAIL_STACK_ERROR
+
+    /* Verify attribute */
+    if (HDstrcmp(atts_res[0].name, atts[0].name) != 0)
+        TEST_ERROR;
+    if (HDstrcmp(atts_res[0].unit, atts[0].unit) != 0)
+        TEST_ERROR;
+
+    /* Read the data */
+    if (H5Dread(dset_id, H5T_NATIVE_INT, H5S_ALL, H5S_ALL, H5P_DEFAULT, data) < 0)
+        FAIL_STACK_ERROR
+
+    /* Verify data */
+    for (unsigned idx = 0; idx < LENGTH; idx++)
+        if (data[idx] != data_res[idx])
+            TEST_ERROR;
+
+    HDfree(atts);
+    HDfree(atts_res);
+    HDfree(data);
+    HDfree(data_res);
+
+    /* Close all identifiers. */
+    if (H5Pclose(dxpl_id) < 0)
+        FAIL_STACK_ERROR
+    if (H5Aclose(att_attr_id) < 0)
+        FAIL_STACK_ERROR
+    if (H5Sclose(att_dspc_id) < 0)
+        FAIL_STACK_ERROR
+    if (H5Dclose(dset_id) < 0)
+        FAIL_STACK_ERROR
+    if (H5Sclose(fspace_id) < 0)
+        FAIL_STACK_ERROR
+    if (H5Fclose(file_id) < 0)
+        FAIL_STACK_ERROR
+    if (H5Tclose(att_dtyp_id) < 0)
+        FAIL_STACK_ERROR
+    if (H5Tclose(str_dtyp_id) < 0)
+        FAIL_STACK_ERROR
+
+    return 0;
+
+error:
+    H5E_BEGIN_TRY
+    {
+        H5Pclose(dxpl_id);
+        H5Aclose(att_attr_id);
+        H5Sclose(att_dspc_id);
+        H5Dclose(dset_id);
+        H5Sclose(fspace_id);
+        H5Fclose(file_id);
+        H5Tclose(att_dtyp_id);
+        H5Tclose(str_dtyp_id);
+    }
+    H5E_END_TRY
+
+    if (atts)
+        HDfree(atts);
+    if (atts_res)
+        HDfree(atts_res);
+    if (data)
+        HDfree(data);
+    if (data_res)
+        HDfree(data_res);
+
+    return 1;
+}