diff options
| author | Quincey Koziol <koziol@hdfgroup.org> | 2001-11-27 16:29:13 (GMT) |
|---|---|---|
| committer | Quincey Koziol <koziol@hdfgroup.org> | 2001-11-27 16:29:13 (GMT) |
| commit | d456c2bb82be98bc2b7c1039927eb52258d1a0eb (patch) | |
| tree | a7d8a65aef5d962c89b0965c86eb535917c023ad /test/fillval.c | |
| parent | 05264c88788f9bd9b04a58673ded246904210235 (diff) | |
| download | hdf5-d456c2bb82be98bc2b7c1039927eb52258d1a0eb.zip hdf5-d456c2bb82be98bc2b7c1039927eb52258d1a0eb.tar.gz hdf5-d456c2bb82be98bc2b7c1039927eb52258d1a0eb.tar.bz2 | |
[svn-r4643] Purpose:
Code cleanup
Description:
Windows is generating hundreds of warnings from some of the practices in
the library. Mostly, they are because size_t is 32-bit and hsize_t is
64-bit on Windows and we were carelessly casting the larger values down to
the smaller ones without checking for overflow.
Also, some other small code cleanups,etc.
Solution:
Re-worked some algorithms to eliminate the casts and also added more
overflow checking for assignments and function parameters which needed
casts.
Kent did most of the work, I just went over his changes and fit them into
the the library code a bit better.
Platforms tested:
FreeBSD 4.4 (hawkwind)
Diffstat (limited to 'test/fillval.c')
| -rw-r--r-- | test/fillval.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/fillval.c b/test/fillval.c index c794ff9..693bdc6 100644 --- a/test/fillval.c +++ b/test/fillval.c @@ -396,7 +396,7 @@ test_rdwr(hid_t fapl, const char *base_name, H5D_layout_t layout) for (i=0; i<1000; i++) { for (j=0, odd=0; j<5; j++) { hs_offset[j] = rand() % cur_size[j]; - odd += hs_offset[j]%2; + odd += (int)(hs_offset[j]%2); } should_be = odd ? fillval : 9999; if (H5Sselect_hyperslab(fspace, H5S_SELECT_SET, hs_offset, NULL, @@ -594,7 +594,7 @@ test_extend(hid_t fapl, const char *base_name, H5D_layout_t layout) for (i=0; i<1000; i++) { for (j=0, odd=0; j<5; j++) { hs_offset[j] = rand() % cur_size[j]; - odd += hs_offset[j]%2; + odd += (int)(hs_offset[j]%2); } should_be = odd ? fillval : 9999; if (H5Sselect_hyperslab(fspace, H5S_SELECT_SET, hs_offset, NULL, @@ -628,7 +628,7 @@ test_extend(hid_t fapl, const char *base_name, H5D_layout_t layout) if ((hsize_t)hs_offset[j]>=cur_size[j]) { odd = 1; } else { - odd += hs_offset[j]%2; + odd += (int)(hs_offset[j]%2); } } |