[svn-r9727] Purpose:

    Bug Fix/Code Cleanup/Doc Cleanup/Optimization/Branch Sync :-)

Description:
    Generally speaking, this is the "signed->unsigned" change to selections.
However, in the process of merging code back, things got stickier and stickier
until I ended up doing a big "sync the two branches up" operation.  So... I
brought back all the "infrastructure" fixes from the development branch to the
release branch (which I think were actually making some improvement in
performance) as well as fixed several bugs which had been fixed in one branch,
but not the other.

    I've also tagged the repository before making this checkin with the label
"before_signed_unsigned_changes".

Platforms tested:
    FreeBSD 4.10 (sleipnir) w/parallel & fphdf5
    FreeBSD 4.10 (sleipnir) w/threadsafe
    FreeBSD 4.10 (sleipnir) w/backward compatibility
    Solaris 2.7 (arabica) w/"purify options"
    Solaris 2.8 (sol) w/FORTRAN & C++
    AIX 5.x (copper) w/parallel & FORTRAN
    IRIX64 6.5 (modi4) w/FORTRAN
    Linux 2.4 (heping) w/FORTRAN & C++


Misc. update:

1 files changed, 19 insertions, 19 deletions

diff --git a/test/ntypes.c b/test/ntypes.c
index 2cb07e3..83b7c5b 100644
--- a/test/ntypes.c
+++ b/test/ntypes.c
@@ -2020,7 +2020,7 @@ test_refer_dtype2(hid_t file)
     hid_t               dtype, native_type;
     hsize_t		dims1[] = {1},
             	        dims2[] = {SPACE2_DIM1, SPACE2_DIM2};
-    hssize_t	        start[SPACE2_RANK];     /* Starting location of hyperslab */
+    hsize_t	        start[SPACE2_RANK];     /* Starting location of hyperslab */
     hsize_t		stride[SPACE2_RANK];    /* Stride of hyperslab */
     hsize_t		count[SPACE2_RANK];     /* Element count of hyperslab */
     hsize_t		block[SPACE2_RANK];     /* Block size of hyperslab */
@@ -2286,7 +2286,7 @@ test_bitfield_dtype(hid_t file)
     hid_t		type=-1, space=-1, dset=-1;
     hid_t               dataset, dtype, native_type;
     size_t		i;
-    unsigned char	wbuf[32], rbuf[32];
+    unsigned char	wbuf[32];
     hsize_t		nelmts;
     
     TESTING("bitfield datatype");
@@ -2330,7 +2330,10 @@ test_bitfield_dtype(hid_t file)
                                                                       
 error:                                                       
     return -1;
-} /* test_opaque_dtype */
+} /* test_bitfield_dtype */
+
+
+
 
 
 /*-------------------------------------------------------------------------
@@ -2352,21 +2355,18 @@ error:
 static herr_t
 test_ninteger(void)
 {
-    hid_t     fid1;                  /* file ID */
-    hid_t     fid2;                  /* file ID */
-    hid_t     did1;                  /* dataset ID */
-    hid_t     did2;                  /* dataset ID */
-    hid_t     sid1;                  /* dataspace ID */ 
-    hid_t     dcpl1;                 /* dataset creation property list ID */
-    hid_t     dcpl2;                 /* dataset creation property list ID */
-    hid_t     tid1;                  /* file datatype */
-    hid_t     tid2;                  /* file datatype */
-    hid_t     nid1;                  /* native datatype */
-    hid_t     nid2;                  /* native datatype */
-    size_t    prec1;                 /* precision */
-    size_t    prec2;                 /* precision */
+    hid_t     fid1=(-1);             /* file ID */
+    hid_t     fid2=(-1);             /* file ID */
+    hid_t     did1=(-1);             /* dataset ID */
+    hid_t     did2=(-1);             /* dataset ID */
+    hid_t     sid1=(-1);             /* dataspace ID */ 
+    hid_t     dcpl1=(-1);            /* dataset creation property list ID */
+    hid_t     dcpl2=(-1);            /* dataset creation property list ID */
+    hid_t     tid1=(-1);             /* file datatype */
+    hid_t     tid2=(-1);             /* file datatype */
+    hid_t     nid1=(-1);             /* native datatype */
+    hid_t     nid2=(-1);             /* native datatype */
     hsize_t   dims[1]={DIM3};        /* dataspace dimensions */
-    size_t    nsize;                 /* size of native type */
     hsize_t   nelmts;                /* number of elements in dataset */
     int       rank=1;                /* rank of dataset */
     int       buf[DIM3];
@@ -2435,7 +2435,7 @@ test_ninteger(void)
      goto error;
 
     /* get size */
-    if ((nsize=H5Tget_size(nid1))==0)
+    if (H5Tget_size(nid1)==0)
      goto error;
 
     /* get rank */
@@ -2478,7 +2478,7 @@ test_ninteger(void)
      goto error;
 
     /* check */
-    if ((prec1=H5Tget_precision(nid1))!=(prec2=H5Tget_precision(nid2))) {
+    if (H5Tget_precision(nid1)!=H5Tget_precision(nid2)) {
      printf("    Precision differ.\n");
      goto error;
     }