Strip HD prefix from string/char C API calls (#3540)

* Strip HD prefix from string/char C API calls

* HD(f)(put|get)(s|c)
* HDstr*
* HDv*printf
* HD(s)(print|scan)f
* HDperror

But NOT:

* HDstrcase*
* HDvasprintf
* HDstrtok_r
* HDstrndup

As those are not C99 and have portability work-around
implementations. They will be handled later.

* Fix th5_system.c screwup

1 files changed, 32 insertions, 32 deletions

diff --git a/test/trefstr.c b/test/trefstr.c
index 1895fb6..cd7ddcb 100644
--- a/test/trefstr.c
+++ b/test/trefstr.c
@@ -235,7 +235,7 @@ test_refstr_wrap(void)
     MESSAGE(5, ("Testing Wrapping Ref-Counted Strings\n"));
 
     /* Initialize buffer */
-    HDstrcpy(buf, "foo");
+    strcpy(buf, "foo");
 
     /* Wrap ref-counted string around existing buffer */
     rs = H5RS_wrap(buf);
@@ -245,8 +245,8 @@ test_refstr_wrap(void)
     s = H5RS_get_str(rs);
     CHECK_PTR(s, "H5RS_get_str");
     CHECK_PTR_EQ(s, buf, "wrapping");
-    cmp = HDstrcmp(s, buf);
-    VERIFY(cmp, 0, "HDstrcmp");
+    cmp = strcmp(s, buf);
+    VERIFY(cmp, 0, "strcmp");
 
     /* Increment reference count (should duplicate string) */
     ret = H5RS_incr(rs);
@@ -261,7 +261,7 @@ test_refstr_wrap(void)
     if (s == buf)
         TestErrPrintf("%d: Should not have gotten the same pointer from reference-counted string!\n",
                       __LINE__);
-    cmp = HDstrcmp(s, buf);
+    cmp = strcmp(s, buf);
     if (cmp <= 0)
         TestErrPrintf("%d: string comparison incorrect!\n", __LINE__);
 
@@ -302,9 +302,9 @@ test_refstr_asprintf_cat(void)
     /* Get pointer to raw string in ref-counted string */
     s = H5RS_get_str(rs);
     CHECK_PTR(s, "H5RS_get_str");
-    HDsnprintf(buf, sizeof(buf), "%d-%s", (int)10, "foo");
-    cmp = HDstrcmp(s, buf);
-    VERIFY(cmp, 0, "HDstrcmp");
+    snprintf(buf, sizeof(buf), "%d-%s", (int)10, "foo");
+    cmp = strcmp(s, buf);
+    VERIFY(cmp, 0, "strcmp");
 
     /* Append more output to ref-counted string */
     ret = H5RS_asprintf_cat(rs, "-%f", (double)20.0);
@@ -313,9 +313,9 @@ test_refstr_asprintf_cat(void)
     /* Get pointer to raw string in ref-counted string */
     s = H5RS_get_str(rs);
     CHECK_PTR(s, "H5RS_get_str");
-    HDsnprintf(buf, sizeof(buf), "%d-%s-%f", (int)10, "foo", (double)20.0);
-    cmp = HDstrcmp(s, buf);
-    VERIFY(cmp, 0, "HDstrcmp");
+    snprintf(buf, sizeof(buf), "%d-%s-%f", (int)10, "foo", (double)20.0);
+    cmp = strcmp(s, buf);
+    VERIFY(cmp, 0, "strcmp");
 
     /* Decrement reference count for string */
     ret = H5RS_decr(rs);
@@ -353,9 +353,9 @@ test_refstr_acat(void)
     /* Get pointer to raw string in ref-counted string */
     s = H5RS_get_str(rs);
     CHECK_PTR(s, "H5RS_get_str");
-    HDsnprintf(buf, sizeof(buf), "%s", "foo");
-    cmp = HDstrcmp(s, buf);
-    VERIFY(cmp, 0, "HDstrcmp");
+    snprintf(buf, sizeof(buf), "%s", "foo");
+    cmp = strcmp(s, buf);
+    VERIFY(cmp, 0, "strcmp");
 
     /* Append another string to ref-counted string */
     ret = H5RS_acat(rs, "bar");
@@ -364,9 +364,9 @@ test_refstr_acat(void)
     /* Get pointer to raw string in ref-counted string */
     s = H5RS_get_str(rs);
     CHECK_PTR(s, "H5RS_get_str");
-    HDsnprintf(buf, sizeof(buf), "%s", "foobar");
-    cmp = HDstrcmp(s, buf);
-    VERIFY(cmp, 0, "HDstrcmp");
+    snprintf(buf, sizeof(buf), "%s", "foobar");
+    cmp = strcmp(s, buf);
+    VERIFY(cmp, 0, "strcmp");
 
     /* Append a large string to ref-counted string */
     large_str = malloc(1024);
@@ -379,14 +379,14 @@ test_refstr_acat(void)
     /* Get pointer to raw string in ref-counted string */
     s = H5RS_get_str(rs);
     CHECK_PTR(s, "H5RS_get_str");
-    HDsnprintf(buf, sizeof(buf), "%s", "foobar");
+    snprintf(buf, sizeof(buf), "%s", "foobar");
     large_str2 = malloc(1024 + 6);
     CHECK_PTR(large_str2, "malloc");
-    HDstrcpy(large_str2, "foobar");
+    strcpy(large_str2, "foobar");
     memset(&large_str2[6], 'a', 1024);
     large_str2[1029] = '\0';
-    cmp              = HDstrcmp(s, large_str2);
-    VERIFY(cmp, 0, "HDstrcmp");
+    cmp              = strcmp(s, large_str2);
+    VERIFY(cmp, 0, "strcmp");
 
     /* Decrement reference count for string */
     ret = H5RS_decr(rs);
@@ -426,9 +426,9 @@ test_refstr_ancat(void)
     /* Get pointer to raw string in ref-counted string */
     s = H5RS_get_str(rs);
     CHECK_PTR(s, "H5RS_get_str");
-    HDstrcpy(buf, "fo");
-    cmp = HDstrcmp(s, buf);
-    VERIFY(cmp, 0, "HDstrcmp");
+    strcpy(buf, "fo");
+    cmp = strcmp(s, buf);
+    VERIFY(cmp, 0, "strcmp");
 
     /* Append another string to ref-counted string */
     ret = H5RS_ancat(rs, "bar", 2);
@@ -437,9 +437,9 @@ test_refstr_ancat(void)
     /* Get pointer to raw string in ref-counted string */
     s = H5RS_get_str(rs);
     CHECK_PTR(s, "H5RS_get_str");
-    HDstrcpy(buf, "foba");
-    cmp = HDstrcmp(s, buf);
-    VERIFY(cmp, 0, "HDstrcmp");
+    strcpy(buf, "foba");
+    cmp = strcmp(s, buf);
+    VERIFY(cmp, 0, "strcmp");
 
     /* Decrement reference count for string */
     ret = H5RS_decr(rs);
@@ -475,9 +475,9 @@ test_refstr_aputc(void)
     /* Get pointer to raw string in ref-counted string */
     s = H5RS_get_str(rs);
     CHECK_PTR(s, "H5RS_get_str");
-    HDstrcpy(buf, "f");
-    cmp = HDstrcmp(s, buf);
-    VERIFY(cmp, 0, "HDstrcmp");
+    strcpy(buf, "f");
+    cmp = strcmp(s, buf);
+    VERIFY(cmp, 0, "strcmp");
 
     /* Append another character to ref-counted string */
     ret = H5RS_aputc(rs, 'o');
@@ -486,9 +486,9 @@ test_refstr_aputc(void)
     /* Get pointer to raw string in ref-counted string */
     s = H5RS_get_str(rs);
     CHECK_PTR(s, "H5RS_get_str");
-    HDstrcpy(buf, "fo");
-    cmp = HDstrcmp(s, buf);
-    VERIFY(cmp, 0, "HDstrcmp");
+    strcpy(buf, "fo");
+    cmp = strcmp(s, buf);
+    VERIFY(cmp, 0, "strcmp");
 
     /* Decrement reference count for string */
     ret = H5RS_decr(rs);