Many fixes to various compiler warnings (#3124)

* Fixed various -Wmissing-variable-declarations by adding static keyword
* In a few cases, renamed the variable suffix from _g to _s.
* Fixed some -Wmissing-variable-declarations by using different declaration macros
* Fixed various -Wconditional-uninitialized warnings by just initializing variable to zero
* Fixed various -Wcomma warnings
* Fixed clang -Wstrict-prototypes warnings
* Fixed various -Wunused-variable warnings
* Updated some casts to fix the only 3 -Wcast-qual warnings
* Fixed the only -Wsometimes-uninitialized warning

1 files changed, 9 insertions, 9 deletions

diff --git a/test/use_disable_mdc_flushes.c b/test/use_disable_mdc_flushes.c
index ea674ec..04319ab 100644
--- a/test/use_disable_mdc_flushes.c
+++ b/test/use_disable_mdc_flushes.c
@@ -27,7 +27,7 @@
 #include "H5Dpkg.h"
 
 /* Global Variable definitions */
-const char *progname_g = "use_disable_mdc_flushes"; /* program name */
+static const char *progname_g = "use_disable_mdc_flushes"; /* program name */
 
 /* these two definitions must match each other */
 #define UC_DATATYPE   H5T_NATIVE_SHORT /* use case HDF5 data type */
@@ -40,14 +40,14 @@ const char *progname_g = "use_disable_mdc_flushes"; /* program name */
         goto done;                                                                                           \
     }
 
-char   *filename_g;
-hsize_t nplanes_g;
-int     use_swmr_g;
-int     chunkplanes_g;
-int     chunksize_g;
-hsize_t dims_g[UC_RANK];
-hsize_t max_dims_g[UC_RANK];
-hsize_t chunkdims_g[UC_RANK];
+static char   *filename_g;
+static hsize_t nplanes_g;
+static int     use_swmr_g;
+static int     chunkplanes_g;
+static int     chunksize_g;
+static hsize_t dims_g[UC_RANK];
+static hsize_t max_dims_g[UC_RANK];
+static hsize_t chunkdims_g[UC_RANK];
 
 static void usage(const char *prog);
 static int  parse_option(int argc, char *const argv[]);