summaryrefslogtreecommitdiffstats
path: root/test
diff options
context:
space:
mode:
authorMike McGreevy <mamcgree@hdfgroup.org>2010-11-17 15:08:33 (GMT)
committerMike McGreevy <mamcgree@hdfgroup.org>2010-11-17 15:08:33 (GMT)
commit39e39746286dcb31adec94fbde0345587594cefd (patch)
tree7a50eb19bb721ee9f822234b1b22861498e8e045 /test
parentc249ccfd1502c428b820d6316a5cf7a0a9d5ca82 (diff)
downloadhdf5-39e39746286dcb31adec94fbde0345587594cefd.zip
hdf5-39e39746286dcb31adec94fbde0345587594cefd.tar.gz
hdf5-39e39746286dcb31adec94fbde0345587594cefd.tar.bz2
[svn-r19798] Purpose:
Add additional error checking to catch erroneous user input. Description: Attempting to retrieve a links's name by index in the case where the link is external and the file that the object is located in doesn't exist was causing a segmentation fault (in production) and an assertion failure (in debug). The segfault wasn't occuring until the metadata accumulator attempted a write, so I've added error checking higher in the pipeline in H5O_protect (where there was previously just an assert) to catch this. I've also added additional asserts in the H5F layer where there were none. Additionally, I added another case to the links.c test to test that this fails gracefully instead of segfaulting or asserting out. Tested: h5committest and gandalf (mac os x)
Diffstat (limited to 'test')
-rw-r--r--test/links.c17
1 files changed, 17 insertions, 0 deletions
diff --git a/test/links.c b/test/links.c
index e4aead6..c8ece99 100644
--- a/test/links.c
+++ b/test/links.c
@@ -2640,6 +2640,8 @@ external_link_dangling(hid_t fapl, hbool_t new_format)
{
hid_t fid = (-1); /* File ID */
hid_t gid = (-1); /* Group IDs */
+ hid_t rid = (-1); /* Root Group ID */
+ hid_t status = (-1); /* Status */
char filename1[NAME_BUF_SIZE],
filename2[NAME_BUF_SIZE]; /* Names of files to externally link across */
@@ -2672,6 +2674,9 @@ external_link_dangling(hid_t fapl, hbool_t new_format)
/* Open first file */
if((fid=H5Fopen(filename1, H5F_ACC_RDWR, fapl)) < 0) TEST_ERROR
+ /* Get root group ID */
+ if((rid=H5Gopen2(fid, "/", H5P_DEFAULT)) < 0) TEST_ERROR;
+
/* Open object through dangling file external link */
H5E_BEGIN_TRY {
gid = H5Gopen2(fid, "no_file", H5P_DEFAULT);
@@ -2692,6 +2697,18 @@ external_link_dangling(hid_t fapl, hbool_t new_format)
goto error;
}
+ /* Try to get name of object by index through dangling file external link */
+ H5E_BEGIN_TRY {
+ status = H5Lget_name_by_idx(rid, "no_file", H5_INDEX_NAME, H5_ITER_INC, 0, NULL, 0, H5P_DEFAULT);
+ } H5E_END_TRY;
+ if (status >= 0) {
+ H5_FAILED();
+ puts(" Retreiving name of object by index through dangling file external link should have failed.");
+ } /* end if */
+
+ /* Close root group */
+ if(H5Gclose(rid) < 0) TEST_ERROR
+
/* Close first file */
if(H5Fclose(fid) < 0) TEST_ERROR