Fixed HDFFV-10210 and HDFFV-10587

Description:
    - Added parameter validation (HDFFV-10210)
    - Added detection of division by zero (HDFFV-10587 - CVE-2018-17438)
    - Fixed typos in various tests
Platforms tested:
    Linux/64 (jelly)
    Linux/64 (platypus)
    Darwin (osx1011test)

1 files changed, 23 insertions, 3 deletions

diff --git a/test/tid.c b/test/tid.c
index c98514b..6375d77 100644
--- a/test/tid.c
+++ b/test/tid.c
@@ -250,7 +250,9 @@ static int id_predefined_test(void )
 
 	testObj = HDmalloc(sizeof(int));
 
-	/* Try to perform illegal functions on various predefined types */
+    /*
+     * Attempt to perform public functions on various library types
+     */
 	H5E_BEGIN_TRY
 		testID = H5Iregister(H5I_FILE, testObj);
 	H5E_END_TRY
@@ -291,7 +293,25 @@ static int id_predefined_test(void )
 	if(testErr >= 0)
 		goto out;
 
-	/* Create a datatype ID and try to perform illegal functions on it */
+    H5E_BEGIN_TRY
+        testErr = H5Itype_exists(H5I_GROUP);
+    H5E_END_TRY
+
+    VERIFY(testErr, FAIL, "H5Itype_exists");
+    if(testErr != FAIL)
+        goto out;
+
+    H5E_BEGIN_TRY
+        testErr = H5Itype_exists(H5I_ATTR);
+    H5E_END_TRY
+
+    VERIFY(testErr, FAIL, "H5Itype_exists");
+    if(testErr != FAIL)
+        goto out;
+
+    /*
+     * Create a datatype ID and try to perform illegal functions on it
+     */
 	typeID = H5Tcreate(H5T_OPAQUE, (size_t)42);
 	CHECK(typeID, H5I_INVALID_HID, "H5Tcreate");
 	if(typeID == H5I_INVALID_HID)
@@ -316,7 +336,7 @@ static int id_predefined_test(void )
 	H5Tclose(typeID);
 
 	/* testObj was never registered as an atom, so it will not be
-         * automatically freed. */
+     * automatically freed. */
 	HDfree(testObj);
 	return 0;