diff options
| author | Dana Robinson <43805+derobins@users.noreply.github.com> | 2022-05-04 14:53:13 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-04 14:53:13 (GMT) |
| commit | 19a59c29b93c04ae069881da2354d3d7048619b9 (patch) | |
| tree | fddf041f1dc140cb04b1eab577c0371e438074df /testpar/t_cache.c | |
| parent | 08861aa903510e9f7ba89f79590f852e5aae1f37 (diff) | |
| download | hdf5-19a59c29b93c04ae069881da2354d3d7048619b9.zip hdf5-19a59c29b93c04ae069881da2354d3d7048619b9.tar.gz hdf5-19a59c29b93c04ae069881da2354d3d7048619b9.tar.bz2 | |
Fixes a bug where t_cache fails due to a string size being too small (#1720)
* Fixes a bug where t_cache fails due to a string size being too small
Recent warning reductions led to an incorrect string size being passed
to h5_fileaccess, causing the test to silently fail. In addition to
fixing the bug, the test will now fail noisily on setup failures.
* Updates the t_cache test to fail noisily on setup errors
Diffstat (limited to 'testpar/t_cache.c')
| -rw-r--r-- | testpar/t_cache.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/testpar/t_cache.c b/testpar/t_cache.c index 5d1cfdc..8792892 100644 --- a/testpar/t_cache.c +++ b/testpar/t_cache.c @@ -1124,6 +1124,8 @@ setup_derived_types(void) MPI_Aint displs[9]; struct mssg_t sample; /* used to compute displacements */ + HDmemset(&sample, 0, sizeof(struct mssg_t)); + /* setup the displacements array */ if ((MPI_SUCCESS != MPI_Get_address(&sample.req, &displs[0])) || (MPI_SUCCESS != MPI_Get_address(&sample.src, &displs[1])) || @@ -6981,7 +6983,7 @@ main(int argc, char **argv) /* fix the file names */ for (u = 0; u < sizeof(FILENAME) / sizeof(FILENAME[0]) - 1; ++u) { - if (h5_fixname(FILENAME[u], fapl, filenames[u], sizeof(filenames[u])) == NULL) { + if (h5_fixname(FILENAME[u], fapl, filenames[u], PATH_MAX) == NULL) { nerrors++; if (verbose) HDfprintf(stdout, "%d:%s: h5_fixname() failed.\n", world_mpi_rank, __func__); @@ -7085,8 +7087,8 @@ finish: MPI_Barrier(MPI_COMM_WORLD); if (MAINPROCESS) { /* only process 0 reports */ HDprintf("===================================\n"); - if (failures) { - HDprintf("***metadata cache tests detected %d failures***\n", failures); + if (nerrors || failures) { + HDprintf("***metadata cache tests detected %d failures***\n", nerrors + failures); } else { HDprintf("metadata cache tests finished with no failures\n"); @@ -7103,5 +7105,5 @@ finish: MPI_Finalize(); /* cannot just return (failures) because exit code is limited to 1byte */ - return (failures != 0); + return (nerrors != 0 || failures != 0); } |