diff options
author | Dana Robinson <43805+derobins@users.noreply.github.com> | 2023-07-27 22:00:07 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-07-27 22:00:07 (GMT) |
commit | 0e82707100cf3d1b698d2ec0cad08db61d552d63 (patch) | |
tree | 6d8c9adf10cb2f52f7ad33b93e30ee0aef3125e0 /testpar | |
parent | 61186204c020a81b5b0044a3b5e08311ccf1424d (diff) | |
download | hdf5-0e82707100cf3d1b698d2ec0cad08db61d552d63.zip hdf5-0e82707100cf3d1b698d2ec0cad08db61d552d63.tar.gz hdf5-0e82707100cf3d1b698d2ec0cad08db61d552d63.tar.bz2 |
Misc missed things from previous merges (#3295)
Diffstat (limited to 'testpar')
39 files changed, 84 insertions, 95 deletions
diff --git a/testpar/API/H5_api_async_test_parallel.c b/testpar/API/H5_api_async_test_parallel.c index d6f55b1..06cbd08 100644 --- a/testpar/API/H5_api_async_test_parallel.c +++ b/testpar/API/H5_api_async_test_parallel.c @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_async_test_parallel.h b/testpar/API/H5_api_async_test_parallel.h index 9e4340c..b99a328 100644 --- a/testpar/API/H5_api_async_test_parallel.h +++ b/testpar/API/H5_api_async_test_parallel.h @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_attribute_test_parallel.c b/testpar/API/H5_api_attribute_test_parallel.c index a941b9a..163f8a1 100644 --- a/testpar/API/H5_api_attribute_test_parallel.c +++ b/testpar/API/H5_api_attribute_test_parallel.c @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_attribute_test_parallel.h b/testpar/API/H5_api_attribute_test_parallel.h index 81802ae..3deb279 100644 --- a/testpar/API/H5_api_attribute_test_parallel.h +++ b/testpar/API/H5_api_attribute_test_parallel.h @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_dataset_test_parallel.c b/testpar/API/H5_api_dataset_test_parallel.c index 6f9bf05..c2f5b93 100644 --- a/testpar/API/H5_api_dataset_test_parallel.c +++ b/testpar/API/H5_api_dataset_test_parallel.c @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_dataset_test_parallel.h b/testpar/API/H5_api_dataset_test_parallel.h index 1e2cbd0..8f7aadb 100644 --- a/testpar/API/H5_api_dataset_test_parallel.h +++ b/testpar/API/H5_api_dataset_test_parallel.h @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_datatype_test_parallel.c b/testpar/API/H5_api_datatype_test_parallel.c index 3d00ad9..f60893e 100644 --- a/testpar/API/H5_api_datatype_test_parallel.c +++ b/testpar/API/H5_api_datatype_test_parallel.c @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_datatype_test_parallel.h b/testpar/API/H5_api_datatype_test_parallel.h index 0a2ba50..85c7099 100644 --- a/testpar/API/H5_api_datatype_test_parallel.h +++ b/testpar/API/H5_api_datatype_test_parallel.h @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_file_test_parallel.c b/testpar/API/H5_api_file_test_parallel.c index 7a78619..5e4e42e 100644 --- a/testpar/API/H5_api_file_test_parallel.c +++ b/testpar/API/H5_api_file_test_parallel.c @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_file_test_parallel.h b/testpar/API/H5_api_file_test_parallel.h index aac9800..380a2ff 100644 --- a/testpar/API/H5_api_file_test_parallel.h +++ b/testpar/API/H5_api_file_test_parallel.h @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_group_test_parallel.c b/testpar/API/H5_api_group_test_parallel.c index b894b74..1c761c4 100644 --- a/testpar/API/H5_api_group_test_parallel.c +++ b/testpar/API/H5_api_group_test_parallel.c @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_group_test_parallel.h b/testpar/API/H5_api_group_test_parallel.h index 87dd24f..a2a2857 100644 --- a/testpar/API/H5_api_group_test_parallel.h +++ b/testpar/API/H5_api_group_test_parallel.h @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_link_test_parallel.c b/testpar/API/H5_api_link_test_parallel.c index f9999bd..739e815 100644 --- a/testpar/API/H5_api_link_test_parallel.c +++ b/testpar/API/H5_api_link_test_parallel.c @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_link_test_parallel.h b/testpar/API/H5_api_link_test_parallel.h index dbf0fc7..8679ccb 100644 --- a/testpar/API/H5_api_link_test_parallel.h +++ b/testpar/API/H5_api_link_test_parallel.h @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_misc_test_parallel.c b/testpar/API/H5_api_misc_test_parallel.c index 307b3a0..3453f8a 100644 --- a/testpar/API/H5_api_misc_test_parallel.c +++ b/testpar/API/H5_api_misc_test_parallel.c @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_misc_test_parallel.h b/testpar/API/H5_api_misc_test_parallel.h index 84553a9..321fb6b 100644 --- a/testpar/API/H5_api_misc_test_parallel.h +++ b/testpar/API/H5_api_misc_test_parallel.h @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_object_test_parallel.c b/testpar/API/H5_api_object_test_parallel.c index d08de7f..5870058 100644 --- a/testpar/API/H5_api_object_test_parallel.c +++ b/testpar/API/H5_api_object_test_parallel.c @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_object_test_parallel.h b/testpar/API/H5_api_object_test_parallel.h index 6a8569f..39bade9 100644 --- a/testpar/API/H5_api_object_test_parallel.h +++ b/testpar/API/H5_api_object_test_parallel.h @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_test_parallel.c b/testpar/API/H5_api_test_parallel.c index a7f2839..fb80d8a 100644 --- a/testpar/API/H5_api_test_parallel.c +++ b/testpar/API/H5_api_test_parallel.c @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ diff --git a/testpar/API/H5_api_test_parallel.h b/testpar/API/H5_api_test_parallel.h index 6df83e8..44f9440 100644 --- a/testpar/API/H5_api_test_parallel.h +++ b/testpar/API/H5_api_test_parallel.h @@ -5,7 +5,7 @@ * This file is part of HDF5. The full HDF5 copyright notice, including * * terms governing use, modification, and redistribution, is contained in * * the COPYING file, which can be found at the root of the source code * - * distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. * + * distribution tree, or in https://www.hdfgroup.org/licenses. * * If you do not have access to either file, you may request a copy from * * help@hdfgroup.org. * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ @@ -162,15 +162,15 @@ extern char H5_api_test_parallel_filename[]; MPI_LOR, MPI_COMM_WORLD)) \ { \ if (MAINPROCESS) \ - HDprintf( \ + printf( \ " failed to collect consensus about whether non-collective operation was successful\n"); \ goto error; \ } \ \ if (ind_op_failed) { \ if (MAINPROCESS) \ - HDprintf(" failure detected during non-collective operation - all other ranks will now fail " \ - "too\n"); \ + printf(" failure detected during non-collective operation - all other ranks will now fail " \ + "too\n"); \ goto error; \ } \ } diff --git a/testpar/API/t_bigio.c b/testpar/API/t_bigio.c index 0184c3a..f1d7a97 100644 --- a/testpar/API/t_bigio.c +++ b/testpar/API/t_bigio.c @@ -1,3 +1,14 @@ +/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * + * Copyright by The HDF Group. * + * All rights reserved. * + * * + * This file is part of HDF5. The full HDF5 copyright notice, including * + * terms governing use, modification, and redistribution, is contained in * + * the COPYING file, which can be found at the root of the source code * + * distribution tree, or in https://www.hdfgroup.org/licenses. * + * If you do not have access to either file, you may request a copy from * + * help@hdfgroup.org. * + * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ #include "hdf5.h" #include "testphdf5.h" @@ -1850,7 +1861,7 @@ main(int argc, char **argv) /* Attempt to turn off atexit post processing so that in case errors * happen during the test and the process is aborted, it will not get - * hang in the atexit post processing in which it may try to make MPI + * hung in the atexit post processing in which it may try to make MPI * calls. By then, MPI calls may not work. */ if (H5dont_atexit() < 0) diff --git a/testpar/API/t_shapesame.c b/testpar/API/t_shapesame.c index 621c336..9d48827 100644 --- a/testpar/API/t_shapesame.c +++ b/testpar/API/t_shapesame.c @@ -3962,7 +3962,7 @@ void *old_client_data; /* previous error handler arg.*/ #ifdef USE_PAUSE /* pause the process for a moment to allow debugger to attach if desired. */ -/* Will pause more if greenlight file is not persent but will eventually */ +/* Will pause more if greenlight file is not present but will eventually */ /* continue. */ #include <sys/types.h> #include <sys/stat.h> @@ -4301,7 +4301,7 @@ main(int argc, char **argv) /* Attempt to turn off atexit post processing so that in case errors * happen during the test and the process is aborted, it will not get - * hang in the atexit post processing in which it may try to make MPI + * hung in the atexit post processing in which it may try to make MPI * calls. By then, MPI calls may not work. */ if (H5dont_atexit() < 0) { diff --git a/testpar/API/testphdf5.c b/testpar/API/testphdf5.c index 9469c12..a341112 100644 --- a/testpar/API/testphdf5.c +++ b/testpar/API/testphdf5.c @@ -51,7 +51,7 @@ hid_t fapl; /* file access property list */ #ifdef USE_PAUSE /* pause the process for a moment to allow debugger to attach if desired. */ -/* Will pause more if greenlight file is not persent but will eventually */ +/* Will pause more if greenlight file is not present but will eventually */ /* continue. */ #include <sys/types.h> #include <sys/stat.h> @@ -341,7 +341,7 @@ main(int argc, char **argv) /* Attempt to turn off atexit post processing so that in case errors * happen during the test and the process is aborted, it will not get - * hang in the atexit post processing in which it may try to make MPI + * hung in the atexit post processing in which it may try to make MPI * calls. By then, MPI calls may not work. */ if (H5dont_atexit() < 0) { diff --git a/testpar/t_bigio.c b/testpar/t_bigio.c index 0c4d125..3a28022 100644 --- a/testpar/t_bigio.c +++ b/testpar/t_bigio.c @@ -1870,7 +1870,7 @@ main(int argc, char **argv) /* Attempt to turn off atexit post processing so that in case errors * happen during the test and the process is aborted, it will not get - * hang in the atexit post processing in which it may try to make MPI + * hung in the atexit post processing in which it may try to make MPI * calls. By then, MPI calls may not work. */ if (H5dont_atexit() < 0) diff --git a/testpar/t_cache.c b/testpar/t_cache.c index 3ba4c79..0d18851 100644 --- a/testpar/t_cache.c +++ b/testpar/t_cache.c @@ -2233,13 +2233,11 @@ datum_serialize(const H5F_t *f, void H5_ATTR_NDEBUG_UNUSED *image_ptr, size_t le assert(f); assert(f->shared); assert(f->shared->cache); - assert(f->shared->cache->magic == H5C__H5C_T_MAGIC); assert(f->shared->cache->aux_ptr); aux_ptr = (H5AC_aux_t *)(f->shared->cache->aux_ptr); assert(aux_ptr); - assert(aux_ptr->magic == H5AC__H5AC_AUX_T_MAGIC); entry_ptr->aux_ptr = aux_ptr; @@ -2463,7 +2461,6 @@ datum_notify(H5C_notify_action_t action, void *thing) } assert(entry_ptr->aux_ptr); - assert(entry_ptr->aux_ptr->magic == H5AC__H5AC_AUX_T_MAGIC); aux_ptr = entry_ptr->aux_ptr; entry_ptr->aux_ptr = NULL; @@ -2826,8 +2823,7 @@ insert_entry(H5C_t *cache_ptr, H5F_t *file_ptr, int32_t idx, unsigned int flags) aux_ptr = ((H5AC_aux_t *)(cache_ptr->aux_ptr)); - if (!((aux_ptr != NULL) && (aux_ptr->magic == H5AC__H5AC_AUX_T_MAGIC) && - (aux_ptr->dirty_bytes == 0))) { + if (!(aux_ptr != NULL && aux_ptr->dirty_bytes == 0)) { nerrors++; if (verbose) { @@ -3420,8 +3416,7 @@ move_entry(H5F_t *file_ptr, int32_t old_idx, int32_t new_idx) aux_ptr = ((H5AC_aux_t *)(file_ptr->shared->cache->aux_ptr)); - if (!((aux_ptr != NULL) && (aux_ptr->magic == H5AC__H5AC_AUX_T_MAGIC) && - (aux_ptr->dirty_bytes == 0))) { + if (!(aux_ptr != NULL && aux_ptr->dirty_bytes == 0)) { nerrors++; if (verbose) { @@ -3638,12 +3633,6 @@ setup_cache_for_test(hid_t *fid_ptr, H5F_t **file_ptr_ptr, H5C_t **cache_ptr_ptr fprintf(stdout, "%d:%s: Can't get cache_ptr.\n", world_mpi_rank, __func__); } } - else if (cache_ptr->magic != H5C__H5C_T_MAGIC) { - nerrors++; - if (verbose) { - fprintf(stdout, "%d:%s: Bad cache_ptr magic.\n", world_mpi_rank, __func__); - } - } else { cache_ptr->ignore_tags = TRUE; *fid_ptr = fid; @@ -3693,14 +3682,6 @@ setup_cache_for_test(hid_t *fid_ptr, H5F_t **file_ptr_ptr, H5C_t **cache_ptr_ptr fprintf(stdout, "%d:%s: cache_ptr->aux_ptr == NULL.\n", world_mpi_rank, __func__); } } - else if (((H5AC_aux_t *)(cache_ptr->aux_ptr))->magic != H5AC__H5AC_AUX_T_MAGIC) { - - nerrors++; - if (verbose) { - fprintf(stdout, "%d:%s: cache_ptr->aux_ptr->magic != H5AC__H5AC_AUX_T_MAGIC.\n", - world_mpi_rank, __func__); - } - } else if (((H5AC_aux_t *)(cache_ptr->aux_ptr))->metadata_write_strategy != metadata_write_strategy) { nerrors++; @@ -6386,7 +6367,7 @@ trace_file_check(int metadata_write_strategy) /* Clean up the trace file */ if (trace_file_ptr != NULL) { - HDfclose(trace_file_ptr); + fclose(trace_file_ptr); trace_file_ptr = NULL; HDremove(trace_file_name); } @@ -6695,7 +6676,7 @@ main(int argc, char **argv) /* Attempt to turn off atexit post processing so that in case errors * happen during the test and the process is aborted, it will not get - * hang in the atexit post processing in which it may try to make MPI + * hung in the atexit post processing in which it may try to make MPI * calls. By then, MPI calls may not work. */ if (H5dont_atexit() < 0) diff --git a/testpar/t_cache_image.c b/testpar/t_cache_image.c index 028752d..8ce5662 100644 --- a/testpar/t_cache_image.c +++ b/testpar/t_cache_image.c @@ -3523,7 +3523,7 @@ main(int argc, char **argv) /* Attempt to turn off atexit post processing so that in case errors * happen during the test and the process is aborted, it will not get - * hang in the atexit post processing in which it may try to make MPI + * hung in the atexit post processing in which it may try to make MPI * calls. By then, MPI calls may not work. */ if (H5dont_atexit() < 0) diff --git a/testpar/t_coll_chunk.c b/testpar/t_coll_chunk.c index 5dd0bb8..fd77988 100644 --- a/testpar/t_coll_chunk.c +++ b/testpar/t_coll_chunk.c @@ -858,7 +858,7 @@ coll_chunktest(const char *filename, int chunk_factor, int select_factor, int ap VRFY((acc_plist >= 0), "MPIO creation property list succeeded"); file = H5Fopen(filename, H5F_ACC_RDONLY, acc_plist); - VRFY((file >= 0), "H5Fcreate succeeded"); + VRFY((file >= 0), "H5Fopen succeeded"); status = H5Pclose(acc_plist); VRFY((status >= 0), ""); diff --git a/testpar/t_file.c b/testpar/t_file.c index 7568ba0..69d0562 100644 --- a/testpar/t_file.c +++ b/testpar/t_file.c @@ -156,7 +156,7 @@ test_page_buffer_access(void) { file_id = H5Fcreate(filename, H5F_ACC_TRUNC, fcpl, fapl); } - H5E_END_TRY; + H5E_END_TRY VRFY((file_id < 0), "H5Fcreate failed"); /* disable collective metadata writes for page buffering to work */ @@ -467,7 +467,6 @@ create_file(const char *filename, hid_t fcpl, hid_t fapl, int metadata_write_str VRFY((f != NULL), ""); cache_ptr = f->shared->cache; - VRFY((cache_ptr->magic == H5C__H5C_T_MAGIC), ""); cache_ptr->ignore_tags = TRUE; H5C_stats__reset(cache_ptr); @@ -634,7 +633,6 @@ open_file(const char *filename, hid_t fapl, int metadata_write_strategy, hsize_t VRFY((f != NULL), ""); cache_ptr = f->shared->cache; - VRFY((cache_ptr->magic == H5C__H5C_T_MAGIC), ""); MPI_Barrier(MPI_COMM_WORLD); @@ -713,7 +711,6 @@ open_file(const char *filename, hid_t fapl, int metadata_write_strategy, hsize_t entry_ptr = cache_ptr->index[i]; while (entry_ptr != NULL) { - assert(entry_ptr->magic == H5C__H5C_CACHE_ENTRY_T_MAGIC); assert(entry_ptr->is_dirty == FALSE); if (!entry_ptr->is_pinned && !entry_ptr->is_protected) { @@ -995,7 +992,7 @@ test_delete(void) { is_hdf5 = H5Fis_accessible(filename, fapl_id); } - H5E_END_TRY; + H5E_END_TRY VRFY((is_hdf5 != SUCCEED), "H5Fis_accessible"); /* Release file-access plist */ diff --git a/testpar/t_filters_parallel.c b/testpar/t_filters_parallel.c index 27b0980..bfe306c 100644 --- a/testpar/t_filters_parallel.c +++ b/testpar/t_filters_parallel.c @@ -18,8 +18,8 @@ #include "t_filters_parallel.h" -const char *FILENAME[] = {"t_filters_parallel", NULL}; -char filenames[1][256]; +static const char *FILENAME[] = {"t_filters_parallel", NULL}; +char filenames[1][256]; static MPI_Comm comm = MPI_COMM_WORLD; static MPI_Info info = MPI_INFO_NULL; @@ -3420,7 +3420,7 @@ test_write_cmpd_filtered_dataset_type_conversion_unshared(const char *parent_gro { VRFY((H5Dwrite(dset_id, memtype, memspace, filespace, dxpl_id, data) < 0), "Dataset write succeeded"); } - H5E_END_TRY; + H5E_END_TRY /* Verify space allocation status */ verify_space_alloc_status(dset_id, plist_id, NO_CHUNKS_WRITTEN); @@ -3617,7 +3617,7 @@ test_write_cmpd_filtered_dataset_type_conversion_shared(const char *parent_group { VRFY((H5Dwrite(dset_id, memtype, memspace, filespace, dxpl_id, data) < 0), "Dataset write succeeded"); } - H5E_END_TRY; + H5E_END_TRY /* Verify space allocation status */ verify_space_alloc_status(dset_id, plist_id, NO_CHUNKS_WRITTEN); @@ -8213,7 +8213,7 @@ test_fill_value_undefined(const char *parent_group, H5Z_filter_t filter_id, hid_ VRFY((H5Dread(dset_id, HDF5_DATATYPE_NAME, H5S_ALL, H5S_ALL, dxpl_id, read_buf) < 0), "Dataset read succeeded"); } - H5E_END_TRY; + H5E_END_TRY } /* diff --git a/testpar/t_init_term.c b/testpar/t_init_term.c index a01b693..929bb59 100644 --- a/testpar/t_init_term.c +++ b/testpar/t_init_term.c @@ -19,7 +19,7 @@ int nerrors = 0; /* errors count */ -const char *FILENAME[] = {"after_mpi_fin", NULL}; +static const char *FILENAME[] = {"after_mpi_fin", NULL}; int main(int argc, char **argv) diff --git a/testpar/t_mpi.c b/testpar/t_mpi.c index 48d0cc1..70a76ec 100644 --- a/testpar/t_mpi.c +++ b/testpar/t_mpi.c @@ -455,7 +455,7 @@ test_mpio_1wMr(char *filename, int special_request) /* show the hostname so that we can tell where the processes are running */ if (VERBOSE_DEF) { #ifdef H5_HAVE_GETHOSTNAME - if (HDgethostname(hostname, sizeof(hostname)) < 0) { + if (gethostname(hostname, sizeof(hostname)) < 0) { printf("gethostname failed\n"); hostname[0] = '\0'; } diff --git a/testpar/t_pflush1.c b/testpar/t_pflush1.c index bfebbb9..7d8d7fa 100644 --- a/testpar/t_pflush1.c +++ b/testpar/t_pflush1.c @@ -19,7 +19,7 @@ */ #include "h5test.h" -const char *FILENAME[] = {"flush", "noflush", NULL}; +static const char *FILENAME[] = {"flush", "noflush", NULL}; static int *data_g = NULL; diff --git a/testpar/t_pflush2.c b/testpar/t_pflush2.c index 68f756d..81ed2bd 100644 --- a/testpar/t_pflush2.c +++ b/testpar/t_pflush2.c @@ -20,7 +20,7 @@ #include "h5test.h" -const char *FILENAME[] = {"flush", "noflush", NULL}; +static const char *FILENAME[] = {"flush", "noflush", NULL}; static int *data_g = NULL; @@ -112,7 +112,7 @@ error: H5Sclose(sid); H5Gclose(gid); } - H5E_END_TRY; + H5E_END_TRY return FAIL; } /* end check_test_file() */ diff --git a/testpar/t_prestart.c b/testpar/t_prestart.c index d69f17b..4fd7b5a 100644 --- a/testpar/t_prestart.c +++ b/testpar/t_prestart.c @@ -19,7 +19,7 @@ int nerrors = 0; /* errors count */ -const char *FILENAME[] = {"shutdown", NULL}; +static const char *FILENAME[] = {"shutdown", NULL}; int main(int argc, char **argv) diff --git a/testpar/t_pshutdown.c b/testpar/t_pshutdown.c index 9a2e0a3..b0b5da7 100644 --- a/testpar/t_pshutdown.c +++ b/testpar/t_pshutdown.c @@ -23,7 +23,7 @@ int nerrors = 0; /* errors count */ -const char *FILENAME[] = {"shutdown", NULL}; +static const char *FILENAME[] = {"shutdown", NULL}; int main(int argc, char **argv) diff --git a/testpar/t_shapesame.c b/testpar/t_shapesame.c index dc60e51..d9cd20c 100644 --- a/testpar/t_shapesame.c +++ b/testpar/t_shapesame.c @@ -3941,7 +3941,7 @@ hid_t fapl; /* file access property list */ #ifdef USE_PAUSE /* pause the process for a moment to allow debugger to attach if desired. */ -/* Will pause more if greenlight file is not persent but will eventually */ +/* Will pause more if greenlight file is not present but will eventually */ /* continue. */ #include <sys/types.h> #include <sys/stat.h> @@ -4272,7 +4272,7 @@ main(int argc, char **argv) /* Attempt to turn off atexit post processing so that in case errors * happen during the test and the process is aborted, it will not get - * hang in the atexit post processing in which it may try to make MPI + * hung in the atexit post processing in which it may try to make MPI * calls. By then, MPI calls may not work. */ if (H5dont_atexit() < 0) { diff --git a/testpar/t_vfd.c b/testpar/t_vfd.c index 6e6329c..827faf4 100644 --- a/testpar/t_vfd.c +++ b/testpar/t_vfd.c @@ -4086,7 +4086,7 @@ main(int argc, char **argv) int provided = 0; #endif int mpi_size; - int mpi_rank; + int mpi_rank = 0; #ifdef H5_HAVE_SUBFILING_VFD if (MPI_SUCCESS != MPI_Init_thread(&argc, &argv, required, &provided)) { diff --git a/testpar/testpar.h b/testpar/testpar.h index 58bcab4..ca0f608 100644 --- a/testpar/testpar.h +++ b/testpar/testpar.h @@ -32,7 +32,7 @@ #define MESG(mesg) \ do { \ if (VERBOSE_MED && *mesg != '\0') { \ - HDprintf("%s\n", mesg); \ + printf("%s\n", mesg); \ } \ } while (0) @@ -52,13 +52,13 @@ MESG(mesg); \ } \ else { \ - HDprintf("Proc %d: ", rankvar); \ - HDprintf("*** Parallel ERROR ***\n"); \ - HDprintf(" VRFY (%s) failed at line %4d in %s\n", mesg, (int)__LINE__, __FILE__); \ + printf("Proc %d: ", rankvar); \ + printf("*** Parallel ERROR ***\n"); \ + printf(" VRFY (%s) failed at line %4d in %s\n", mesg, (int)__LINE__, __FILE__); \ ++nerrors; \ fflush(stdout); \ if (!VERBOSE_MED) { \ - HDprintf("aborting MPI processes\n"); \ + printf("aborting MPI processes\n"); \ MPI_Abort(MPI_COMM_WORLD, 1); \ } \ } \ @@ -78,9 +78,9 @@ MESG(mesg); \ } \ else { \ - HDprintf("Proc %d: ", mpi_rank); \ - HDprintf("*** PHDF5 REMARK (not an error) ***\n"); \ - HDprintf(" Condition (%s) failed at line %4d in %s\n", mesg, (int)__LINE__, __FILE__); \ + printf("Proc %d: ", mpi_rank); \ + printf("*** PHDF5 REMARK (not an error) ***\n"); \ + printf(" Condition (%s) failed at line %4d in %s\n", mesg, (int)__LINE__, __FILE__); \ fflush(stdout); \ } \ } while (0) @@ -88,10 +88,10 @@ #define MPI_BANNER(mesg) \ do { \ if (VERBOSE_MED || MAINPROCESS) { \ - HDprintf("--------------------------------\n"); \ - HDprintf("Proc %d: ", mpi_rank); \ - HDprintf("*** %s\n", mesg); \ - HDprintf("--------------------------------\n"); \ + printf("--------------------------------\n"); \ + printf("Proc %d: ", mpi_rank); \ + printf("*** %s\n", mesg); \ + printf("--------------------------------\n"); \ } \ } while (0) diff --git a/testpar/testphdf5.c b/testpar/testphdf5.c index b35a758..a389d0c 100644 --- a/testpar/testphdf5.c +++ b/testpar/testphdf5.c @@ -47,7 +47,7 @@ hid_t fapl; /* file access property list */ #ifdef USE_PAUSE /* pause the process for a moment to allow debugger to attach if desired. */ -/* Will pause more if greenlight file is not persent but will eventually */ +/* Will pause more if greenlight file is not present but will eventually */ /* continue. */ #include <sys/types.h> #include <sys/stat.h> @@ -256,7 +256,7 @@ create_faccess_plist(MPI_Comm comm, MPI_Info info, int l_facc_type) MPI_Comm_rank(MPI_COMM_WORLD, &mpi_rank); ret_pl = H5Pcreate(H5P_FILE_ACCESS); - VRFY((ret_pl >= 0), "H5P_FILE_ACCESS"); + VRFY((ret_pl >= 0), "H5Pcreate succeeded"); if (l_facc_type == FACC_DEFAULT) return (ret_pl); @@ -264,11 +264,11 @@ create_faccess_plist(MPI_Comm comm, MPI_Info info, int l_facc_type) if (l_facc_type == FACC_MPIO) { /* set Parallel access with communicator */ ret = H5Pset_fapl_mpio(ret_pl, comm, info); - VRFY((ret >= 0), ""); + VRFY((ret >= 0), "H5Pset_fapl_mpio succeeded"); ret = H5Pset_all_coll_metadata_ops(ret_pl, TRUE); - VRFY((ret >= 0), ""); + VRFY((ret >= 0), "H5Pset_all_coll_metadata_ops succeeded"); ret = H5Pset_coll_metadata_write(ret_pl, TRUE); - VRFY((ret >= 0), ""); + VRFY((ret >= 0), "H5Pset_coll_metadata_write succeeded"); return (ret_pl); } @@ -276,14 +276,14 @@ create_faccess_plist(MPI_Comm comm, MPI_Info info, int l_facc_type) hid_t mpio_pl; mpio_pl = H5Pcreate(H5P_FILE_ACCESS); - VRFY((mpio_pl >= 0), ""); + VRFY((mpio_pl >= 0), "H5Pcreate succeeded"); /* set Parallel access with communicator */ ret = H5Pset_fapl_mpio(mpio_pl, comm, info); - VRFY((ret >= 0), ""); + VRFY((ret >= 0), "H5Pset_fapl_mpio succeeded"); /* setup file access template */ ret_pl = H5Pcreate(H5P_FILE_ACCESS); - VRFY((ret_pl >= 0), ""); + VRFY((ret_pl >= 0), "H5Pcreate succeeded"); /* set Parallel access with communicator */ ret = H5Pset_fapl_split(ret_pl, ".meta", mpio_pl, ".raw", mpio_pl); VRFY((ret >= 0), "H5Pset_fapl_split succeeded"); @@ -325,7 +325,7 @@ main(int argc, char **argv) /* Attempt to turn off atexit post processing so that in case errors * happen during the test and the process is aborted, it will not get - * hang in the atexit post processing in which it may try to make MPI + * hung in the atexit post processing in which it may try to make MPI * calls. By then, MPI calls may not work. */ if (H5dont_atexit() < 0) { |