summaryrefslogtreecommitdiffstats
path: root/testpar
diff options
context:
space:
mode:
authorDavid Young <dyoung@hdfgroup.org>2020-01-29 17:43:55 (GMT)
committerDavid Young <dyoung@hdfgroup.org>2020-05-20 14:31:53 (GMT)
commit2360f6e64417b95c00ee683b5e7edd45966d9663 (patch)
treeee9054858f7e2b085c13e3e30f820bb6d2516f45 /testpar
parentcfcac15f030734eca087e0116e1ca5813da50f50 (diff)
downloadhdf5-2360f6e64417b95c00ee683b5e7edd45966d9663.zip
hdf5-2360f6e64417b95c00ee683b5e7edd45966d9663.tar.gz
hdf5-2360f6e64417b95c00ee683b5e7edd45966d9663.tar.bz2
testpar/t_2Gio.c: Fix a typo that I think was introduced by a
previous warnings PR. An array element was assigned to itself---shape[2]Â =Â shape[2];---instead of being assigned to chunk[2]. fortran/src/H5Pf.c: move conditional compilation controlled by H5_NO_DEPRECATED_SYMBOLS outside of a function for readability. fortran/src/H5match_types.c: put a variable's declaration under the same conditional compilation (H5_FORTRAN_HAVE_C_LONG_DOUBLE) as its use. For now, skip compilation of some unused debug dump routines in the JNI. While I'm in the JNI, delete a set-but-unused variable. src/H5Z.c: condition a variable declaration on H5_NO_DEPRECATED_SYMBOLS so that it's not declared but unused or vice versa. test/cache_common.h: add an #include in to get some symbols we need to avoid implicit declaration warnings. test/dsets.c: use a more conventional conditional-compilation syntax. test/dt_arith.c, test/fillval.c: initialize a bunch of uninitialized variables before use. test/vfd.c: pass the expected type of `void **` to posix_memalign(3) instead of `int **`. testpar/t_bigio.c: explicitly compare with 0 instead of using ! when "equal to 0?" is the question not "is false?" Repair some indentation while I'm here. testpar/testpar.h: repair misaligned line-continuation backslashes in a macro that probably should be a function so that we don't have to fiddle with the line continuation to begin with. tools/src/h5repack/h5repack_main.c: fix some compiler fussing about enums. tools/test/perform/pio_engine.c: the compiler fusses if you cast a function call returning double directly to off_t. It's ok if you cast a variable that's a double to off_t, however. Write and use a new function, sqrto(), to avoid the cast warnings.
Diffstat (limited to 'testpar')
-rw-r--r--testpar/t_2Gio.c2
-rw-r--r--testpar/t_bigio.c4
-rw-r--r--testpar/testpar.h4
3 files changed, 5 insertions, 5 deletions
diff --git a/testpar/t_2Gio.c b/testpar/t_2Gio.c
index 357050e..ee70eb5 100644
--- a/testpar/t_2Gio.c
+++ b/testpar/t_2Gio.c
@@ -625,7 +625,7 @@ static int MpioTest2G( MPI_Comm comm )
VRFY((dcpl_id >= 0), "H5P_DATASET_CREATE");
chunk[0] = 4;
chunk[1] = shape[1];
- shape[2] = shape[2];
+ chunk[2] = shape[2];
status = H5Pset_chunk(dcpl_id, 3, chunk);
VRFY((status >= 0), "H5Pset_chunk succeeded");
diff --git a/testpar/t_bigio.c b/testpar/t_bigio.c
index ada832c..f86852a 100644
--- a/testpar/t_bigio.c
+++ b/testpar/t_bigio.c
@@ -15,7 +15,7 @@ const char *FILENAME[3]={ "bigio_test.h5",
/* Define some handy debugging shorthands, routines, ... */
/* debugging tools */
-#define MAIN_PROCESS (!mpi_rank_g) /* define process 0 as main process */
+#define MAIN_PROCESS (mpi_rank_g == 0) /* define process 0 as main process */
/* Constants definitions */
#define RANK 2
@@ -1131,7 +1131,7 @@ single_rank_independent_io(void)
void *data = NULL;
fapl_id = H5Pcreate(H5P_FILE_ACCESS);
- VRFY_G((fapl_id >= 0), "H5P_FILE_ACCESS");
+ VRFY_G((fapl_id >= 0), "H5P_FILE_ACCESS");
H5Pset_fapl_mpio(fapl_id, MPI_COMM_SELF, MPI_INFO_NULL);
file_id = H5Fcreate(FILENAME[1], H5F_ACC_TRUNC, H5P_DEFAULT, fapl_id);
diff --git a/testpar/testpar.h b/testpar/testpar.h
index e3d68e0..2c1bce2 100644
--- a/testpar/testpar.h
+++ b/testpar/testpar.h
@@ -44,12 +44,12 @@
* This will allow program to continue and can be used for debugging.
* (The "do {...} while(0)" is to group all the statements as one unit.)
*/
-#define VRFY_IMPL(val, mesg, rankvar) do { \
+#define VRFY_IMPL(val, mesg, rankvar) do { \
if (val) { \
MESG(mesg); \
} \
else { \
- HDprintf("Proc %d: ", rankvar); \
+ HDprintf("Proc %d: ", rankvar); \
HDprintf("*** Parallel ERROR ***\n"); \
HDprintf(" VRFY (%s) failed at line %4d in %s\n", \
mesg, (int)__LINE__, __FILE__); \