summaryrefslogtreecommitdiffstats
path: root/tools/h5diff
diff options
context:
space:
mode:
authorAlbert Cheng <acheng@hdfgroup.org>2005-08-17 19:21:36 (GMT)
committerAlbert Cheng <acheng@hdfgroup.org>2005-08-17 19:21:36 (GMT)
commit7bbea1371134d93939225593a0a730db9b8e9c7b (patch)
tree1c193c9321b725be95a35f412f4209a3cb0b1da8 /tools/h5diff
parent918c992dea6a975193f2f3fa1ced9f1f907c4aff (diff)
downloadhdf5-7bbea1371134d93939225593a0a730db9b8e9c7b.zip
hdf5-7bbea1371134d93939225593a0a730db9b8e9c7b.tar.gz
hdf5-7bbea1371134d93939225593a0a730db9b8e9c7b.tar.bz2
[svn-r11259] Purpose:
Bug fix Description: ph5diff had been hanging in Tflops. Found out that vsnprintf ph5diff uses was a local coded that did not limit printing according to the size argument. That resulted in buffer overflow and other problems. Solution: Added some sort of size checking in the home-grown vsnprintf and had ph5diff checked for error return of vsnprintf. Leon also revamped the ph5diff manager's way of handling communications with the workers. That eliminated all but the last case of hanging. Platforms tested: Tflops. Misc. update:
Diffstat (limited to 'tools/h5diff')
-rw-r--r--tools/h5diff/ph5diff_main.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/tools/h5diff/ph5diff_main.c b/tools/h5diff/ph5diff_main.c
index 94773c8..c469a4b 100644
--- a/tools/h5diff/ph5diff_main.c
+++ b/tools/h5diff/ph5diff_main.c
@@ -177,7 +177,6 @@ ph5diff_worker(int nID)
if(outBuffOffset>0)
{
MPI_Send(NULL, 0, MPI_BYTE, 0, MPI_TAG_TOK_REQUEST, MPI_COMM_WORLD);
-
/*Wait for print token. */
MPI_Recv(NULL, 0, MPI_BYTE, 0, MPI_TAG_PRINT_TOK, MPI_COMM_WORLD, &Status);