diff options
| author | Mike McGreevy <mamcgree@hdfgroup.org> | 2009-07-23 20:04:18 (GMT) |
|---|---|---|
| committer | Mike McGreevy <mamcgree@hdfgroup.org> | 2009-07-23 20:04:18 (GMT) |
| commit | 6a00b1b6ffe86872088f92f38c98ccd6599d3c6c (patch) | |
| tree | bab50938ed33e313d37c381b1769ff2a95f15502 /tools/h5dump | |
| parent | 3a8bce5cb845685b9cfb7267ad6addc155dea567 (diff) | |
| download | hdf5-6a00b1b6ffe86872088f92f38c98ccd6599d3c6c.zip hdf5-6a00b1b6ffe86872088f92f38c98ccd6599d3c6c.tar.gz hdf5-6a00b1b6ffe86872088f92f38c98ccd6599d3c6c.tar.bz2 | |
[svn-r17228] Purpose:
Fix BZ #1583
Description:
The --enable-static-exec flag was broken. Configure was adding the
-all-static linker flag to an environment variable which was subsequently
never used. (looks like it was used in 1.6 Makefile.ins, but never
moved to 1.8's Makefile.ams when we added automake support).
To fix, I've added this environment varibale to the link lines of all the
tools. Now, when --enable-static-exec is invoked, it will correctly
generate statically linked executables in the installed bin directory.
Tested:
I've tested manually to ensure that the generated execs are static when
the flag is used and dynamic when not. I've also tested when szip is
used, as this was a use case mentioned in the bug report.
Also: ran full tests with make check on jam and smirom for good measure.
Diffstat (limited to 'tools/h5dump')
| -rw-r--r-- | tools/h5dump/Makefile.am | 3 | ||||
| -rw-r--r-- | tools/h5dump/Makefile.in | 8 |
2 files changed, 10 insertions, 1 deletions
diff --git a/tools/h5dump/Makefile.am b/tools/h5dump/Makefile.am index 599c203..992586b 100644 --- a/tools/h5dump/Makefile.am +++ b/tools/h5dump/Makefile.am @@ -34,6 +34,9 @@ SCRIPT_DEPEND=h5dump$(EXEEXT) # Our main target, the h5dump tool. bin_PROGRAMS=h5dump +# Add h5dump specific linker flags here +h5dump_LDFLAGS = $(LT_STATIC_EXEC) + # All the programs depend on the hdf5 and h5tools libraries LDADD=$(LIBH5TOOLS) $(LIBHDF5) diff --git a/tools/h5dump/Makefile.in b/tools/h5dump/Makefile.in index 0d77850..3da4333 100644 --- a/tools/h5dump/Makefile.in +++ b/tools/h5dump/Makefile.in @@ -76,6 +76,9 @@ h5dump_SOURCES = h5dump.c h5dump_OBJECTS = h5dump.$(OBJEXT) h5dump_LDADD = $(LDADD) h5dump_DEPENDENCIES = $(LIBH5TOOLS) $(LIBHDF5) +h5dump_LINK = $(LIBTOOL) --tag=CC $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) \ + --mode=link $(CCLD) $(AM_CFLAGS) $(CFLAGS) $(h5dump_LDFLAGS) \ + $(LDFLAGS) -o $@ h5dumpgentest_SOURCES = h5dumpgentest.c h5dumpgentest_OBJECTS = h5dumpgentest.$(OBJEXT) h5dumpgentest_LDADD = $(LDADD) @@ -358,6 +361,9 @@ TEST_SCRIPT = testh5dump.sh testh5dumpxml.sh check_SCRIPTS = $(TEST_SCRIPT) SCRIPT_DEPEND = h5dump$(EXEEXT) +# Add h5dump specific linker flags here +h5dump_LDFLAGS = $(LT_STATIC_EXEC) + # All the programs depend on the hdf5 and h5tools libraries LDADD = $(LIBH5TOOLS) $(LIBHDF5) DISTCLEANFILES = testh5dump.sh @@ -454,7 +460,7 @@ binread$(EXEEXT): $(binread_OBJECTS) $(binread_DEPENDENCIES) $(LINK) $(binread_OBJECTS) $(binread_LDADD) $(LIBS) h5dump$(EXEEXT): $(h5dump_OBJECTS) $(h5dump_DEPENDENCIES) @rm -f h5dump$(EXEEXT) - $(LINK) $(h5dump_OBJECTS) $(h5dump_LDADD) $(LIBS) + $(h5dump_LINK) $(h5dump_OBJECTS) $(h5dump_LDADD) $(LIBS) h5dumpgentest$(EXEEXT): $(h5dumpgentest_OBJECTS) $(h5dumpgentest_DEPENDENCIES) @rm -f h5dumpgentest$(EXEEXT) $(LINK) $(h5dumpgentest_OBJECTS) $(h5dumpgentest_LDADD) $(LIBS) |