diff options
author | Albert Cheng <acheng@hdfgroup.org> | 2010-06-08 18:22:11 (GMT) |
---|---|---|
committer | Albert Cheng <acheng@hdfgroup.org> | 2010-06-08 18:22:11 (GMT) |
commit | ed9a9f8c5077ab4ed9526ae97e2c5788ff7cf994 (patch) | |
tree | cdf98f224168356d4461c96813736fcb4dd41ff9 /tools/h5ls | |
parent | 21d186a8e7f89a065f47d6f515da4ef1495e29b7 (diff) | |
download | hdf5-ed9a9f8c5077ab4ed9526ae97e2c5788ff7cf994.zip hdf5-ed9a9f8c5077ab4ed9526ae97e2c5788ff7cf994.tar.gz hdf5-ed9a9f8c5077ab4ed9526ae97e2c5788ff7cf994.tar.bz2 |
[svn-r18985] Test feature: (bugs 1919)
Problem: some launching command like yod (and sometimes mpirun), do not pass
back the exit code of the executables back to the shell. It always returns 0
if it can launch the executable. This cause tests that expect non-zero exit
code to fail incorrectly.
Short term Solution:
Added the feature that if $RUNSERIAL_NOEXITCODE is defined, do not
test conditions that rely on non-zero exit code.
Tests:
dove-linux using RUNSERIAL=thgyod to see the failures and using
$RUNSERIAL_NOEXITCODE=yes to bypass the errors.
Also h5committested.
Diffstat (limited to 'tools/h5ls')
-rw-r--r-- | tools/h5ls/testh5ls.sh.in | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/tools/h5ls/testh5ls.sh.in b/tools/h5ls/testh5ls.sh.in index 970646d..7f07898 100644 --- a/tools/h5ls/testh5ls.sh.in +++ b/tools/h5ls/testh5ls.sh.in @@ -30,6 +30,7 @@ WORDS_BIGENDIAN="@WORDS_BIGENDIAN@" nerrors=0 verbose=yes +h5haveexitcode=yes # default is yes # The build (current) directory might be different than the source directory. if test -z "$srcdir"; then @@ -37,6 +38,13 @@ if test -z "$srcdir"; then fi test -d ../testfiles || mkdir ../testfiles +# RUNSERIAL is used. Check if it can return exit code from executalbe correctly. +if [ -n "$RUNSERIAL_NOEXITCODE" ]; then + echo "***Warning*** Serial Exit Code is not passed back to shell corretly." + echo "***Warning*** Exit code checking is skipped." + h5haveexitcode=no +fi + # Print a line-line message left justified in a field of 70 characters # beginning with the word "Testing". TESTING() { @@ -74,7 +82,7 @@ TOOLTEST() { exitcode=$? cat $actual_err >> $actual - if [ $exitcode -ne $retvalexpect ]; then + if [ $h5haveexitcode = 'yes' -a $exitcode -ne $retvalexpect ]; then echo "*FAILED*" nerrors="`expr $nerrors + 1`" if [ yes = "$verbose" ]; then |