[svn-r9727] Purpose:

    Bug Fix/Code Cleanup/Doc Cleanup/Optimization/Branch Sync :-)

Description:
    Generally speaking, this is the "signed->unsigned" change to selections.
However, in the process of merging code back, things got stickier and stickier
until I ended up doing a big "sync the two branches up" operation.  So... I
brought back all the "infrastructure" fixes from the development branch to the
release branch (which I think were actually making some improvement in
performance) as well as fixed several bugs which had been fixed in one branch,
but not the other.

    I've also tagged the repository before making this checkin with the label
"before_signed_unsigned_changes".

Platforms tested:
    FreeBSD 4.10 (sleipnir) w/parallel & fphdf5
    FreeBSD 4.10 (sleipnir) w/threadsafe
    FreeBSD 4.10 (sleipnir) w/backward compatibility
    Solaris 2.7 (arabica) w/"purify options"
    Solaris 2.8 (sol) w/FORTRAN & C++
    AIX 5.x (copper) w/parallel & FORTRAN
    IRIX64 6.5 (modi4) w/FORTRAN
    Linux 2.4 (heping) w/FORTRAN & C++


Misc. update:

1 files changed, 12 insertions, 17 deletions

diff --git a/tools/h5repack/h5repack_copy.c b/tools/h5repack/h5repack_copy.c
index 9a73919..42b6701 100644
--- a/tools/h5repack/h5repack_copy.c
+++ b/tools/h5repack/h5repack_copy.c
@@ -142,7 +142,7 @@ int copy_objects(const char* fnamein,
                  pack_opt_t *options)
 {
  hid_t         fidin; 
- hid_t         fidout; 
+ hid_t         fidout=(-1); 
  trav_table_t  *travt=NULL;
 
 /*-------------------------------------------------------------------------
@@ -215,9 +215,6 @@ out:
  return -1;
 }
 
-
-
-
 /*-------------------------------------------------------------------------
  * Function: do_copy_objects
  *
@@ -239,17 +236,17 @@ int do_copy_objects(hid_t fidin,
                     trav_table_t *travt,
                     pack_opt_t *options) /* repack options */
 {
- hid_t     grp_in;       /* group ID */ 
- hid_t     grp_out;      /* group ID */ 
- hid_t     dset_in;      /* read dataset ID */ 
- hid_t     dset_out;     /* write dataset ID */ 
- hid_t     type_in;      /* named type ID */ 
- hid_t     type_out;     /* named type ID */ 
- hid_t     dcpl_id;      /* dataset creation property list ID */ 
-	hid_t     dcpl_out;     /* dataset creation property list ID */ 
- hid_t     space_id;     /* space ID */ 
- hid_t     ftype_id;     /* file data type ID */ 
- hid_t     mtype_id;     /* memory data type ID */
+ hid_t     grp_in=(-1);       /* group ID */ 
+ hid_t     grp_out=(-1);      /* group ID */ 
+ hid_t     dset_in=(-1);      /* read dataset ID */ 
+ hid_t     dset_out=(-1);     /* write dataset ID */ 
+ hid_t     type_in=(-1);      /* named type ID */ 
+ hid_t     type_out=(-1);     /* named type ID */ 
+ hid_t     dcpl_id=(-1);      /* dataset creation property list ID */ 
+ hid_t     dcpl_out=(-1);     /* dataset creation property list ID */ 
+ hid_t     space_id=(-1);     /* space ID */ 
+ hid_t     ftype_id=(-1);     /* file data type ID */ 
+ hid_t     mtype_id=(-1);     /* memory data type ID */
  size_t    msize;        /* memory size of memory type */
  void      *buf=NULL;    /* data buffer */
  hsize_t   nelmts;       /* number of elements in dataset */
@@ -258,7 +255,6 @@ int do_copy_objects(hid_t fidin,
  hsize_t   dsize_in;     /* input dataset size before filter */
  int       next;         /* external files */
  int       i, j;
- int       wrote=0;
 
 /*-------------------------------------------------------------------------
  * copy the suppplied object list
@@ -418,7 +414,6 @@ int do_copy_objects(hid_t fidin,
     if (dsize_in && nelmts) {
      if (H5Dwrite(dset_out,mtype_id,H5S_ALL,H5S_ALL,H5P_DEFAULT,buf)<0)
       goto error;
-     wrote=1;
     }
     /*-------------------------------------------------------------------------
      * copy attrs