[svn-r8218] Purpose:

bug fix in H5Zshuffle.c
add more tests to h5repack that exposed the bug

Description:
when creating a dataset with the shuffle filter and duplicating it in a new dataset (file)
the call to H5Z_set_local_shuffle failed. this is because the value of cd_nelmts of the filter
structure is set to 1 (H5Z_SHUFFLE_TOTAL_NPARMS) when the original dataset is created, but when
the new dataset is created there is a checking instruction that fails if the value of
cd_nelmts is not 0 (its original value, H5Z_SHUFFLE_USER_NPARMS)

Solution:
just remove that check condition, since the value of cd_nelmts is not used anyway.
if we decide that the value of cd_nelmts is necessary, then the H5O_pline_copy function
must be changed to update this value (a different update for each filter)

Platforms tested:
linux
solaris
AIX

Misc. update:

1 files changed, 17 insertions, 21 deletions

diff --git a/tools/h5repack/testh5repack_make.c b/tools/h5repack/testh5repack_make.c
index e5aa5ee..f625d2a 100644
--- a/tools/h5repack/testh5repack_make.c
+++ b/tools/h5repack/testh5repack_make.c
@@ -36,52 +36,48 @@ int make_testfiles(void)
 
  TESTING("    generating datasets");
 
- /* create a file for general copy test */
+/*-------------------------------------------------------------------------
+ * create a file for general copy test 
+ *-------------------------------------------------------------------------
+ */
  if((loc_id = H5Fcreate(FNAME1,H5F_ACC_TRUNC,H5P_DEFAULT,H5P_DEFAULT))<0)
   return -1;
- 
  if (make_all_objects(loc_id)<0)
   goto out;
-
   /* close */
  if(H5Fclose(loc_id)<0)
   return -1;
 
- /* create a file for attributes copy test */
+/*-------------------------------------------------------------------------
+ * create a file for attributes copy test
+ *-------------------------------------------------------------------------
+ */
  if((loc_id = H5Fcreate(FNAME2,H5F_ACC_TRUNC,H5P_DEFAULT,H5P_DEFAULT))<0)
   return -1;
-
  if (make_attributes(loc_id)<0)
   goto out;
-
   /* close */
  if(H5Fclose(loc_id)<0)
   return -1;
-
- /* create a file for special items test */
+/*-------------------------------------------------------------------------
+ * create a file for special items test
+ *-------------------------------------------------------------------------
+ */
  if((loc_id = H5Fcreate(FNAME3,H5F_ACC_TRUNC,H5P_DEFAULT,H5P_DEFAULT))<0)
   return -1;
-
  if (make_special_objects(loc_id)<0)
   goto out;
-
  /* close */
  if(H5Fclose(loc_id)<0)
   return -1;
-
- /* create a file for the filters test */
+/*-------------------------------------------------------------------------
+ * create a file for the filters test
+ *-------------------------------------------------------------------------
+ */
  if((loc_id = H5Fcreate(FNAME4,H5F_ACC_TRUNC,H5P_DEFAULT,H5P_DEFAULT))<0)
   return -1;
-
- if (make_nofilters(loc_id)<0)
-  goto out;
-
- if (make_deflate(loc_id)<0)
+ if (make_filters(loc_id)<0)
   goto out;
-
- if (make_szip(loc_id)<0)
-  goto out;
-
  /* close */
  if(H5Fclose(loc_id)<0)
   return -1;