diff options
| author | Mike McGreevy <mamcgree@hdfgroup.org> | 2009-07-23 20:04:18 (GMT) |
|---|---|---|
| committer | Mike McGreevy <mamcgree@hdfgroup.org> | 2009-07-23 20:04:18 (GMT) |
| commit | 6a00b1b6ffe86872088f92f38c98ccd6599d3c6c (patch) | |
| tree | bab50938ed33e313d37c381b1769ff2a95f15502 /tools/h5stat | |
| parent | 3a8bce5cb845685b9cfb7267ad6addc155dea567 (diff) | |
| download | hdf5-6a00b1b6ffe86872088f92f38c98ccd6599d3c6c.zip hdf5-6a00b1b6ffe86872088f92f38c98ccd6599d3c6c.tar.gz hdf5-6a00b1b6ffe86872088f92f38c98ccd6599d3c6c.tar.bz2 | |
[svn-r17228] Purpose:
Fix BZ #1583
Description:
The --enable-static-exec flag was broken. Configure was adding the
-all-static linker flag to an environment variable which was subsequently
never used. (looks like it was used in 1.6 Makefile.ins, but never
moved to 1.8's Makefile.ams when we added automake support).
To fix, I've added this environment varibale to the link lines of all the
tools. Now, when --enable-static-exec is invoked, it will correctly
generate statically linked executables in the installed bin directory.
Tested:
I've tested manually to ensure that the generated execs are static when
the flag is used and dynamic when not. I've also tested when szip is
used, as this was a use case mentioned in the bug report.
Also: ran full tests with make check on jam and smirom for good measure.
Diffstat (limited to 'tools/h5stat')
| -rw-r--r-- | tools/h5stat/Makefile.am | 3 | ||||
| -rw-r--r-- | tools/h5stat/Makefile.in | 8 |
2 files changed, 10 insertions, 1 deletions
diff --git a/tools/h5stat/Makefile.am b/tools/h5stat/Makefile.am index b1c2024..a14172d 100644 --- a/tools/h5stat/Makefile.am +++ b/tools/h5stat/Makefile.am @@ -35,6 +35,9 @@ SCRIPT_DEPEND=h5stat$(EXEEXT) bin_PROGRAMS=h5stat bin_SCRIPTS= +# Add h5stat specific linker flags here +h5stat_LDFLAGS = $(LT_STATIC_EXEC) + # Tell automake to clean h5redeploy script CLEANFILES= diff --git a/tools/h5stat/Makefile.in b/tools/h5stat/Makefile.in index 48957c9..1a0848d 100644 --- a/tools/h5stat/Makefile.in +++ b/tools/h5stat/Makefile.in @@ -72,6 +72,9 @@ h5stat_SOURCES = h5stat.c h5stat_OBJECTS = h5stat.$(OBJEXT) h5stat_LDADD = $(LDADD) h5stat_DEPENDENCIES = $(LIBH5TOOLS) $(LIBHDF5) +h5stat_LINK = $(LIBTOOL) --tag=CC $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) \ + --mode=link $(CCLD) $(AM_CFLAGS) $(CFLAGS) $(h5stat_LDFLAGS) \ + $(LDFLAGS) -o $@ h5stat_gentest_SOURCES = h5stat_gentest.c h5stat_gentest_OBJECTS = h5stat_gentest.$(OBJEXT) h5stat_gentest_LDADD = $(LDADD) @@ -359,6 +362,9 @@ check_SCRIPTS = $(TEST_SCRIPT) SCRIPT_DEPEND = h5stat$(EXEEXT) bin_SCRIPTS = +# Add h5stat specific linker flags here +h5stat_LDFLAGS = $(LT_STATIC_EXEC) + # Tell automake to clean h5redeploy script CLEANFILES = @@ -455,7 +461,7 @@ clean-checkPROGRAMS: done h5stat$(EXEEXT): $(h5stat_OBJECTS) $(h5stat_DEPENDENCIES) @rm -f h5stat$(EXEEXT) - $(LINK) $(h5stat_OBJECTS) $(h5stat_LDADD) $(LIBS) + $(h5stat_LINK) $(h5stat_OBJECTS) $(h5stat_LDADD) $(LIBS) h5stat_gentest$(EXEEXT): $(h5stat_gentest_OBJECTS) $(h5stat_gentest_DEPENDENCIES) @rm -f h5stat_gentest$(EXEEXT) $(LINK) $(h5stat_gentest_OBJECTS) $(h5stat_gentest_LDADD) $(LIBS) |