fix and address comments

2 files changed, 6 insertions, 18 deletions

diff --git a/tools/lib/h5diff.c b/tools/lib/h5diff.c
index 5acdde8..d0371c7 100644
--- a/tools/lib/h5diff.c
+++ b/tools/lib/h5diff.c
@@ -907,15 +907,9 @@ h5diff(const char *fname1,
                  parallel_print("file1     file2\n");
              parallel_print("---------------------------------------\n");
              for(u = 0; u < match_list->nobjs; u++) {
-                 char c1, c2;
-                 if (match_list->objs[u].flags[0])
-                     c1 = 'x';
-                 else
-                     c1 = ' ';
-                 if (match_list->objs[u].flags[1])
-                     c2 = 'x';
-                 else
-                     c2 = ' ';
+                 int c1, c2;
+                 c1 = (match_list->objs[u].flags[0]) ? 'x' : ' ';
+                 c2 = (match_list->objs[u].flags[1]) ? 'x' : ' ';
                  parallel_print("%5c %6c    %-15s\n", c1, c2, match_list->objs[u].name);
              } /* end for */
              parallel_print ("\n");
diff --git a/tools/lib/h5diff_attr.c b/tools/lib/h5diff_attr.c
index a648be1..8f5ab0f 100644
--- a/tools/lib/h5diff_attr.c
+++ b/tools/lib/h5diff_attr.c
@@ -273,15 +273,9 @@ static herr_t build_match_list_attrs(hid_t loc1_id, hid_t loc2_id, table_attrs_t
         parallel_print("   obj1   obj2\n");
         parallel_print(" --------------------------------------\n");
         for(i = 0; i < (unsigned int) table_lp->nattrs; i++) {
-            char c1, c2;
-            if (table_lp->attrs[i].exist[0])
-                c1 = 'x';
-            else
-                c1 = ' ';
-            if (table_lp->attrs[i].exist[1])
-                c2 = 'x';
-            else
-                c2 = ' ';
+            int c1, c2;
+            c1 = (table_lp->attrs[i].exist[0]) ? 'x' : ' ';
+            c2 = (table_lp->attrs[i].exist[1]) ? 'x' : ' ';
             parallel_print("%5c %6c    %-15s\n", c1, c2, table_lp->attrs[i].name);
         } /* end for */
     }