1 12 Whitespace changes after clang-format run (#288)

* OESS-98 fix tools test for plugins

* sync fork

* Merge of changes from dev

* Move problem option to bottom of the list until fixed

* HDFFV-11106 - fix parsing optional args

* HDFFV-11106 add note

* grammer fix

* Whitespace after clang formatting

* Undo format version 11 changes

* Update check to working version

10 files changed, 37 insertions, 39 deletions

diff --git a/tools/lib/h5diff.c b/tools/lib/h5diff.c
index aa72998..ec83d91 100644
--- a/tools/lib/h5diff.c
+++ b/tools/lib/h5diff.c
@@ -692,7 +692,7 @@ h5diff(const char *fname1, const char *fname2, const char *objname1, const char
             /* Use the asprintf() routine, since it does what we're trying to do below */
             if (HDasprintf(&obj1fullname, "/%s", objname1) < 0)
                 H5TOOLS_GOTO_ERROR(H5DIFF_ERR, "name buffer allocation failed");
-#else /* H5_HAVE_ASPRINTF */
+#else  /* H5_HAVE_ASPRINTF */
             /* (malloc 2 more for "/" and end-of-line) */
             if ((obj1fullname = (char *)HDmalloc(HDstrlen(objname1) + 2)) == NULL)
                 H5TOOLS_GOTO_ERROR(H5DIFF_ERR, "name buffer allocation failed");
@@ -711,7 +711,7 @@ h5diff(const char *fname1, const char *fname2, const char *objname1, const char
             /* Use the asprintf() routine, since it does what we're trying to do below */
             if (HDasprintf(&obj2fullname, "/%s", objname2) < 0)
                 H5TOOLS_GOTO_ERROR(H5DIFF_ERR, "name buffer allocation failed");
-#else /* H5_HAVE_ASPRINTF */
+#else  /* H5_HAVE_ASPRINTF */
             /* (malloc 2 more for "/" and end-of-line) */
             if ((obj2fullname = (char *)HDmalloc(HDstrlen(objname2) + 2)) == NULL)
                 H5TOOLS_GOTO_ERROR(H5DIFF_ERR, "name buffer allocation failed");
@@ -1174,7 +1174,7 @@ diff_match(hid_t file1_id, const char *grp1, trav_info_t *info1, hid_t file2_id,
                 if (HDasprintf(&obj1_fullpath, "%s%s", grp1_path, table->objs[i].name) < 0) {
                     H5TOOLS_ERROR(H5DIFF_ERR, "name buffer allocation failed");
                 }
-#else /* H5_HAVE_ASPRINTF */
+#else  /* H5_HAVE_ASPRINTF */
             if ((obj1_fullpath = (char *)HDmalloc(HDstrlen(grp1_path) + HDstrlen(table->objs[i].name) + 1)) ==
                 NULL) {
                 H5TOOLS_ERROR(H5DIFF_ERR, "name buffer allocation failed");
@@ -1192,7 +1192,7 @@ diff_match(hid_t file1_id, const char *grp1, trav_info_t *info1, hid_t file2_id,
                 if (HDasprintf(&obj2_fullpath, "%s%s", grp2_path, table->objs[i].name) < 0) {
                     H5TOOLS_ERROR(H5DIFF_ERR, "name buffer allocation failed");
                 }
-#else /* H5_HAVE_ASPRINTF */
+#else  /* H5_HAVE_ASPRINTF */
             if ((obj2_fullpath = (char *)HDmalloc(HDstrlen(grp2_path) + HDstrlen(table->objs[i].name) + 1)) ==
                 NULL) {
                 H5TOOLS_ERROR(H5DIFF_ERR, "name buffer allocation failed");
@@ -1388,7 +1388,7 @@ diff_match(hid_t file1_id, const char *grp1, trav_info_t *info1, hid_t file2_id,
                         }     /* end else */
                     }         /* end if */
                 }             /* end else */
-#endif /* H5_HAVE_PARALLEL */
+#endif                        /* H5_HAVE_PARALLEL */
                 if (obj1_fullpath)
                     HDfree(obj1_fullpath);
                 if (obj2_fullpath)
diff --git a/tools/lib/h5diff_array.c b/tools/lib/h5diff_array.c
index b3efeab..b998784 100644
--- a/tools/lib/h5diff_array.c
+++ b/tools/lib/h5diff_array.c
@@ -1279,7 +1279,7 @@ diff_datum(void *_mem1, void *_mem2, hsize_t elemtno, diff_opt_t *opts, hid_t co
                 }
                 nfound += diff_ldouble_element(mem1, mem2, elemtno, opts);
             } /*H5T_NATIVE_LDOUBLE*/
-#endif /* H5_SIZEOF_LONG_DOUBLE */
+#endif        /* H5_SIZEOF_LONG_DOUBLE */
 
             break; /* H5T_FLOAT class */
 
diff --git a/tools/lib/h5tools_str.c b/tools/lib/h5tools_str.c
index 01577db..533237c 100644
--- a/tools/lib/h5tools_str.c
+++ b/tools/lib/h5tools_str.c
@@ -932,7 +932,7 @@ h5tools_str_sprint(h5tools_str_t *str, const h5tool_format_t *info, hid_t contai
                         h5tools_str_append(str, OPT(info->fmt_llong, fmt_llong), templlong);
                     }
                 } /* end if (sizeof(long long) == nsize) */
-#endif /* H5_SIZEOF_LONG != H5_SIZEOF_LONG_LONG */
+#endif            /* H5_SIZEOF_LONG != H5_SIZEOF_LONG_LONG */
                 break;
 
             case H5T_COMPOUND:
@@ -1268,7 +1268,7 @@ h5tools_str_sprint(h5tools_str_t *str, const h5tool_format_t *info, hid_t contai
                         for (x = 0; x < ctx->indent_level + 1; x++)
                             h5tools_str_append(str, "%s", OPT(info->line_indent, ""));
                     } /* end if */
-#endif /* LATER */
+#endif                /* LATER */
 
                     ctx->indent_level++;
 
diff --git a/tools/lib/h5tools_utils.c b/tools/lib/h5tools_utils.c
index 9c5999b..4d39816 100644
--- a/tools/lib/h5tools_utils.c
+++ b/tools/lib/h5tools_utils.c
@@ -194,10 +194,10 @@ get_option(int argc, const char **argv, const char *opts, const struct long_opti
 
     if (sp == 1 && argv[opt_ind][0] == '-' && argv[opt_ind][1] == '-') {
         /* long command line option */
-        int         i;
-        const char  ch = '=';
-        char *arg = &argv[opt_ind][2];
-        size_t arg_len = 0;
+        int        i;
+        const char ch      = '=';
+        char *     arg     = &argv[opt_ind][2];
+        size_t     arg_len = 0;
 
         opt_arg = strchr(&argv[opt_ind][2], ch);
         arg_len = HDstrlen(&argv[opt_ind][2]);
@@ -224,7 +224,7 @@ get_option(int argc, const char **argv, const char *opts, const struct long_opti
                         else if (l_opts[i].has_arg == require_arg) {
                             if (opt_err)
                                 HDfprintf(rawerrorstream, "%s: option required for \"--%s\" flag\n", argv[0],
-                                        arg);
+                                          arg);
 
                             opt_opt = '?';
                         }
@@ -384,8 +384,6 @@ get_option(int argc, const char **argv, const char *opts, const struct long_opti
  * Programmer: Jacob Smith
  *             2017-11-10
  *
- * Changes: None.
- *
  *****************************************************************************
  */
 herr_t
diff --git a/tools/libtest/h5tools_test_utils.c b/tools/libtest/h5tools_test_utils.c
index 969dbab..80873fd 100644
--- a/tools/libtest/h5tools_test_utils.c
+++ b/tools/libtest/h5tools_test_utils.c
@@ -613,7 +613,7 @@ test_populate_ros3_fa(void)
 
     hbool_t show_progress = FALSE;
     int     bad_version   = 0xf87a; /* arbitrarily wrong version number */
-#endif /* H5_HAVE_ROS3_VFD */
+#endif                              /* H5_HAVE_ROS3_VFD */
 
     TESTING("programmatic ros3 fapl population");
 
@@ -1028,7 +1028,7 @@ test_set_configured_fapl(void)
         "",   /* user name             */
         2048, /* stream buffer size    */
     };
-#endif /* H5_HAVE_LIBHDFS */
+#endif                    /* H5_HAVE_LIBHDFS */
     unsigned n_cases = 7; /* number of common testcases */
     testcase cases[] = {
         {
@@ -1279,7 +1279,7 @@ main(void)
 
 #ifdef _H5TEST_
     h5reset(); /* h5test? */
-#endif /* _H5TEST_ */
+#endif         /* _H5TEST_ */
 
     HDfprintf(stdout, "Testing h5tools_utils corpus.\n");
 
diff --git a/tools/src/h5dump/h5dump.h b/tools/src/h5dump/h5dump.h
index 9392ca3..b4198ad 100644
--- a/tools/src/h5dump/h5dump.h
+++ b/tools/src/h5dump/h5dump.h
@@ -83,7 +83,7 @@ typedef struct {
 dump_opt_t dump_opts = {TRUE, FALSE, TRUE,  TRUE,  FALSE, FALSE, FALSE, FALSE, FALSE,
                         TRUE, FALSE, FALSE, FALSE, FALSE, TRUE,  FALSE, 0};
 
-#define PACKED_BITS_MAX      8 /* Maximum number of packed-bits to display */
+#define PACKED_BITS_MAX      8                       /* Maximum number of packed-bits to display */
 #define PACKED_BITS_SIZE_MAX (8 * sizeof(long long)) /* Maximum bits size of integer types of packed-bits */
 /* mask list for packed bits */
 unsigned long long packed_mask[PACKED_BITS_MAX]; /* packed bits are restricted to 8*sizeof(llong) bytes */
diff --git a/tools/src/h5dump/h5dump_extern.h b/tools/src/h5dump/h5dump_extern.h
index 56734cf..6ccd159 100644
--- a/tools/src/h5dump/h5dump_extern.h
+++ b/tools/src/h5dump/h5dump_extern.h
@@ -80,7 +80,7 @@ typedef struct {
 } dump_opt_t;
 extern dump_opt_t dump_opts;
 
-#define PACKED_BITS_MAX      8 /* Maximum number of packed-bits to display */
+#define PACKED_BITS_MAX      8                     /* Maximum number of packed-bits to display */
 #define PACKED_BITS_SIZE_MAX 8 * sizeof(long long) /* Maximum bits size of integer types of packed-bits */
 /* mask list for packed bits */
 extern unsigned long long
diff --git a/tools/test/perform/perf.c b/tools/test/perform/perf.c
index df4c569..22aca04 100644
--- a/tools/test/perform/perf.c
+++ b/tools/test/perform/perf.c
@@ -465,7 +465,7 @@ parse_args(int argc, char **argv)
  * End:
  */
 
-#else /* H5_HAVE_PARALLEL */
+#else  /* H5_HAVE_PARALLEL */
 /* dummy program since H5_HAVE_PARALLEL is not configured in */
 int
 main(int H5_ATTR_UNUSED argc, char H5_ATTR_UNUSED **argv)
diff --git a/tools/test/perform/pio_standalone.h b/tools/test/perform/pio_standalone.h
index 2f812d7..d64f421 100644
--- a/tools/test/perform/pio_standalone.h
+++ b/tools/test/perform/pio_standalone.h
@@ -224,14 +224,14 @@ H5_DLL int Wgettimeofday(struct timeval *tv, struct timezone *tz);
 #define HDisalnum(C)     isalnum((int)(C)) /*cast for solaris warning*/
 #define HDisalpha(C)     isalpha((int)(C)) /*cast for solaris warning*/
 #define HDisatty(F)      isatty(F)
-#define HDiscntrl(C)     iscntrl((int)(C)) /*cast for solaris warning*/
-#define HDisdigit(C)     isdigit((int)(C)) /*cast for solaris warning*/
-#define HDisgraph(C)     isgraph((int)(C)) /*cast for solaris warning*/
-#define HDislower(C)     islower((int)(C)) /*cast for solaris warning*/
-#define HDisprint(C)     isprint((int)(C)) /*cast for solaris warning*/
-#define HDispunct(C)     ispunct((int)(C)) /*cast for solaris warning*/
-#define HDisspace(C)     isspace((int)(C)) /*cast for solaris warning*/
-#define HDisupper(C)     isupper((int)(C)) /*cast for solaris warning*/
+#define HDiscntrl(C)     iscntrl((int)(C))  /*cast for solaris warning*/
+#define HDisdigit(C)     isdigit((int)(C))  /*cast for solaris warning*/
+#define HDisgraph(C)     isgraph((int)(C))  /*cast for solaris warning*/
+#define HDislower(C)     islower((int)(C))  /*cast for solaris warning*/
+#define HDisprint(C)     isprint((int)(C))  /*cast for solaris warning*/
+#define HDispunct(C)     ispunct((int)(C))  /*cast for solaris warning*/
+#define HDisspace(C)     isspace((int)(C))  /*cast for solaris warning*/
+#define HDisupper(C)     isupper((int)(C))  /*cast for solaris warning*/
 #define HDisxdigit(C)    isxdigit((int)(C)) /*cast for solaris warning*/
 #define HDkill(P, S)     kill(P, S)
 #define HDlabs(X)        labs(X)
@@ -458,7 +458,7 @@ H5_DLL int c99_vsnprintf(char *str, size_t size, const char *format, va_list ap)
 #else /* H5_HAVE_WIN32_API */
 
 #if !defined strdup && !defined H5_HAVE_STRDUP
-extern char *strdup(const char *s);
+extern char *         strdup(const char *s);
 #endif
 
 #define HDstrdup(S) strdup(S)
diff --git a/tools/test/perform/sio_standalone.h b/tools/test/perform/sio_standalone.h
index c0e0793..4001257 100644
--- a/tools/test/perform/sio_standalone.h
+++ b/tools/test/perform/sio_standalone.h
@@ -239,14 +239,14 @@ H5_DLL int Wgettimeofday(struct timeval *tv, struct timezone *tz);
 #define HDisalnum(C)     isalnum((int)(C)) /*cast for solaris warning*/
 #define HDisalpha(C)     isalpha((int)(C)) /*cast for solaris warning*/
 #define HDisatty(F)      isatty(F)
-#define HDiscntrl(C)     iscntrl((int)(C)) /*cast for solaris warning*/
-#define HDisdigit(C)     isdigit((int)(C)) /*cast for solaris warning*/
-#define HDisgraph(C)     isgraph((int)(C)) /*cast for solaris warning*/
-#define HDislower(C)     islower((int)(C)) /*cast for solaris warning*/
-#define HDisprint(C)     isprint((int)(C)) /*cast for solaris warning*/
-#define HDispunct(C)     ispunct((int)(C)) /*cast for solaris warning*/
-#define HDisspace(C)     isspace((int)(C)) /*cast for solaris warning*/
-#define HDisupper(C)     isupper((int)(C)) /*cast for solaris warning*/
+#define HDiscntrl(C)     iscntrl((int)(C))  /*cast for solaris warning*/
+#define HDisdigit(C)     isdigit((int)(C))  /*cast for solaris warning*/
+#define HDisgraph(C)     isgraph((int)(C))  /*cast for solaris warning*/
+#define HDislower(C)     islower((int)(C))  /*cast for solaris warning*/
+#define HDisprint(C)     isprint((int)(C))  /*cast for solaris warning*/
+#define HDispunct(C)     ispunct((int)(C))  /*cast for solaris warning*/
+#define HDisspace(C)     isspace((int)(C))  /*cast for solaris warning*/
+#define HDisupper(C)     isupper((int)(C))  /*cast for solaris warning*/
 #define HDisxdigit(C)    isxdigit((int)(C)) /*cast for solaris warning*/
 #define HDkill(P, S)     kill(P, S)
 #define HDlabs(X)        labs(X)
@@ -473,7 +473,7 @@ H5_DLL int c99_vsnprintf(char *str, size_t size, const char *format, va_list ap)
 #else /* H5_HAVE_WIN32_API */
 
 #if !defined strdup && !defined H5_HAVE_STRDUP
-extern char *strdup(const char *s);
+extern char *         strdup(const char *s);
 #endif
 
 #define HDstrdup(S) strdup(S)