summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--release_docs/RELEASE.txt14
-rw-r--r--src/H5Oint.c7
2 files changed, 20 insertions, 1 deletions
diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt
index 7b90b8a..c938ce0 100644
--- a/release_docs/RELEASE.txt
+++ b/release_docs/RELEASE.txt
@@ -223,6 +223,20 @@ Bug Fixes since HDF5-1.12.1 release
===================================
Library
-------
+
+ - Memory leak
+
+ Memory leak was detected when running h5dump with "pov". The memory was allocated
+ via H5FL__malloc() in hdf5/src/H5FL.c
+
+ The fuzzed file "pov" was an HDF5 file containing an illegal continuation message.
+ When deserializing the object header chunks for the file, memory is allocated for the
+ array of continuation messages (cont_msg_info->msgs) in continuation message info struct.
+ As error is encountered in loading the illegal message, the memory allocated for
+ cont_msg_info->msgs needs to be freed.
+
+ (VC - 2023/04/11 GH-2599)
+
- Fixed a memory corruption issue that can occur when reading
from a dataset using a hyperslab selection in the file
dataspace and a point selection in the memory dataspace
diff --git a/src/H5Oint.c b/src/H5Oint.c
index 48f25c9..16a5028 100644
--- a/src/H5Oint.c
+++ b/src/H5Oint.c
@@ -1169,9 +1169,14 @@ H5O_protect(const H5O_loc_t *loc, unsigned prot_flags, hbool_t pin_all_chunks)
ret_value = oh;
done:
- if (ret_value == NULL && oh)
+ if (ret_value == NULL && oh) {
+ /* Release any continuation messages built up */
+ if (cont_msg_info.msgs)
+ cont_msg_info.msgs = (H5O_cont_t *)H5FL_SEQ_FREE(H5O_cont_t, cont_msg_info.msgs);
+
if (H5O_unprotect(loc, oh, H5AC__NO_FLAGS_SET) < 0)
HDONE_ERROR(H5E_OHDR, H5E_CANTUNPROTECT, NULL, "unable to release object header")
+ }
FUNC_LEAVE_NOAPI_TAG(ret_value)
} /* end H5O_protect() */