summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)Allen Byrne2019-12-0280-837/+1275
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '0772b975d1d2bfa15aedeb4b6e2c2aac78c61a2f': Fix missing free in H5T__ref_mem_read() Fix bugs in H5VL file comparison code. Add short circuit success to H5VL_cmp_connector_cls(). Implement file comparison VOL callback. Other changes to allow references to work with non-native connectors. There is a bug somewhere. Add support for point selections to H5S_select_project_intersection. Remove H5VL_NATIVE_FILE_GET_FILE_ID and add H5VL_OBJECT_GET_FILE Revert "Make a squash commit of 'Quiet some warnings by adjusting warnings level and fixing some code.' (commit 5c911d8baf3)" Revert "Oops, remove more C99 designated initializers for VS 2010 compatibility." H5R: fix H5Tconv to check for null references Trivial parameter renaming in VOL API calls. Move checking for zero offset in selection adjust calls to the selection callbacks. This makes the procedure for checking it consistent across selection types and between _s and _u, ensures it is always is performed even when called within the H5S package, and removes the redundant check that would occur when callins H5S_select_adjust_s() from outside the H5S package. Replace H5Sselect_adjust_u() and H5Shyper_adjust_s() with H5Sselect_adjust. Implement "adjust_s" callback for all selection types. Add range checking to H5Sselect_adjust().
| * Merge pull request #2063 in HDFFV/hdf5 from ~NFORTNE2/hdf5_naf:vol_file_cmp ↵Neil Fortner2019-12-015-34/+163
| |\ | | | | | | | | | | | | | | | | | | | | | | | | to develop * commit '40b2658b4b266b4dc65ec3db2897e0aaf54f8e42': Fix missing free in H5T__ref_mem_read() Fix bugs in H5VL file comparison code. Add short circuit success to H5VL_cmp_connector_cls(). Implement file comparison VOL callback. Other changes to allow references to work with non-native connectors. There is a bug somewhere.
| | * Fix missing free in H5T__ref_mem_read()Neil Fortner2019-11-291-0/+2
| | |
| | * Fix bugs in H5VL file comparison code. Add short circuit success toNeil Fortner2019-11-283-10/+16
| | | | | | | | | | | | H5VL_cmp_connector_cls().
| | * Implement file comparison VOL callback. Other changes to allowNeil Fortner2019-11-274-31/+152
| | | | | | | | | | | | | | | references to work with non-native connectors. There is a bug somewhere.
| * | Merge pull request #2059 in HDFFV/hdf5 from ~JSOUMAGNE/hdf5:topic_nullref to ↵Jerome Soumagne2019-11-285-46/+304
| |\ \ | | |/ | |/| | | | | | | | | | | | | develop * commit '6b68cc352ffabb5fe997db1eb52216b3ee80e669': H5R: fix H5Tconv to check for null references
| | * H5R: fix H5Tconv to check for null referencesJerome Soumagne2019-11-265-46/+304
| | | | | | | | | | | | | | | | | | Valid for both deprecated and non-deprecated references Update test
| * | Merge pull request #2050 in HDFFV/hdf5 from ~NFORTNE2/hdf5_naf:point_spi to ↵Neil Fortner2019-11-271-17/+113
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | develop * commit 'ad2fbb022e096233444489e69b93343a4b7e9631': Add support for point selections to H5S_select_project_intersection.
| | * | Add support for point selections to H5S_select_project_intersection.Neil Fortner2019-11-271-17/+113
| | | |
| * | | Merge pull request #2057 in HDFFV/hdf5 from ↵Jerome Soumagne2019-11-2716-103/+88
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ~JSOUMAGNE/hdf5:topic_get_file_id_native to develop * commit 'f46494ffd8449fc610798c8af312362608029d3d': Remove H5VL_NATIVE_FILE_GET_FILE_ID and add H5VL_OBJECT_GET_FILE
| | * | | Remove H5VL_NATIVE_FILE_GET_FILE_ID and add H5VL_OBJECT_GET_FILEJerome Soumagne2019-11-2716-103/+88
| | | |/ | | |/| | | | | | | | | Remove H5F__get_file_id() and use only private routine instead
| * | | Merge pull request #2062 in HDFFV/hdf5 from ↵David Young2019-11-2752-504/+311
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ~DYOUNG/vchoi_fork:revert-c99-designated to develop * commit '0108072f7a746b809952d5cc560577f931b64f71': Revert "Make a squash commit of 'Quiet some warnings by adjusting warnings level and fixing some code.' (commit 5c911d8baf3)" Revert "Oops, remove more C99 designated initializers for VS 2010 compatibility."
| | * | | Revert "Make a squash commit of 'Quiet some warnings by adjusting warnings ↵David Young2019-11-2752-498/+314
| | | | | | | | | | | | | | | | | | | | level and fixing some code.' (commit 5c911d8baf3)"
| | * | | Revert "Oops, remove more C99 designated initializers for VS 2010 ↵David Young2019-11-274-14/+5
| |/ / / | | | | | | | | | | | | | | | | | | | | compatibility." This reverts commit f907b511d06612dafc7814a7c30f2f3d2b76d52b.
| * | | Merge pull request #2045 in HDFFV/hdf5 from ~NFORTNE2/hdf5_naf:select_adjust ↵Neil Fortner2019-11-269-113/+276
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to develop * commit '4e12984b77cdd7615843d94f8de8d54db27476ac': Move checking for zero offset in selection adjust calls to the selection callbacks. This makes the procedure for checking it consistent across selection types and between _s and _u, ensures it is always is performed even when called within the H5S package, and removes the redundant check that would occur when callins H5S_select_adjust_s() from outside the H5S package. Replace H5Sselect_adjust_u() and H5Shyper_adjust_s() with H5Sselect_adjust. Implement "adjust_s" callback for all selection types. Add range checking to H5Sselect_adjust().
| | * | | Move checking for zero offset in selection adjust calls to the selection ↵Neil Fortner2019-11-183-87/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | callbacks. This makes the procedure for checking it consistent across selection types and between _s and _u, ensures it is always is performed even when called within the H5S package, and removes the redundant check that would occur when callins H5S_select_adjust_s() from outside the H5S package.
| | * | | Replace H5Sselect_adjust_u() and H5Shyper_adjust_s() withNeil Fortner2019-11-189-60/+210
| | | | | | | | | | | | | | | | | | | | | | | | | H5Sselect_adjust. Implement "adjust_s" callback for all selection types. Add range checking to H5Sselect_adjust().
| * | | | Merge pull request #2054 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:vol_trivial ↵Dana Robinson2019-11-264-23/+23
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to develop * commit '9a93ecac522d9032efd9cdc39ff0550412e54565': Trivial parameter renaming in VOL API calls.
| | * | | | Trivial parameter renaming in VOL API calls.Dana Robinson2019-11-254-23/+23
| | | |/ / | | |/| |
* | | | | Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)Allen Byrne2019-11-2652-311/+504
|\ \ \ \ \ | |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'a8892bb42d6f6e4fbc30fae0eb2b957f81c938b9': (45 commits) Oops, remove more C99 designated initializers for VS 2010 compatibility. Add an #include to get a function declaration. Don't use C99 designated initializers, they're not compatible with Visual Studio 2010. Quiet some more maybe-uninitialized warnings---each is a false positive, *sigh*. This is more code that may not compile with VS2010, *sigh sigh*. Always warn on maybe-uninitialized. -Wincompatible-pointer-types was not available until GCC 5, so enable it only if that's the GCC version we're using. Only promote maybe-uninitialized warnings to errors on GCC 8. Even on GCC 8, there may be false positives at low optimization levels? I need to check. Only use -Werror=cast-function-type with GCC 8 and later. Put all of the -W options back into the order I found them in so that it's easier to compare old and new config/gnu-flags. Add new source files to CMakeLists.txt. Mention the -Werror= flags in libhdf5.settings.in. free -> HDfree Promote decleration-after-statement warnings to errors. Quiet decleration-after-statement warnings. Move a statement under some declarations since some vintages of Visual Studio don't like declarations after statements. Document H5D__chunk_mem_xfree_wrapper(). Undo accidental test deletion. Oops, delete a debug printf that snuck in here. Undo my changes to the HD macros, hadn't really intended those to be on this branch.... Make errors of some more warnings. Move disabled warnings to DEVELOPER_WARNING_CFLAGS. Put just one warning option on a line, and sort some of the options. Cast to the parameter type, H5VL_token_t *, instead of to unsigned char *. ...
| * | | | Merge pull request #2055 in HDFFV/hdf5 from ↵David Young2019-11-254-5/+14
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit 'f907b511d06612dafc7814a7c30f2f3d2b76d52b': Oops, remove more C99 designated initializers for VS 2010 compatibility.
| | * | | | Oops, remove more C99 designated initializers for VS 2010 compatibility.David Young2019-11-254-5/+14
| | | | | |
| * | | | | Merge pull request #2030 in HDFFV/hdf5 from ↵David Young2019-11-2552-314/+498
| |\ \ \ \ \ | | |/ / / / | | | / / / | | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop * commit '62208b056a09c01855fbac7f75146be58ad6bfe5': (44 commits) Add an #include to get a function declaration. Don't use C99 designated initializers, they're not compatible with Visual Studio 2010. Quiet some more maybe-uninitialized warnings---each is a false positive, *sigh*. This is more code that may not compile with VS2010, *sigh sigh*. Always warn on maybe-uninitialized. -Wincompatible-pointer-types was not available until GCC 5, so enable it only if that's the GCC version we're using. Only promote maybe-uninitialized warnings to errors on GCC 8. Even on GCC 8, there may be false positives at low optimization levels? I need to check. Only use -Werror=cast-function-type with GCC 8 and later. Put all of the -W options back into the order I found them in so that it's easier to compare old and new config/gnu-flags. Add new source files to CMakeLists.txt. Mention the -Werror= flags in libhdf5.settings.in. free -> HDfree Promote decleration-after-statement warnings to errors. Quiet decleration-after-statement warnings. Move a statement under some declarations since some vintages of Visual Studio don't like declarations after statements. Document H5D__chunk_mem_xfree_wrapper(). Undo accidental test deletion. Oops, delete a debug printf that snuck in here. Undo my changes to the HD macros, hadn't really intended those to be on this branch.... Make errors of some more warnings. Move disabled warnings to DEVELOPER_WARNING_CFLAGS. Put just one warning option on a line, and sort some of the options. Cast to the parameter type, H5VL_token_t *, instead of to unsigned char *. Change hdset_reg_ref_t and H5R_ref_t from arrays of unsigned char to structs containing those arrays. Encapsulating the arrays in this way makes it easier to write and think about pointers to these types, casts to/from these types, etc. ...
| | * | | Add an #include to get a function declaration.David Young2019-11-251-0/+1
| | | | |
| | * | | Merge remote-tracking branch 'hdf5/develop' into add-werror-and-squash-someDavid Young2019-11-2531-180/+667
| | |\ \ \ | | |/ / / | |/| | |
| | * | | Don't use C99 designated initializers, they're not compatible withDavid Young2019-11-253-16/+24
| | | | | | | | | | | | | | | | | | | | Visual Studio 2010.
| | * | | Quiet some more maybe-uninitialized warnings---each is a false positive,David Young2019-11-223-3/+16
| | | | | | | | | | | | | | | | | | | | | | | | | *sigh*. This is more code that may not compile with VS2010, *sigh sigh*.
| | * | | Always warn on maybe-uninitialized. -Wincompatible-pointer-types was notDavid Young2019-11-221-2/+2
| | | | | | | | | | | | | | | | | | | | available until GCC 5, so enable it only if that's the GCC version we're using.
| | * | | Only promote maybe-uninitialized warnings to errors on GCC 8. Even onDavid Young2019-11-221-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | GCC 8, there may be false positives at low optimization levels? I need to check.
| | * | | Only use -Werror=cast-function-type with GCC 8 and later.David Young2019-11-221-1/+1
| | | | |
| | * | | Put all of the -W options back into the order I found them in so that it'sDavid Young2019-11-221-29/+23
| | | | | | | | | | | | | | | | | | | | easier to compare old and new config/gnu-flags.
| | * | | Add new source files to CMakeLists.txt.David Young2019-11-201-0/+2
| | | | |
| | * | | Mention the -Werror= flags in libhdf5.settings.in.David Young2019-11-201-1/+1
| | | | |
| | * | | free -> HDfreeDavid Young2019-11-201-1/+1
| | | | |
| | * | | Promote decleration-after-statement warnings to errors.David Young2019-11-131-1/+1
| | | | |
| | * | | Quiet decleration-after-statement warnings.David Young2019-11-132-6/+5
| | | | |
| | * | | Move a statement under some declarations since some vintages of VisualDavid Young2019-11-131-1/+2
| | | | | | | | | | | | | | | | | | | | Studio don't like declarations after statements.
| | * | | Document H5D__chunk_mem_xfree_wrapper().David Young2019-11-131-0/+5
| | | | |
| | * | | Undo accidental test deletion.David Young2019-11-131-1/+1
| | | | |
| | * | | Oops, delete a debug printf that snuck in here.David Young2019-11-131-1/+0
| | | | |
| | * | | Undo my changes to the HD macros, hadn't really intended those to be onDavid Young2019-11-131-7/+7
| | | | | | | | | | | | | | | | | | | | this branch....
| | * | | Make errors of some more warnings. Move disabled warnings toDavid Young2019-11-131-31/+43
| | | | | | | | | | | | | | | | | | | | | | | | | DEVELOPER_WARNING_CFLAGS. Put just one warning option on a line, and sort some of the options.
| | * | | Cast to the parameter type, H5VL_token_t *, instead of to unsigned char *.David Young2019-11-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | (H5VL_token_t, too, probably should turn from a typedef for a constant-length array to an array encapsulated in a struct.)
| | * | | Change hdset_reg_ref_t and H5R_ref_t from arrays of unsigned char toDavid Young2019-11-133-136/+145
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | structs containing those arrays. Encapsulating the arrays in this way makes it easier to write and think about pointers to these types, casts to/from these types, etc. An interesting side-effect that we probably should *not* rely on is that the struct-encapsulation changes the alignment so that some GCC warnings about casts that increase the alignment requirement of the operand go away. Warnings like that have to be taken seriously: I will add -Werror=cast-align to the default compiler flags so that they stop the build quickly. GCC warnings led me to some surprising casts in test/trefer.c. I found that it was possible to make many simplifications after introducing the struct-encapsulation that I described, above.
| | * | | In every instance, `x` is initialized by `memcpy`, but GCC isn't smartDavid Young2019-11-131-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | enough to figure that out. Quiet some warnings by always initializing `x` to 0.
| | * | | `same_file` is assigned but never used. Delete it.David Young2019-11-131-8/+0
| | | | |
| | * | | Don't assign a constant string to a pointer to non-constant character.David Young2019-11-131-1/+1
| | | | |
| | * | | GCC isn't smart enough to realize that `fill_c` is always initializedDavid Young2019-11-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | and exclusively used in `datatype == H5T_COMPOUND` branches, so just initialize it at its declaration so that GCC doesn't warn.
| | * | | I'm not sure what the previous code was trying to do, casting an arrayDavid Young2019-11-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of `hsize_t`, `start`, to `long long`, but I think the way that I have rewritten it, it probably produces a more useful result? As a bonus, GCC has stopped warning about it.
| | * | | Quiet a warning about an unused variable. This code looks like itDavid Young2019-11-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | should be heavily restructured to avoid the use of globals like `pass`, but that's a project for another day and another person.